From: John Fastabend <john.fastabend@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>,
jakub@cloudflare.com, daniel@iogearbox.net, edumazet@google.com,
cong.wang@bytedance.com, lmb@isovalent.com
Cc: john.fastabend@gmail.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
will@isovalent.com
Subject: RE: [PATCH bpf v4 00/12] bpf sockmap fixes
Date: Wed, 05 Apr 2023 17:14:13 -0700 [thread overview]
Message-ID: <642e0ed567494_37d6a208a5@john.notmuch> (raw)
In-Reply-To: <20230405220904.153149-1-john.fastabend@gmail.com>
John Fastabend wrote:
> Fixes for sockmap running against NGINX TCP tests and also on an
> underprovisioned VM so that we hit error (ENOMEM) cases regularly.
>
> The first 3 patches fix cases related to ENOMEM that were either
> causing splats or data hangs.
>
> Then 4-7 resolved cases found when running NGINX with its sockets
> assigned to sockmap. These mostly have to do with handling fin/shutdown
> incorrectly and ensuring epoll_wait works as expected.
>
> Patches 8 and 9 extract some of the logic used for sockmap_listen tests
> so that we can use it in other tests because it didn't make much
> sense to me to add tests to the sockmap_listen cases when here we
> are testing send/recv *basic* cases.
>
> Finally patches 10, 11 and 12 add the new tests to ensure we handle
> ioctl(FIONREAD) and shutdown correctly.
>
> To test the series I ran the NGINX compliance tests and the sockmap
> selftests. For now our compliance test just runs with SK_PASS.
>
> There are some more things to be done here, but these 11 patches
> stand on their own in my opionion and fix issues we are having in
> CI now. For bpf-next we can fixup/improve selftests to use the
> ASSERT_* in sockmap_helpers, streamline some of the testing, and
> add more tests. We also still are debugging a few additional flakes
> patches coming soon.
>
> v2: use skb_queue_empty instead of *_empty_lockless (Eric)
> oops incorrectly updated copied_seq on DROP case (Eric)
> added test for drop case copied_seq update
>
> v3: Fix up comment to use /**/ formatting and update commit
> message to capture discussion about previous fix attempt
> for hanging backlog being imcomplete.
>
> v4: build error sockmap things are behind NET_SKMSG not in
> BPF_SYSCALL otherwise you can build the .c file but not
> have correct headers.
>
Will send a v5 with typo fix. Thanks.
prev parent reply other threads:[~2023-04-06 0:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 22:08 [PATCH bpf v4 00/12] bpf sockmap fixes John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 01/12] bpf: sockmap, pass skb ownership through read_skb John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 02/12] bpf: sockmap, convert schedule_work into delayed_work John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 03/12] bpf: sockmap, improved check for empty queue John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 04/12] bpf: sockmap, handle fin correctly John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 05/12] bpf: sockmap, TCP data stall on recv before accept John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 06/12] bpf: sockmap, wake up polling after data copy John Fastabend
2023-04-05 22:08 ` [PATCH bpf v4 07/12] bpf: sockmap incorrectly handling copied_seq John Fastabend
2023-04-06 1:26 ` kernel test robot
2023-04-05 22:09 ` [PATCH bpf v4 08/12] bpf: sockmap, pull socket helpers out of listen test for general use John Fastabend
2023-04-05 22:09 ` [PATCH bpf v4 09/12] bpf: sockmap, build helper to create connected socket pair John Fastabend
2023-04-05 22:09 ` [PATCH bpf v4 10/12] bpf: sockmap, test shutdown() correctly exits epoll and recv()=0 John Fastabend
2023-04-05 22:09 ` [PATCH bpf v4 11/12] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer John Fastabend
2023-04-05 22:09 ` [PATCH bpf v4 12/12] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer with drops John Fastabend
2023-04-06 0:14 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642e0ed567494_37d6a208a5@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=lmb@isovalent.com \
--cc=netdev@vger.kernel.org \
--cc=will@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.