From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F05C76196 for ; Thu, 6 Apr 2023 22:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239379AbjDFW6R (ORCPT ); Thu, 6 Apr 2023 18:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbjDFW6Q (ORCPT ); Thu, 6 Apr 2023 18:58:16 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F4D08A55 for ; Thu, 6 Apr 2023 15:58:16 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1a0729e72c9so525215ad.3 for ; Thu, 06 Apr 2023 15:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680821895; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=MlCMBaiF6CrM9E029g8nSryHni1f2kcvCzubhY5iI14=; b=gaAqTVzIv0GtrsT2gko7r/O1pDRuvli3yBUZkRnSoljXc7wh6yOCgO7trqieYfdWKk gRGuFYivjIm9pGiFCtw46AUgmINk/73ZEP5G8Q6BqMmXPkfX08PU9gneL4YHYcfjLlpA fnNkcCO2PknZiwLf1yGllWAcIZlmlhG403Fmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680821895; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MlCMBaiF6CrM9E029g8nSryHni1f2kcvCzubhY5iI14=; b=UFAOfz2QqYTtijy9A3ovMxgFv9HWRUSrSv0RwEKPZBxXy3NAVjYtcotBy5TVj4B8Oy toiLi8n+nWgR82UiQ5K7+5F2urkAz86UJo1mjIFNH0tObTlvQdqdUzyGGP5kc12iYIBL u1Sbm0tqo9kNt4McF5e865IOLLMeCc6IcomSpDAZsNRNaJeRn9w2rsDWKwFNvBI//L8P Hmenl2lkzkP7ENOQQYE8ml1GzKyP+z5RykeUnP+pn6cFy0oDuhW1slt6BonV4qA4itkD lhqY5XX/je/GX/ZOVJeQibMDxRsZiSQ3xYihoit/PcIe/7GeHXY0pIZgkQ1dlNSCqIzA LeyA== X-Gm-Message-State: AAQBX9cfBqG1b2jQOzdHJaDmYNnXIe4wI2kUqBW+6K8/SSEivYYHCF8c 1dYG2PtTS71Wwjj7qmQ5lW8ChQ== X-Google-Smtp-Source: AKy350bgyVCFJBnbiJGa3rk5DD6kuc5x0UAVO9GqJwsqVmytbKzjyrHsJBAUy1++ISyALQXo9HUTsQ== X-Received: by 2002:aa7:8f37:0:b0:624:3061:7dbf with SMTP id y23-20020aa78f37000000b0062430617dbfmr426545pfr.25.1680821895634; Thu, 06 Apr 2023 15:58:15 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id e20-20020aa78c54000000b0059085684b54sm1888972pfd.140.2023.04.06.15.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 15:58:15 -0700 (PDT) Message-ID: <642f4e87.a70a0220.6d16d.4391@mx.google.com> X-Google-Original-Message-ID: <202304061558.@keescook> Date: Thu, 6 Apr 2023 15:58:14 -0700 From: Kees Cook To: Miguel Ojeda Cc: linux-hardening@vger.kernel.org, Kees Cook , Andy Shevchenko , Cezary Rojewski , Puyou Lu , Mark Brown , Josh Poimboeuf , Peter Zijlstra , Brendan Higgins , David Gow , Andrew Morton , Nathan Chancellor , Alexander Potapenko , Zhaoyang Huang , Randy Dunlap , Geert Uytterhoeven , Miguel Ojeda , Nick Desaulniers , Liam Howlett , Vlastimil Babka , Dan Williams , Rasmus Villemoes , Yury Norov , "Jason A. Donenfeld" , Sander Vanheule , Eric Biggers , "Masami Hiramatsu (Google)" , Andrey Konovalov , Linus Walleij , Daniel Latypov , =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= , linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH 4/9] fortify: Add protection for strlcat() References: <20230405235832.never.487-kees@kernel.org> <20230406000212.3442647-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Thu, Apr 06, 2023 at 03:32:40PM +0200, Miguel Ojeda wrote: > On Thu, Apr 6, 2023 at 2:02 AM Kees Cook wrote: > > > > + size_t p_size = __member_size(p); > > + size_t q_size = __member_size(q); > > Since I noticed the patches appear to go for const-correctness even > for parameters (which is great, I support it), these could be `const` > too. Will do. Thanks! -- Kees Cook