From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 0/2] clean up interrupt handle
Date: Tue, 04 Apr 2017 12:12:33 +0200
Message-ID: <6430789.TYnjRxi5iG@xps13>
References: <20170331020913.19004-1-qi.z.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Qi Zhang <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com
 [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id D8546326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 12:12:35 +0200 (CEST)
Received: by mail-wr0-f175.google.com with SMTP id w43so206874247wrb.0
 for <dev@dpdk.org>; Tue, 04 Apr 2017 03:12:35 -0700 (PDT)
In-Reply-To: <20170331020913.19004-1-qi.z.zhang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

2017-03-30 22:09, Qi Zhang:
> It seems its not necessary to register an intr_handle for interrupt callback 
> function. "void* cb_arg" shows enough when be used to pass the object that 
> contain the information be required to handle the interrupt event( A typical
> way which is implemented by almost all driver is by passing a rte_ethdev 
> instance). The patch change the prototype of rte_intr_callback_fn by removing
> the uncessary intr_handle paramter.
> 
> v3:
> - update bnx2x driver which is missed in v1,v2
> 
> v2:
> - seperate patch 1 in v1 into 2 patches.
> - correct some commit log.
> 
> Qi Zhang (2):
>   eal: clean up interrupt handle
>   app/test: update test code

Several comments:

* You forgot to use --in-reply-to, so it is not convenient to check the history.

* Please keep the the prior acked-by in your patches if there are.

* There is another miss in this patch:

drivers/net/mlx5/mlx5_ethdev.c:1259:10:
fatal error: incompatible pointer types passing
'void (struct rte_intr_handle *, void *)'
to parameter of type 'rte_intr_callback_fn'
(aka 'void (*)(void *)') [-Wincompatible-pointer-types]
    mlx5_dev_interrupt_handler,

* The second patch is clearly not up to date as the file
app/test/test_interrupts.c has moved.