Re: [PATCH] SCSI/SD: clearer output of disk cache state

[Luben Tuikov <ltuikov@yahoo.com>]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

--- James Bottomley <James.Bottomley@SteelEye.com> wrote:
> On Sat, 2006-11-04 at 16:45 -0800, Luben Tuikov wrote:
> > Re-based:
> > 
> > Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
> 
> It still won't apply ... this time it looks like a mailer tab->space
> conversion problem.

Attached.

    Luben

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>


[-- Attachment #2: 2974651858-sd.txt --]
[-- Type: text/plain, Size: 1007 bytes --]

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 84ff203..ffbd021 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1467,7 +1467,6 @@ sd_read_cache_type(struct scsi_disk *sdk
 	res = sd_do_mode_sense(sdp, dbd, modepage, buffer, len, &data, &sshdr);
 
 	if (scsi_status_is_good(res)) {
-		int ct = 0;
 		int offset = data.header_length + data.block_descriptor_length;
 
 		if (offset >= SD_BUF_SIZE - 2) {
@@ -1496,11 +1495,13 @@ sd_read_cache_type(struct scsi_disk *sdk
 			sdkp->DPOFUA = 0;
 		}
 
-		ct =  sdkp->RCD + 2*sdkp->WCE;
-
-		printk(KERN_NOTICE "SCSI device %s: drive cache: %s%s\n",
-		       diskname, sd_cache_types[ct],
-		       sdkp->DPOFUA ? " w/ FUA" : "");
+		printk(KERN_NOTICE "SCSI device %s: "
+		       "write cache: %s, read cache: %s, %s\n",
+		       diskname,
+		       sdkp->WCE ? "enabled" : "disabled",
+		       sdkp->RCD ? "disabled" : "enabled",
+		       sdkp->DPOFUA ? "supports DPO and FUA"
+		       : "doesn't support DPO or FUA");
 
 		return;
 	}