All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin KaFai Lau <martin.lau@linux.dev>
To: Grant Seltzer <grantseltzer@gmail.com>
Cc: andrii@kernel.org, kpsingh@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v2 bpf-next] Add support for tracing programs in BPF_PROG_RUN
Date: Fri, 3 Feb 2023 22:58:20 -0800	[thread overview]
Message-ID: <6433db0e-5cc6-8acc-b92f-eb5e17f032d6@linux.dev> (raw)
In-Reply-To: <20230203182812.20657-1-grantseltzer@gmail.com>

On 2/3/23 10:28 AM, Grant Seltzer wrote:
> This patch changes the behavior of how BPF_PROG_RUN treats tracing
> (fentry/fexit) programs. Previously only a return value is injected
> but the actual program was not run.

hmm... I don't understand this. The actual program is run by attaching to the 
bpf_fentry_test{1,2,3...}. eg. The test in fentry_test.c

> New behavior mirrors that of running raw tracepoint BPF programs which
> actually runs the instructions of the program via `bpf_prog_run()`

Which tracepoint and how is it tested?

The CI kernel is crashing:
https://patchwork.kernel.org/project/netdevbpf/patch/20230203182812.20657-1-grantseltzer@gmail.com/


  reply	other threads:[~2023-02-04  6:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 18:28 [PATCH v2 bpf-next] Add support for tracing programs in BPF_PROG_RUN Grant Seltzer
2023-02-04  6:58 ` Martin KaFai Lau [this message]
2023-02-05 17:29   ` Grant Seltzer Richman
2023-02-06 20:37     ` Martin KaFai Lau
2023-02-07 15:46       ` Grant Seltzer Richman
2023-02-08  1:05         ` Martin KaFai Lau
2023-02-08 15:40           ` Grant Seltzer Richman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6433db0e-5cc6-8acc-b92f-eb5e17f032d6@linux.dev \
    --to=martin.lau@linux.dev \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=grantseltzer@gmail.com \
    --cc=kpsingh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.