From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 2/2] dt-bindings: add document for rk3399-vop Date: Tue, 19 Apr 2016 09:58:52 +0200 Message-ID: <6435836.sTKjWLANC0@diego> References: <1460949478-2236-1-git-send-email-mark.yao@rock-chips.com> <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: Mark Rutland , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org cGF0Y2ggc3ViamVjdCBhYm92ZToKZHQtYmluZGluZ3M6IGFkZCBkb2N1bWVudGF0aW9uIGZvciBS b2NrY2hpcCByazMzOTkgZGlzcGxheSBjb250cm9sbGVycwoKbm90IGV2ZXJ5Ym9keSBza2ltbWlu ZyBvdmVyIHBhdGNoZXMgZGlyZWN0bHkga25vd3Mgd2hhdCBhIHZvcCBpcyA7LSkKCkkgc3RpbGwg YmVsaWV2ZSBldmVuIHN1Y2ggYSB0cml2aWFsIHBhdGNoIHNob3VsZCBhbHNvIGdldCBzb21lIGZv cm0gb2YgCmRlc2NyaXB0aW9uLCBzb21ldGhpbmcgbGlrZToKCi0tLS0tLS0tLQpEb2N1bWVudCBj b21wYXRpYmxlIHZhbHVlcyBmb3IgcmszMzk5IGRpc3BsYXkgY29udHJvbGxlcnMuCkJpZyBhbmQg bGl0dGxlIGRpc3BsYXkgY29udHJvbGxlcnMgYXJlIG5vdCBpZGVudGljYWwgYW5kIGhhdmUgZGlm ZmVyaW5nIApmZWF0dXJlIHNldHMgb24gdGhlIHJrMzM5OS4KLS0tLS0tLS0tCgo+IENjOiBSb2Ig SGVycmluZyA8cm9iaCtkdEBrZXJuZWwub3JnPgo+IENjOiBQYXdlbCBNb2xsIDxwYXdlbC5tb2xs QGFybS5jb20+Cj4gQ2M6IE1hcmsgUnV0bGFuZCA8bWFyay5ydXRsYW5kQGFybS5jb20+Cj4gQ2M6 IElhbiBDYW1wYmVsbCA8aWpjK2RldmljZXRyZWVAaGVsbGlvbi5vcmcudWs+Cj4gQ2M6IEt1bWFy IEdhbGEgPGdhbGFrQGNvZGVhdXJvcmEub3JnPgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hcmsgWWFv IDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4KPiAtLS0KPiAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkv cm9ja2NoaXAvcm9ja2NoaXAtdm9wLnR4dCAgICAgfCAgICAyICsrCj4gIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0Cj4gYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9yb2NrY2hpcC12b3AudHh0Cj4gYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9yb2NrY2hpcC12 b3AudHh0IGluZGV4Cj4gNTQ4OWI1OS4uZmQyNWVhOSAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9yb2NrY2hpcC12b3AudHh0 Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2No aXAvcm9ja2NoaXAtdm9wLnR4dAo+IEBAIC04LDYgKzgsOCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVz Ogo+ICAtIGNvbXBhdGlibGU6IHZhbHVlIHNob3VsZCBiZSBvbmUgb2YgdGhlIGZvbGxvd2luZwo+ ICAJCSJyb2NrY2hpcCxyazMyODgtdm9wIjsKPiAgCQkicm9ja2NoaXAscmszMDM2LXZvcCI7Cj4g KwkJInJvY2tjaGlwLHJrMzM5OS12b3AtYmlnIjsKPiArCQkicm9ja2NoaXAscmszMzk5LXZvcC1s aXQiOwo+IAo+ICAtIGludGVycnVwdHM6IHNob3VsZCBjb250YWluIGEgbGlzdCBvZiBhbGwgVk9Q IElQIGJsb2NrIGludGVycnVwdHMgaW4gdGhlCj4gIAkJIG9yZGVyOiBWU1lOQywgTENEX1NZU1RF TS4gVGhlIGludGVycnVwdCBzcGVjaWZpZXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Tue, 19 Apr 2016 09:58:52 +0200 Subject: [PATCH 2/2] dt-bindings: add document for rk3399-vop In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com> References: <1460949478-2236-1-git-send-email-mark.yao@rock-chips.com> <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com> Message-ID: <6435836.sTKjWLANC0@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org patch subject above: dt-bindings: add documentation for Rockchip rk3399 display controllers not everybody skimming over patches directly knows what a vop is ;-) I still believe even such a trivial patch should also get some form of description, something like: --------- Document compatible values for rk3399 display controllers. Big and little display controllers are not identical and have differing feature sets on the rk3399. --------- > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > > Signed-off-by: Mark Yao > --- > .../bindings/display/rockchip/rockchip-vop.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index > 5489b59..fd25ea9 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > @@ -8,6 +8,8 @@ Required properties: > - compatible: value should be one of the following > "rockchip,rk3288-vop"; > "rockchip,rk3036-vop"; > + "rockchip,rk3399-vop-big"; > + "rockchip,rk3399-vop-lit"; > > - interrupts: should contain a list of all VOP IP block interrupts in the > order: VSYNC, LCD_SYSTEM. The interrupt specifier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbcDSH7D (ORCPT ); Tue, 19 Apr 2016 03:59:03 -0400 Received: from gloria.sntech.de ([95.129.55.99]:39322 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbcDSH7B (ORCPT ); Tue, 19 Apr 2016 03:59:01 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Mark Yao Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH 2/2] dt-bindings: add document for rk3399-vop Date: Tue, 19 Apr 2016 09:58:52 +0200 Message-ID: <6435836.sTKjWLANC0@diego> User-Agent: KMail/4.14.10 (Linux/4.4.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com> References: <1460949478-2236-1-git-send-email-mark.yao@rock-chips.com> <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org patch subject above: dt-bindings: add documentation for Rockchip rk3399 display controllers not everybody skimming over patches directly knows what a vop is ;-) I still believe even such a trivial patch should also get some form of description, something like: --------- Document compatible values for rk3399 display controllers. Big and little display controllers are not identical and have differing feature sets on the rk3399. --------- > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > > Signed-off-by: Mark Yao > --- > .../bindings/display/rockchip/rockchip-vop.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index > 5489b59..fd25ea9 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > @@ -8,6 +8,8 @@ Required properties: > - compatible: value should be one of the following > "rockchip,rk3288-vop"; > "rockchip,rk3036-vop"; > + "rockchip,rk3399-vop-big"; > + "rockchip,rk3399-vop-lit"; > > - interrupts: should contain a list of all VOP IP block interrupts in the > order: VSYNC, LCD_SYSTEM. The interrupt specifier