From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C53C6FD18 for ; Wed, 19 Apr 2023 14:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbjDSOie (ORCPT ); Wed, 19 Apr 2023 10:38:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233085AbjDSOid (ORCPT ); Wed, 19 Apr 2023 10:38:33 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8137C3C17; Wed, 19 Apr 2023 07:38:31 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id he11-20020a05600c540b00b003ef6d684102so1568822wmb.3; Wed, 19 Apr 2023 07:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681915110; x=1684507110; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=pRLB4jafvDSF5N3zbFXDTvNqa3CWokYQT7DnSmldu+s=; b=B6s2epmCAFJBrmAoB93mRJYd/ff0qly363oyJkb5paDWH4zH4tdPVJFuITaSc1N72l U4HOTyjY88hj/udELRS4uSsrNpX5Vpe17ZUdi4PI3fI7mxs93bxsNH/lHXhAtxTrYF3X i9RchJQa5d4MWGxMb7ZxqdEbEsXlWy5QyUpsoiS9jq/wk84HwkYHCeDhdlaDpOvN+Htu Oxt4nxTx6igTQpl1D/YjYYQFslkA/GlMXAAK6XWyLulRa2HfeYEP30j0TSAF5jggaNRw 6jP7dxN14tx+r8E/mw9Lp7VGwEfMhTVokzsg46F+eIHoMyLbe57euwMka7/nx7vlLAPc jXDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681915110; x=1684507110; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pRLB4jafvDSF5N3zbFXDTvNqa3CWokYQT7DnSmldu+s=; b=T8aSBHJlNG46OLRHSqbty/MNf1skaCeraAf5Gj1QKZ1ejAn711d925OQOGQNvaotd4 rjZWk2P3l4MwODynOxEwNvLS3nzzhqHkzY49W7p2D8+TnUJmZKQYyhvfTEO56csGOpcR zOfjdFA3fHBovzzbjD+9JmZPniH3U5eucbJUCDvomI3AudahbXzzkVbMMrU+La5Qxf80 Rvwcy8SWmEou1UhbmkonlSzTtiXJXkfXmvyt9VVlxt+6l18Rjmi+3ui2+OyLtMx45oLq vPy8KFOxUXXYO2FcTTEp9R6HakeZ6Z9Nt8jlk8NxOocP/Vu7R98H6O/FnX96q9fiZRy3 DP6A== X-Gm-Message-State: AAQBX9c74N46jhIt65zZs2arG+tYdbr/WgTfRKP8BjCK6qg0JkOPBO3J Ly1/3oknkxNEy93hHssl6Jo= X-Google-Smtp-Source: AKy350aAVpJgiBuQowINe7K2XwUMEspk5c7HruQFKHK8h6zPcSaAvxR/p4r/S6XEU+mKmXvjSgNJ6w== X-Received: by 2002:a1c:4c02:0:b0:3f1:78a7:6bd2 with SMTP id z2-20020a1c4c02000000b003f178a76bd2mr5488015wmf.27.1681915109688; Wed, 19 Apr 2023 07:38:29 -0700 (PDT) Received: from Ansuel-xps. (93-34-93-173.ip49.fastwebnet.it. [93.34.93.173]) by smtp.gmail.com with ESMTPSA id m14-20020a056000008e00b002c71b4d476asm15911066wrx.106.2023.04.19.07.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 07:38:28 -0700 (PDT) Message-ID: <643ffce4.050a0220.73dcc.1bec@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 19 Apr 2023 16:38:26 +0200 From: Christian Marangi To: Krzysztof Kozlowski Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Jonathan Corbet , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org, Jonathan McDowell Subject: Re: [net-next PATCH v7 13/16] ARM: dts: qcom: ipq8064-rb3011: Add Switch LED for each port References: <20230417151738.19426-1-ansuelsmth@gmail.com> <20230417151738.19426-14-ansuelsmth@gmail.com> <289b7604-d32d-49d9-8f06-87147d6fd473@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <289b7604-d32d-49d9-8f06-87147d6fd473@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Apr 19, 2023 at 02:53:45PM +0200, Krzysztof Kozlowski wrote: > On 17/04/2023 17:17, Christian Marangi wrote: > > Add Switch LED for each port for MikroTik RB3011UiAS-RM. > > > > MikroTik RB3011UiAS-RM is a 10 port device with 2 qca8337 switch chips > > connected. > > > > It was discovered that in the hardware design all 3 Switch LED trace of > > the related port is connected to the same LED. This was discovered by > > setting to 'always on' the related led in the switch regs and noticing > > that all 3 LED for the specific port (for example for port 1) cause the > > connected LED for port 1 to turn on. As an extra test we tried enabling > > 2 different LED for the port resulting in the LED turned off only if > > every led in the reg was off. > > > > Aside from this funny and strange hardware implementation, the device > > itself have one green LED for each port, resulting in 10 green LED one > > for each of the 10 supported port. > > > > Cc: Jonathan McDowell > > Signed-off-by: Christian Marangi > > --- > > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 120 ++++++++++++++++++++++ > > Please do not send the DTS patches to the net-next, but to the Qualcomm > SoC maintainers. The DTS must not be mixed with driver code. > Hi, sorry for the mess, it was asked to give an user of the LED feature for qca8k so I was a bit confused on where to include it and at the end I decided to put it in this series. What was the correct way? 2 different series and reference the DT one in the net-next? (or not targetting net-next at all?) -- Ansuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43161C6FD18 for ; Wed, 19 Apr 2023 14:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LBk4N/fKtlg8Gzz7vtJmAiw2POIRGXHAhiIvj2RGYNc=; b=0xibvOD+VcXDOx q+xaE+YHzC9fWHBp6p5GdAGvD5Mmtb6oy7F4K+dNVY69DcfcpVcpGJHb7X70iXoRwpGk6+I8swDh6 6swQTSUOYlxELYdaOR4v1wFWzK752vPoTH7Rm+HdVwxzIWHxL2MOhpMbG5J7slBx7xkyUicoEiiW+ SdmEb//vfdAKq4Frp3T4FKS2e+QAdZHTp63cRrECs+hp9sHCpJFueHHuKHnqZEQjKqBT1emJiudYL N665iSu1918MaJaoAgIVQH12dxJfGbdt4Q1RQuVh0KlMYISjmQ/Cz6VUpu6SGP3UbIHNrfPHWYGk6 iMSaQOKvl8nIquIji6mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pp8xC-005hDd-1P; Wed, 19 Apr 2023 14:38:38 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pp8x9-005hBg-04 for linux-arm-kernel@lists.infradead.org; Wed, 19 Apr 2023 14:38:36 +0000 Received: by mail-wm1-x336.google.com with SMTP id v3so4198702wml.0 for ; Wed, 19 Apr 2023 07:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681915110; x=1684507110; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=pRLB4jafvDSF5N3zbFXDTvNqa3CWokYQT7DnSmldu+s=; b=B6s2epmCAFJBrmAoB93mRJYd/ff0qly363oyJkb5paDWH4zH4tdPVJFuITaSc1N72l U4HOTyjY88hj/udELRS4uSsrNpX5Vpe17ZUdi4PI3fI7mxs93bxsNH/lHXhAtxTrYF3X i9RchJQa5d4MWGxMb7ZxqdEbEsXlWy5QyUpsoiS9jq/wk84HwkYHCeDhdlaDpOvN+Htu Oxt4nxTx6igTQpl1D/YjYYQFslkA/GlMXAAK6XWyLulRa2HfeYEP30j0TSAF5jggaNRw 6jP7dxN14tx+r8E/mw9Lp7VGwEfMhTVokzsg46F+eIHoMyLbe57euwMka7/nx7vlLAPc jXDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681915110; x=1684507110; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pRLB4jafvDSF5N3zbFXDTvNqa3CWokYQT7DnSmldu+s=; b=hHSVXyIJT0bX4lyBPe5uR0QGXXXS1ia7a2VcDNwlPYwHGy2z53PswEVOkCHaqBOmnJ 0iaUNjBhyykrMKdJ23Jki5+n034H2ZyD1EmLCvQbLg34xZ6T1DBZ5qwsH+3VQk439EWj I6cjKpe5AsERBZP/2koD5axoUQUBlxsXlNsuCjnQkf96Avdv4L6wjcUQQsdIFOqx5xbY IDwuV7EVTZkdD4uee6wE3vzxBCeWnbawwKSzIpN07LIRuQ0tp9dy9rA3X7sgOUGv1yuL HVQfsbeLi4O3wYBjc4lWlkVewlZ2jhRRqxTOmJzTTJgL1Y4kSrsfmRz4tMmSm3xZAsGm g7mQ== X-Gm-Message-State: AAQBX9e2p5E4WbDaTkWgIPB3qOJa/fHDfiKEwA1fRhXsrIZAyHiaeuRo AJm9nEyPqcQd0FBQskhCxpw= X-Google-Smtp-Source: AKy350aAVpJgiBuQowINe7K2XwUMEspk5c7HruQFKHK8h6zPcSaAvxR/p4r/S6XEU+mKmXvjSgNJ6w== X-Received: by 2002:a1c:4c02:0:b0:3f1:78a7:6bd2 with SMTP id z2-20020a1c4c02000000b003f178a76bd2mr5488015wmf.27.1681915109688; Wed, 19 Apr 2023 07:38:29 -0700 (PDT) Received: from Ansuel-xps. (93-34-93-173.ip49.fastwebnet.it. [93.34.93.173]) by smtp.gmail.com with ESMTPSA id m14-20020a056000008e00b002c71b4d476asm15911066wrx.106.2023.04.19.07.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 07:38:28 -0700 (PDT) Message-ID: <643ffce4.050a0220.73dcc.1bec@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 19 Apr 2023 16:38:26 +0200 From: Christian Marangi To: Krzysztof Kozlowski Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Jonathan Corbet , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org, Jonathan McDowell Subject: Re: [net-next PATCH v7 13/16] ARM: dts: qcom: ipq8064-rb3011: Add Switch LED for each port References: <20230417151738.19426-1-ansuelsmth@gmail.com> <20230417151738.19426-14-ansuelsmth@gmail.com> <289b7604-d32d-49d9-8f06-87147d6fd473@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <289b7604-d32d-49d9-8f06-87147d6fd473@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230419_073835_061783_E111C719 X-CRM114-Status: GOOD ( 25.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 19, 2023 at 02:53:45PM +0200, Krzysztof Kozlowski wrote: > On 17/04/2023 17:17, Christian Marangi wrote: > > Add Switch LED for each port for MikroTik RB3011UiAS-RM. > > > > MikroTik RB3011UiAS-RM is a 10 port device with 2 qca8337 switch chips > > connected. > > > > It was discovered that in the hardware design all 3 Switch LED trace of > > the related port is connected to the same LED. This was discovered by > > setting to 'always on' the related led in the switch regs and noticing > > that all 3 LED for the specific port (for example for port 1) cause the > > connected LED for port 1 to turn on. As an extra test we tried enabling > > 2 different LED for the port resulting in the LED turned off only if > > every led in the reg was off. > > > > Aside from this funny and strange hardware implementation, the device > > itself have one green LED for each port, resulting in 10 green LED one > > for each of the 10 supported port. > > > > Cc: Jonathan McDowell > > Signed-off-by: Christian Marangi > > --- > > arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 120 ++++++++++++++++++++++ > > Please do not send the DTS patches to the net-next, but to the Qualcomm > SoC maintainers. The DTS must not be mixed with driver code. > Hi, sorry for the mess, it was asked to give an user of the LED feature for qca8k so I was a bit confused on where to include it and at the end I decided to put it in this series. What was the correct way? 2 different series and reference the DT one in the net-next? (or not targetting net-next at all?) -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel