All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aristeu Rozanski <aris@redhat.com>
To: Ewan Milne <emilne@redhat.com>
Cc: linux-nvme@lists.infradead.org,
	Justin Tee <justin.tee@broadcom.com>,
	 Naresh Gottumukkala <nareshgottumukkala83@gmail.com>,
	Paul Ely <paul.ely@broadcom.com>,
	 Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>,  Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: fc: stop lsrcv workqueue before freeing a rport
Date: Fri, 14 Nov 2025 13:42:03 -0500	[thread overview]
Message-ID: <6440e968-a181-419b-b203-a354b924341b@work> (raw)
In-Reply-To: <CAGtn9rmSq9+6o1-=tQwYGRKRUSOXkSJnCdSosNnpW0BvnxaNLQ@mail.gmail.com>

Hi Ewan,

On Fri, Nov 14, 2025 at 12:47:14PM -0500, Ewan Milne wrote:
> OK, but it seems to me that if lsrcv_work is pending then lsrcv_list likely
> has entries on it.
> So does this fix the whole problem?
> 
> Could you maybe add WARN_ON(!list_empty(&rport->ls_rcv_list)); so we'll
> find out?

since I can reproduce it easily (less than an hour usually) I'll add the
WARN_ON and double check if it triggers before the bug reproduces.
Thanks

-- 
Aristeu



  parent reply	other threads:[~2025-11-14 18:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14 15:07 [PATCH] nvme: fc: stop lsrcv workqueue before freeing a rport Aristeu Rozanski
     [not found] ` <CAGtn9rmSq9+6o1-=tQwYGRKRUSOXkSJnCdSosNnpW0BvnxaNLQ@mail.gmail.com>
2025-11-14 18:42   ` Aristeu Rozanski [this message]
2025-11-15  0:56     ` Justin Tee
2025-11-15  3:50       ` Aristeu Rozanski
2025-11-17 23:17         ` Justin Tee
2025-12-03  1:36           ` Justin Tee
     [not found]             ` <CAGtn9rmQW9w42oMVGpXZB4OuifwF3XzgVaxuHyXN1aYpzjRskg@mail.gmail.com>
2025-12-04  1:44               ` Justin Tee
2025-12-04  3:59                 ` Aristeu Rozanski
2025-12-04 19:46                   ` Justin Tee
2025-11-15  3:56   ` Aristeu Rozanski
     [not found]     ` <CAGtn9r=n024waWZekDMwSRAM+JM13FYWhXjPuA18WyO6Kcmnyw@mail.gmail.com>
2025-11-17  5:06       ` Aristeu Rozanski
2025-11-18 14:45       ` Aristeu Rozanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6440e968-a181-419b-b203-a354b924341b@work \
    --to=aris@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=justin.tee@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nareshgottumukkala83@gmail.com \
    --cc=paul.ely@broadcom.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.