Re: [PATCH v5 2/3] hw/s390x: add Control-Program Identification to QOM

[Nina Schoetterl-Glausch <nsg@linux.ibm.com>]

On Thu, 2025-06-05 at 14:03 +0200, Thomas Huth wrote:
> On 05/06/2025 13.56, Thomas Huth wrote:
> > On 05/06/2025 10.34, Nina Schoetterl-Glausch wrote:
> > > On Tue, 2025-06-03 at 15:56 +0200, Shalini Chellathurai Saroja wrote:
> > > > Add Control-Program Identification (CPI) data to the QEMU Object
> > > > Model (QOM), along with the timestamp in which the data was received
> > > > as shown below.
> > > 
> > > [...]
> > > > 
> > > > Signed-off-by: Shalini Chellathurai Saroja <shalini@linux.ibm.com>
> > > > ---

[...]
> 
> PS: FWIW, Markus recently also provided a nice summery about the different 
> property types here:
>   https://lore.kernel.org/qemu-devel/87o6vfzdig.fsf@pond.sub.org/

Thanks!

> This Property part of qdev isn't actually device-specific.  We could
> lift it into Object.  But would that be an improvement?  I'm not sure;
> QOM is confusing enough as it is.

:D indeed it is.

-- 
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294