Re: [PATCH 1/2] drm: fsl-dcu: Use dev_err_probe

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi,

this series is uncommented for some time now. Any feedback?

Thanks,
Alexander

Am Montag, 13. Februar 2023, 09:24:33 CET schrieb Alexander Stein:
> Hi,
> 
> any feedback on this series?
> 
> Best regards,
> Alexander
> 
> Am Dienstag, 17. Januar 2023, 12:08:00 CET schrieb Alexander Stein:
> > fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe
> > to remove an invalid error message and add it to deferral description.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index
> > 8579c7629f5e..418887654bac 100644
> > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
> > @@ -103,10 +103,8 @@ static int fsl_dcu_load(struct drm_device *dev,
> > unsigned long flags) int ret;
> > 
> >  	ret = fsl_dcu_drm_modeset_init(fsl_dev);
> > 
> > -	if (ret < 0) {
> > -		dev_err(dev->dev, "failed to initialize mode setting\n");
> > -		return ret;
> > -	}
> > +	if (ret < 0)
> > +		return dev_err_probe(dev->dev, ret, "failed to initialize
> 
> mode
> 
> > setting\n");
> > 
> >  	ret = drm_vblank_init(dev, dev->mode_config.num_crtc);
> >  	if (ret < 0) {


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/