From: Alejandro Vallejo <alejandro.vallejo@cloud.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH 1/7] tools: Make some callers of xc_domain_getinfo use xc_domain_getinfolist
Date: Thu, 27 Apr 2023 15:37:12 +0100 [thread overview]
Message-ID: <644a889a.df0a0220.9062c.d2f3@mx.google.com> (raw)
In-Reply-To: <d93a5eaa-1f6f-a2b9-b238-04b8bb1a33dc@citrix.com>
Answers inlined
On Thu, Apr 27, 2023 at 10:51:03AM +0100, Andrew Cooper wrote:
> Just as a note for the subject, we more commonly write function names
> with ()'s.
No harm in abiding by that. Done on v2.
> > + "crashed", (info[i].flags & XEN_DOMINF_shutdown) &&
> > + (dominfo_shutdown_reason(&info[i]) == SHUTDOWN_crash),
>
> Isn't this your dominfo_shutdown_with() from patch 6 ?
>
> I'd pull that forward to this patch too, and use it here.
It is indeed. Done locally on v2.
Cheers,
Alejandro
next prev parent reply other threads:[~2023-04-27 14:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 14:59 [PATCH 0/7] Rationalize usage of xc_domain_getinfo{,list}() Alejandro Vallejo
2023-04-26 14:59 ` [PATCH 1/7] tools: Make some callers of xc_domain_getinfo use xc_domain_getinfolist Alejandro Vallejo
2023-04-27 9:51 ` Andrew Cooper
2023-04-27 14:37 ` Alejandro Vallejo [this message]
2023-04-26 14:59 ` [PATCH 2/7] tools: Create xc_domain_getinfo_single() Alejandro Vallejo
2023-04-27 9:53 ` Andrew Cooper
2023-04-26 14:59 ` [PATCH 3/7] tools: Refactor the console/io.c to avoid using xc_domain_getinfo() Alejandro Vallejo
2023-04-27 10:36 ` Andrew Cooper
2023-04-26 14:59 ` [PATCH 4/7] tools: Make init-xenstore-domain use xc_domain_getinfolist() Alejandro Vallejo
2023-04-26 15:20 ` Juergen Gross
2023-04-27 14:29 ` Alejandro Vallejo
2023-04-26 14:59 ` [PATCH 5/7] tools: Modify single-domid callers of xc_domain_getinfolist Alejandro Vallejo
2023-04-27 11:14 ` Andrew Cooper
2023-04-26 14:59 ` [PATCH 6/7] tools: Use new xc function for some xc_domain_getinfo calls Alejandro Vallejo
2023-04-27 12:35 ` Andrew Cooper
2023-04-27 18:07 ` Alejandro Vallejo
2023-04-26 14:59 ` [PATCH 7/7] domctl: Modify getdomaininfo to fail if domid is not found Alejandro Vallejo
2023-04-27 11:15 ` Andrew Cooper
2023-04-26 22:30 ` Gitlab curiosity: Was [PATCH 0/7] Rationalize usage of xc_domain_getinfo{,list}() Andrew Cooper
2023-04-27 9:26 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644a889a.df0a0220.9062c.d2f3@mx.google.com \
--to=alejandro.vallejo@cloud.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.