Re: [cocci] metavariables in added attribute arguments

[Kees Cook <keescook@chromium.org>]

On Sat, Apr 29, 2023 at 03:17:40PM +0200, Julia Lawall wrote:
> > [...]
> > @annotate@
> > type COUNTER_TYPE, ARRAY_TYPE;
> > identifier allocated.STRUCT;
> > identifier allocated.ARRAY;
> > identifier allocated.COUNTER;
> > attribute name __counted_by;
> > @@
> >
> >  struct STRUCT {
> >         ...
> >         COUNTER_TYPE COUNTER;
> >         ...
> >         ARRAY_TYPE ARRAY[]
> > +       __counted_by(COUNTER)
> >         ;
> >  };
> >
> > This fails like so:
> >
> > $ cocci element_count.cocci net/packet/af_packet.c
> > plus: parse error:
> >   File "element_count.cocci", line 33, column 15, charpos = 593
> >   around = 'COUNTER',
> >   whole content = +     __counted_by(COUNTER)
> >
> > But I can produce (nonsense) output if I change the replacement to:
> >
> > 	ARRAY_TYPE ARRAY[
> > +	COUNTER
> > 	]
> > +	__counted_by
> > 	;
> >
> > Explicitly using "attribute name __counted_by;" didn't seem to help.
> > What am I missing?
> 
> The problem is fixed.  Actually, attributes in this position were just not
> supported at all.  Thanks very much for the report.

Hurray! Thank you; the latest git works as I'd expect now. :) Now to get
my patch for the Linux kernel split up...

 153 files changed, 157 insertions(+), 157 deletions(-)

-- 
Kees Cook