All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Vallejo <alejandro.vallejo@cloud.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Christian Lindig <christian.lindig@citrix.com>
Subject: Re: [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist()
Date: Tue, 2 May 2023 12:17:40 +0100	[thread overview]
Message-ID: <6450f156.df0a0220.8ce3e.2dc6@mx.google.com> (raw)
In-Reply-To: <20230502111338.16757-2-alejandro.vallejo@cloud.com>

On Tue, May 02, 2023 at 12:13:36PM +0100, Alejandro Vallejo wrote:
> xc_domain_getinfolist() internally relies on a sysctl that performs
> a linear search for the domids. Many callers of xc_domain_getinfolist()
> who require information about a precise domid are much better off calling
> xc_domain_getinfo_single() instead, that will use the getdomaininfo domctl
> instead and ensure the returned domid matches the requested one. The domtctl
> will find the domid faster too, because that uses hashed lists.
> 
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@cloud.com>
> ---
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: Wei Liu <wl@xen.org>
> Cc: Anthony PERARD <anthony.perard@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Christian Lindig <christian.lindig@citrix.com>
> 
> v3:
>  * Replaced single-domid xc_domain_getinfolist() call in ocaml stub with
>    xc_domain_getinfo_single()

My mistake here. It's supposed to have a "R-by: Andrew Cooper"


  reply	other threads:[~2023-05-02 11:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02 11:13 [PATCH v3 0/3] Rationalize usage of xc_domain_getinfo{,list}() Alejandro Vallejo
2023-05-02 11:13 ` [PATCH v3 1/3] tools: Modify single-domid callers of xc_domain_getinfolist() Alejandro Vallejo
2023-05-02 11:17   ` Alejandro Vallejo [this message]
2023-05-02 12:50   ` Christian Lindig
2023-05-03 16:36   ` Anthony PERARD
2023-05-02 11:13 ` [PATCH v3 2/3] tools: Use new xc function for some xc_domain_getinfo() calls Alejandro Vallejo
2023-05-02 11:18   ` Alejandro Vallejo
2023-05-02 13:02     ` Andrew Cooper
2023-05-03 17:02   ` Anthony PERARD
2023-05-02 11:13 ` [PATCH v3 3/3] domctl: Modify XEN_DOMCTL_getdomaininfo to fail if domid is not found Alejandro Vallejo
2023-05-03 17:12   ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6450f156.df0a0220.8ce3e.2dc6@mx.google.com \
    --to=alejandro.vallejo@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=christian.lindig@citrix.com \
    --cc=jgross@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.