From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Date: Fri, 31 Aug 2012 17:38:13 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: add Maxim MAX197 support Message-Id: <645218150.271690.1346434693393.JavaMail.root@mail.savoirfairelinux.com> List-Id: In-Reply-To: <20120831160750.GC5756@roeck-us.net> References: <1346351995-9038-1-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1346351995-9038-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, Jean Delvare WWVzLCBnb29kIHRvIGtub3cgdGhhdCBpdCBleGlzdHMuIFRoYW5rcyBmb3Igc3BvdHRpbmcgdGhp cyBhbmQgYXBwbHlpbmcgdGhlIHBhdGNoZXMhCgpSZWdhcmRzLApWaXZpZW4KCi0tLS0tIE1haWwg b3JpZ2luYWwgLS0tLS0KRGU6ICJHdWVudGVyIFJvZWNrIiA8bGludXhAcm9lY2stdXMubmV0PgrD gDogIkplYW4gRGVsdmFyZSIgPGtoYWxpQGxpbnV4LWZyLm9yZz4KQ2M6ICJWaXZpZW4gRGlkZWxv dCIgPHZpdmllbi5kaWRlbG90QHNhdm9pcmZhaXJlbGludXguY29tPiwgbG0tc2Vuc29yc0BsbS1z ZW5zb3JzLm9yZywgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwpFbnZvecOpOiBWZW5kcmVk aSAzMSBBb8O7dCAyMDEyIDEyOjA3OjUwCk9iamV0OiBSZTogW1BBVENIXSBod21vbjogYWRkIE1h eGltIE1BWDE5NyBzdXBwb3J0CgpPbiBGcmksIEF1ZyAzMSwgMjAxMiBhdCAwNDozNzoxOFBNICsw MjAwLCBKZWFuIERlbHZhcmUgd3JvdGU6Cj4gT24gVGh1LCAzMCBBdWcgMjAxMiAxNDowOTo1OSAt MDcwMCwgR3VlbnRlciBSb2VjayB3cm90ZToKPiA+IEkgaGF2ZSB0aGUgc29sdXRpb24gZm9yIHRo ZSBwbGF0Zm9ybSBkcml2ZXIuCj4gPiAKPiA+IGVudW0gY2hpcHMgeyBtYXgxOTcsIG1heDE5OSB9 Owo+ID4gCj4gPiBbIC4uLiBdCj4gPiAKPiA+IHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl X2lkIG1heDE5N19kcml2ZXJfaWRzW10gPSB7Cj4gPiAgICAgICAgIHsKPiA+IAkJLm5hbWUgPSAi bWF4MTk3IiwKPiA+IAkJLmRyaXZlcl9kYXRhID0gbWF4MTk3LAo+ID4gCX0sIHsKPiA+IAkJLm5h bWUgPSAibWF4MTk5IiwKPiA+IAkJLmRyaXZlcl9kYXRhID0gbWF4MTk5LAo+ID4gCX0KPiA+IH07 Cj4gPiBNT0RVTEVfREVWSUNFX1RBQkxFKHBsYXRmb3JtLCBtYXgxOTdfZHJpdmVyX2lkcyk7Cj4g Cj4gV293LCBJIHRob3VnaHQgdGhpcyBkaWQgbm90IGV4aXN0IGFuZCB0aGlzIG1hZGUgbWUgcnVt YmxlIGEgbnVtYmVyIG9mCj4gdGltZXMsIGFuZCBub3cgSSBzZWUgdGhpcyB3YXMgZmluYWxseSBp bnRyb2R1Y2VkIG92ZXIgMyB5ZWFycyBhZ28uCj4gQ29vbCEgQW5kIHNwaSBoYXMgaXQgdG9vIG5v dywgd29uZGVyZnVsIHdvcmxkIDopCj4gClNhbWUgaGVyZSAuLi4gYW5kIG5vdyBJIGZlZWwgYSBi aXQgZW1iYXJhc3NlZCB0aGF0IEkgZGlkbid0IGtub3cgOikKCkd1ZW50ZXIKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBs aXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3Jn L21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775Ab2HaRiW (ORCPT ); Fri, 31 Aug 2012 13:38:22 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:51120 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754276Ab2HaRiU convert rfc822-to-8bit (ORCPT ); Fri, 31 Aug 2012 13:38:20 -0400 Date: Fri, 31 Aug 2012 13:38:13 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, Jean Delvare Message-ID: <645218150.271690.1346434693393.JavaMail.root@mail.savoirfairelinux.com> In-Reply-To: <20120831160750.GC5756@roeck-us.net> Subject: Re: [PATCH] hwmon: add Maxim MAX197 support MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [208.88.110.46] X-Mailer: Zimbra 7.1.4_GA_2555 (ZimbraWebClient - FF3.0 (Linux)/7.1.4_GA_2555) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yes, good to know that it exists. Thanks for spotting this and applying the patches! Regards, Vivien ----- Mail original ----- De: "Guenter Roeck" À: "Jean Delvare" Cc: "Vivien Didelot" , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Envoyé: Vendredi 31 Août 2012 12:07:50 Objet: Re: [PATCH] hwmon: add Maxim MAX197 support On Fri, Aug 31, 2012 at 04:37:18PM +0200, Jean Delvare wrote: > On Thu, 30 Aug 2012 14:09:59 -0700, Guenter Roeck wrote: > > I have the solution for the platform driver. > > > > enum chips { max197, max199 }; > > > > [ ... ] > > > > static struct platform_device_id max197_driver_ids[] = { > > { > > .name = "max197", > > .driver_data = max197, > > }, { > > .name = "max199", > > .driver_data = max199, > > } > > }; > > MODULE_DEVICE_TABLE(platform, max197_driver_ids); > > Wow, I thought this did not exist and this made me rumble a number of > times, and now I see this was finally introduced over 3 years ago. > Cool! And spi has it too now, wonderful world :) > Same here ... and now I feel a bit embarassed that I didn't know :) Guenter