From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDF16CAC582 for ; Fri, 12 Sep 2025 10:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b/c+aLlzPVippMK8NInMnaZnqiasS7ApW8X0D7TyHpo=; b=NByJPah6TiZPGR6a8s47lM9Zy7 heTYhlcMRntR8W5rhM3Js3w7KqolOfxgoQITWvVREi8VsFqosYxAJNjGo0mzzmRCanWD4QC3uGasa VrSgaolLK++AN7Y16I2JlUeN7k2mStjVPX0ogdQP6hEYP4WZP9ARKn2GGiLpuH2eHkm0=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1ux1BO-00063J-1g; Fri, 12 Sep 2025 10:39:10 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ux1BM-000630-D3 for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Sep 2025 10:39:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jXGEoIvErVAGTLwkX6qJV/D2lI0jNxhoHZI1De2bWFg=; b=TXnZxQGIAiKxvN7JLZ/uBUJJHF 7uhdGKQl46p9s4p4NqLx12wZ+lHNqNTPA45PefeZASoAlFd0N4sk2y5LRlnbHeN0YcyvZBQG+8xQk xEvUXGToyLUVo30AbKRgtZBHh2/bjtTF7AT+bvk2dk+p2iGyTO8BRP0/9Y9mmXYvzd4s=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jXGEoIvErVAGTLwkX6qJV/D2lI0jNxhoHZI1De2bWFg=; b=XbQmcPv1eA8jdQUa2sc0M9A108 IpYO9lzbm+bgMiDBWCfQtnoZ4oCRTu4A/tNCEtfHatlSecaxV9Fnc7jDlDcdyGK7i6HZtnWB+HZMc Dzb3inyQToASUYW69nu9FaMApNo1idL4U8W6Od07bH4kJd3SwMAJ28gSvfRIZO0BAXH8=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1ux1BL-0000E0-8F for linux-f2fs-devel@lists.sourceforge.net; Fri, 12 Sep 2025 10:39:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7B5986023E; Fri, 12 Sep 2025 10:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC7CBC4CEFA; Fri, 12 Sep 2025 10:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757673536; bh=iPCFZZNGeEXP4VXVwEOl0dkNG1owk4NNFMYpbjH9kgI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=PLGckd0ZoLa+xWUPJPCbrNyz6t6ZLFWHFVE8ilK4gAJPx0557r6mT373s+3OsWxVT 7r33UTrmNbBLYCNfbEcWM48Lbx1GrI/K0V4mweZRSdpYZBZulS9mkSdUsMIQ5MjFDb v9JKc2KgBTW+RSPyR+bXpaGcAp10Ml0lUv7jENmPx4IObMVkrUIbq/c0JocNJN4n+W MsMT/nkYH4UE+9G2qI/cqf68M2V7oB01u4rnoPPU0FZBHIn8xQUno3ln+VY5Eb21ga 1JmcOlJoFRNuCD/p70lNwKs5zOurQXVuFhtKhsGdK6cH5ALNEKaKMbQkDWQK+ZaECj O3pEtE/EVA56Q== Message-ID: <6464ded0-b25e-4ce8-a05b-6caa394fbe63@kernel.org> Date: Fri, 12 Sep 2025 18:38:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: wangzijie References: <2ecb4f74-cc60-4dd4-8dc3-d4f3ff848e87@kernel.org> <20250912100650.3594565-1-wangzijie1@honor.com> Content-Language: en-US In-Reply-To: <20250912100650.3594565-1-wangzijie1@honor.com> X-Headers-End: 1ux1BL-0000E0-8F Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix wrong extent_info data for precache extents X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org, feng.han@honor.com, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gOS8xMi8yMDI1IDY6MDYgUE0sIHdhbmd6aWppZSB3cm90ZToKPj4gT24gOS8xMi8yMDI1IDEx OjM2IEFNLCB3YW5nemlqaWUgd3JvdGU6Cj4+Pj4gT24gOS8xMS8yMDI1IDU6MDcgUE0sIHdhbmd6 aWppZSB3cm90ZToKPj4+Pj4+IE9uIDkvMTAvMjUgMjE6NTgsIHdhbmd6aWppZSB3cm90ZToKPj4+ Pj4+PiBXaGVuIHRoZSBkYXRhIGxheW91dCBpcyBsaWtlIHRoaXM6Cj4+Pj4+Pj4gZG5vZGUxOiAg ICAgICAgICAgICAgICAgICAgIGRub2RlMjoKPj4+Pj4+PiBbMF0gICAgICBBICAgICAgICAgICAg ICAgICAgWzBdICAgIE5FV19BRERSCj4+Pj4+Pj4gWzFdICAgICAgQSsxICAgICAgICAgICAgICAg IFsxXSAgICAweDAKPj4+Pj4+PiAuLi4gICAgICAgICAgICAgICAgICAgICAgICAgLi4uLgo+Pj4+ Pj4+IFsxMDE2XSAgIEErMTAxNgo+Pj4+Pj4+IFsxMDE3XSAgIEIgKEIhPUErMTAxNykgICAgICBb MTAxN10gMHgwCj4+Pj4+Pj4KPj4+Pj4+PiBXZSBjYW4gYnVpbGQgdGhpcyBraW5kIG9mIGxheW91 dCBieSBmb2xsb3dpbmcgc3RlcHMod2l0aCBpX2V4dHJhX2lzaXplOjM2KToKPj4+Pj4+PiAuL2Yy ZnNfaW8gd3JpdGUgMSAwIDE4ODEgcmFuZCBkc3luYyB0ZXN0ZmlsZQo+Pj4+Pj4+IC4vZjJmc19p byB3cml0ZSAxIDE4ODEgMSByYW5kIGJ1ZmZlcmVkIHRlc3RmaWxlCj4+Pj4+Pj4gLi9mMmZzX2lv IGZhbGxvY2F0ZSAwIDc3MDg2NzIgNDA5NiB0ZXN0ZmlsZQo+Pj4+Pj4+Cj4+Pj4+Pj4gQW5kIHdo ZW4gd2UgbWFwIGZpcnN0IGRhdGEgYmxvY2sgaW4gZG5vZGUyLCB3ZSB3aWxsIGdldCB3cm9uZyBl eHRlbnRfaW5mbyBkYXRhOgo+Pj4+Pj4+IG1hcC0+bV9sZW4gPSAxCj4+Pj4+Pj4gb2ZzID0gc3Rh cnRfcGdvZnMgLSBtYXAtPm1fbGJsayA9IDE4ODIgLSAxODgxID0gMQo+Pj4+Pj4+Cj4+Pj4+Pj4g ZWkuZm9mcyA9IHN0YXJ0X3Bnb2ZzID0gMTg4Mgo+Pj4+Pj4+IGVpLmxlbiA9IG1hcC0+bV9sZW4g LSBvZnMgPSAxIC0gMSA9IDAKPj4+Pj4+Pgo+Pj4+Pj4+IEZpeCBpdCBieSBza2lwcGluZyB1cGRh dGluZyB0aGlzIGtpbmQgb2YgZXh0ZW50IGluZm8uCj4+Pj4+Pj4KPj4+Pj4+PiBTaWduZWQtb2Zm LWJ5OiB3YW5nemlqaWUgPHdhbmd6aWppZTFAaG9ub3IuY29tPgo+Pj4+Pj4+IC0tLQo+Pj4+Pj4+ ICAgICBmcy9mMmZzL2RhdGEuYyB8IDMgKysrCj4+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAz IGluc2VydGlvbnMoKykKPj4+Pj4+Pgo+Pj4+Pj4+IGRpZmYgLS1naXQgYS9mcy9mMmZzL2RhdGEu YyBiL2ZzL2YyZnMvZGF0YS5jCj4+Pj4+Pj4gaW5kZXggNzk2MWUwZGRmLi5iOGJiNzE4NTIgMTAw NjQ0Cj4+Pj4+Pj4gLS0tIGEvZnMvZjJmcy9kYXRhLmMKPj4+Pj4+PiArKysgYi9mcy9mMmZzL2Rh dGEuYwo+Pj4+Pj4+IEBAIC0xNjQ5LDYgKzE2NDksOSBAQCBpbnQgZjJmc19tYXBfYmxvY2tzKHN0 cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmMmZzX21hcF9ibG9ja3MgKm1hcCwgaW50IGZsYWcp Cj4+Pj4+Pj4gICAgIAo+Pj4+Pj4+ICAgICAJCXN3aXRjaCAoZmxhZykgewo+Pj4+Pj4+ICAgICAJ CWNhc2UgRjJGU19HRVRfQkxPQ0tfUFJFQ0FDSEU6Cj4+Pj4+Pj4gKwkJCWlmIChfX2lzX3ZhbGlk X2RhdGFfYmxrYWRkcihtYXAtPm1fcGJsaykgJiYKPj4+Pj4+PiArCQkJCXN0YXJ0X3Bnb2ZzIC0g bWFwLT5tX2xibGsgPT0gbWFwLT5tX2xlbikKPj4+Pj4+PiArCQkJCW1hcC0+bV9mbGFncyAmPSB+ RjJGU19NQVBfTUFQUEVEOwo+Pj4+Pj4KPj4+Pj4+IEl0IGxvb2tzIHdlIG1pc3NlZCB0byByZXNl dCB2YWx1ZSBmb3IgbWFwIHZhcmlhYmxlIGluIGYyZnNfcHJlY2FjaGVfZXh0ZW50cygpLAo+Pj4+ Pj4gd2hhdCBkbyB5b3UgdGhpbmsgb2YgdGhpcz8KPj4+Pj4+Cj4+Pj4+PiAtLS0KPj4+Pj4+ICAg ICBmcy9mMmZzL2ZpbGUuYyB8IDQgKysrLQo+Pj4+Pj4gICAgIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+Pj4+Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZnMv ZjJmcy9maWxlLmMgYi9mcy9mMmZzL2ZpbGUuYwo+Pj4+Pj4gaW5kZXggMWFhZTQzNjFkMGE4Li4y YjE0MTUxZDQxMzAgMTAwNjQ0Cj4+Pj4+PiAtLS0gYS9mcy9mMmZzL2ZpbGUuYwo+Pj4+Pj4gKysr IGIvZnMvZjJmcy9maWxlLmMKPj4+Pj4+IEBAIC0zNTk5LDcgKzM1OTksNyBAQCBzdGF0aWMgaW50 IGYyZnNfaW9jX2lvX3ByaW8oc3RydWN0IGZpbGUgKmZpbHAsIHVuc2lnbmVkIGxvbmcgYXJnKQo+ Pj4+Pj4gICAgIGludCBmMmZzX3ByZWNhY2hlX2V4dGVudHMoc3RydWN0IGlub2RlICppbm9kZSkK Pj4+Pj4+ICAgICB7Cj4+Pj4+PiAgICAgCXN0cnVjdCBmMmZzX2lub2RlX2luZm8gKmZpID0gRjJG U19JKGlub2RlKTsKPj4+Pj4+IC0Jc3RydWN0IGYyZnNfbWFwX2Jsb2NrcyBtYXA7Cj4+Pj4+PiAr CXN0cnVjdCBmMmZzX21hcF9ibG9ja3MgbWFwID0geyAwIH07Cj4+Pj4+PiAgICAgCXBnb2ZmX3Qg bV9uZXh0X2V4dGVudDsKPj4+Pj4+ICAgICAJbG9mZl90IGVuZDsKPj4+Pj4+ICAgICAJaW50IGVy cjsKPj4+Pj4+IEBAIC0zNjE3LDYgKzM2MTcsOCBAQCBpbnQgZjJmc19wcmVjYWNoZV9leHRlbnRz KHN0cnVjdCBpbm9kZSAqaW5vZGUpCj4+Pj4+Pgo+Pj4+Pj4gICAgIAl3aGlsZSAobWFwLm1fbGJs ayA8IGVuZCkgewo+Pj4+Pj4gICAgIAkJbWFwLm1fbGVuID0gZW5kIC0gbWFwLm1fbGJsazsKPj4+ Pj4+ICsJCW1hcC5tX3BibGsgPSAwOwo+Pj4+Pj4gKwkJbWFwLm1fZmxhZ3MgPSAwOwo+Pj4+Pj4K Pj4+Pj4+ICAgICAJCWYyZnNfZG93bl93cml0ZSgmZmktPmlfZ2NfcndzZW1bV1JJVEVdKTsKPj4+ Pj4+ICAgICAJCWVyciA9IGYyZnNfbWFwX2Jsb2Nrcyhpbm9kZSwgJm1hcCwgRjJGU19HRVRfQkxP Q0tfUFJFQ0FDSEUpOwo+Pj4+Pj4gLS0gCj4+Pj4+PiAyLjQ5LjAKPj4+Pj4+Cj4+Pj4+PiBUaGFu a3MsCj4+Pj4+Pgo+Pj4+Pj4+ICAgICAJCQlnb3RvIHN5bmNfb3V0Owo+Pj4+Pj4+ICAgICAJCWNh c2UgRjJGU19HRVRfQkxPQ0tfQk1BUDoKPj4+Pj4+PiAgICAgCQkJbWFwLT5tX3BibGsgPSAwOwo+ Pj4+Pgo+Pj4+Pgo+Pj4+PiBXZSBoYXZlIGFscmVhZHkgcmVzZXQgbV9mbGFncyAobWFwLT5tX2Zs YWdzID0gMCkgaW4gZjJmc19tYXBfYmxvY2tzKCkuCj4+Pj4KPj4+PiBaaWppZToKPj4+Pgo+Pj4+ IE9vcHMsIHRoYXQncyByaWdodCwgdGhhbmtzIGZvciBjb3JyZWN0aW5nIG1lLgo+Pj4+Cj4+Pj4+ Cj4+Pj4+IEkgdGhpbmsgdGhhdCB0aGlzIGJ1ZyBpcyBjYXVzZWQgYnkgd2UgbWlzc2VkIHRvIHJl c2V0IG1fZmxhZ3Mgd2hlbiB3ZQo+Pj4+PiBnb3RvIG5leHRfZG5vZGUgaW4gYmVsb3cgY2FzZe+8 mgo+Pj4+Pgo+Pj4+PiBEYXRhIGxheW91dCBpcyBzb21ldGhpbmcgbGlrZSB0aGlzOgo+Pj4+PiBk bm9kZTE6ICAgICAgICAgICAgICAgICAgICAgZG5vZGUyOgo+Pj4+PiBbMF0gICAgICBBICAgICAg ICAgICAgICAgICAgWzBdICAgIE5FV19BRERSCj4+Pj4+IFsxXSAgICAgIEErMSAgICAgICAgICAg ICAgICBbMV0gICAgMHgwCj4+Pj4+IC4uLgo+Pj4+PiBbMTAxNl0gICBBKzEwMTYKPj4+Pj4gWzEw MTddICAgQiAoQiE9QSsxMDE3KSAgICAgIFsxMDE3XSAweDAKPj4+Pj4KPj4+Pj4gd2UgbWFwIHRo ZSBsYXN0IGJsb2NrKHZhbGlkIGJsa2FkZHIpIGluIGRub2RlMToKPj4+Pj4gbWFwLT5tX2ZsYWdz IHw9IEYyRlNfTUFQX01BUFBFRDsKPj4+Pj4gbWFwLT5tX3BibGsgPSBibGthZGRyKHZhbGlkIGJs a2FkZHIpOwo+Pj4+PiBtYXAtPm1fbGVuID0gMTsKPj4+Pj4gdGhlbiB3ZSBnb3RvIG5leHRfZG5v ZGUsIG1lZXQgdGhlIGZpcnN0IGJsb2NrIGluIGRub2RlMihob2xlKSwgZ290byBzeW5jX291dDoK Pj4+Pj4gbWFwLT5tX2ZsYWdzICYgRjJGU19NQVBfTUFQUEVEID09IHRydWUsIGFuZCB3ZSBtYWtl IHdyb25nIGJsa2FkZHIvbGVuIGZvciBleHRlbnRfaW5mby4KPj4+Pgo+Pj4+IFNvLCBjYW4geW91 IHBsZWFzZSBhZGQgYWJvdmUgZXhwbGFuYXRpb24gaW50byBjb21taXQgbWVzc2FnZT8gdGhhdAo+ Pj4+IHNob3VsZCBiZSBoZWxwZnVsIGZvciB1bmRlcnN0YW5kaW5nIHRoZSBwcm9ibGVtIG1vcmUg Y2xlYXJseS4KPj4+Pgo+Pj4+IFBsZWFzZSB0YWtlIGEgbG9vayBhdCB0aGlzIGNhc2Ugdy8geW91 ciBwYXRjaDoKPj4+Pgo+Pj4+IG1rZnMuZjJmcyAtTyBleHRyYV9hdHRyLGNvbXByZXNzaW9uIC9k ZXYvdmRiIC1mCj4+Pj4gbW91bnQgL2Rldi92ZGIgL21udC9mMmZzIC1vIG1vZGU9bGZzCj4+Pj4g Y2QgL21udC9mMmZzCj4+Pj4gZjJmc19pbyB3cml0ZSAxIDAgMTg4MyByYW5kIGRzeW5jIHRlc3Rm aWxlCj4+Pj4gZjJmc19pbyBmYWxsb2NhdGUgMCA3NzEyNzY4IDQwOTYgdGVzdGZpbGUKPj4+PiBm MmZzX2lvIHdyaXRlIDEgMTg4MSAxIHJhbmQgYnVmZmVyZWQgdGVzdGZpbGUKPj4+PiB4ZnNfaW8g dGVzdGZpbGUgLWMgImZzeW5jIgo+Pj4+IGNkIC8KPj4+PiB1bW91bnQgL21udC9mMmZzCj4+Pj4g bW91bnQgL2Rldi92ZGIgL21udC9mMmZzCj4+Pj4gZjJmc19pbyBwcmVjYWNoZV9leHRlbnRzIC9t bnQvZjJmcy90ZXN0ZmlsZQo+Pj4+IHVtb3VudCAvbW50L2YyZnMKPj4+Pgo+Pj4+ICAgICAgICAg ICAgZjJmc19pby03MzMgICAgIFswMTBdIC4uLi4uICAgIDc4LjEzNDEzNjogZjJmc191cGRhdGVf cmVhZF9leHRlbnRfdHJlZV9yYW5nZTogZGV2ID0gKDI1MywxNiksIGlubyA9IDQsIHBnb2ZzID0g MTg4MiwgbGVuID0gMCwgYmxrYWRkciA9IDE3NDEwLCBjX2xlbiA9IDAKPj4+Pgo+Pj4+IEkgc3Vz cGVjdCB3ZSBuZWVkIHRoaXM/Cj4+Pj4KPj4+PiBAQCAtMTc4NCw3ICsxNzgxLDggQEAgaW50IGYy ZnNfbWFwX2Jsb2NrcyhzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QgZjJmc19tYXBfYmxvY2tz ICptYXAsIGludCBmbGFnKQo+Pj4+ICAgICAgICAgICB9Cj4+Pj4KPj4+PiAgICAgICAgICAgaWYg KGZsYWcgPT0gRjJGU19HRVRfQkxPQ0tfUFJFQ0FDSEUpIHsKPj4+PiAtICAgICAgICAgICAgICAg aWYgKG1hcC0+bV9mbGFncyAmIEYyRlNfTUFQX01BUFBFRCkgewo+Pj4+ICsgICAgICAgICAgICAg ICBpZiAoKG1hcC0+bV9mbGFncyAmIEYyRlNfTUFQX01BUFBFRCkgJiYKPj4+PiArICAgICAgICAg ICAgICAgICAgICAgICAobWFwLT5tX2xlbiAtIG9mcykpIHsKPj4+PiAgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCBvZnMgPSBzdGFydF9wZ29mcyAtIG1hcC0+bV9sYmxrOwo+ Pj4+Cj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICBmMmZzX3VwZGF0ZV9yZWFkX2V4dGVu dF9jYWNoZV9yYW5nZSgmZG4sCj4+Pgo+Pj4gVGhhbmtzIGZvciBwb2ludGluZyBvdXQgdGhpcy4g TGV0IG1lIGZpbmQgYSB3YXkgdG8gY292ZXIgdGhlc2UgY2FzZXMgYW5kIGRvIG1vcmUgdGVzdC4K Pj4+Cj4+Pj4gQlRXLCBJIGZpbmQgYW5vdGhlciBidWcsIGlmIG9uZSBibGthZGRyIGlzIGFkamNl bnQgdG8gcHJldmlvdXMgZXh0ZW50LAo+Pj4+IGJ1dCBhbmQgaXQgaXMgdmFsaWQsIHdlIG5lZWQg dG8gc2V0IG1fbmV4dF9leHRlbnQgdG8gcGdvZnMgcmF0aGVyIHRoYW4KPj4+PiBwZ29mcyArIDEu Cj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZnMvZjJmcy9kYXRhLmMgYi9mcy9mMmZzL2RhdGEuYwo+ Pj4+IGluZGV4IGNiZjg4NDE2NDJjNy4uYWM4OGVkNjgwNTljIDEwMDY0NAo+Pj4+IC0tLSBhL2Zz L2YyZnMvZGF0YS5jCj4+Pj4gKysrIGIvZnMvZjJmcy9kYXRhLmMKPj4+PiBAQCAtMTc4OSw4ICsx Nzg5LDExIEBAIGludCBmMmZzX21hcF9ibG9ja3Moc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0 IGYyZnNfbWFwX2Jsb2NrcyAqbWFwLCBpbnQgZmxhZykKPj4+PiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RhcnRfcGdvZnMsIG1hcC0+bV9wYmxrICsgb2ZzLAo+Pj4+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYXAtPm1fbGVuIC0gb2ZzKTsKPj4+PiAgICAg ICAgICAgICAgICAgICB9Cj4+Pj4gLSAgICAgICAgICAgICAgIGlmIChtYXAtPm1fbmV4dF9leHRl bnQpCj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgKm1hcC0+bV9uZXh0X2V4dGVudCA9IHBn b2ZzICsgMTsKPj4+PiArICAgICAgICAgICAgICAgaWYgKG1hcC0+bV9uZXh0X2V4dGVudCkgewo+ Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICptYXAtPm1fbmV4dF9leHRlbnQgPSBwZ29mczsK Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICBpZiAoIV9faXNfdmFsaWRfZGF0YV9ibGthZGRy KGJsa2FkZHIpKQo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKm1hcC0+bV9u ZXh0X2V4dGVudCArPSAxOwo+Pj4+ICsgICAgICAgICAgICAgICB9Cj4+Pj4gICAgICAgICAgIH0K Pj4+PiAgICAgICAgICAgZjJmc19wdXRfZG5vZGUoJmRuKTsKPj4+Cj4+PiBNYXliZSBpdCBjYW4g YmUgdGhpcz8KPj4+IGlmIChtYXAtPm1fbmV4dF9leHRlbnQpCj4+PiAJKm1hcC0+bV9uZXh0X2V4 dGVudCA9IGlzX2hvbGUgPyBwZ29mcyArIDEgOiBwZ29mczsKPj4KPj4gSXQncyBiZXR0ZXIsIHdp bGwgdXBkYXRlLCB0aGFuayB5b3UuIDopCj4+Cj4+IFRoYW5rcywKPiAKPiBIaSBDaGFvLAo+IEkg dGVzdCBzb21lIGNhc2VzIHdpdGggdGhpcyBjaGFuZ2U6Cj4gCj4gZGlmZiAtLWdpdCBhL2ZzL2Yy ZnMvZGF0YS5jIGIvZnMvZjJmcy9kYXRhLmMKPiBpbmRleCA3OTYxZTBkZGYuLjcwOTNmZGM5NSAx MDA2NDQKPiAtLS0gYS9mcy9mMmZzL2RhdGEuYwo+ICsrKyBiL2ZzL2YyZnMvZGF0YS5jCj4gQEAg LTE3NzcsMTMgKzE3NzcsMTMgQEAgaW50IGYyZnNfbWFwX2Jsb2NrcyhzdHJ1Y3QgaW5vZGUgKmlu b2RlLCBzdHJ1Y3QgZjJmc19tYXBfYmxvY2tzICptYXAsIGludCBmbGFnKQo+ICAgICAgICAgIGlm IChmbGFnID09IEYyRlNfR0VUX0JMT0NLX1BSRUNBQ0hFKSB7Cj4gICAgICAgICAgICAgICAgICBp ZiAobWFwLT5tX2ZsYWdzICYgRjJGU19NQVBfTUFQUEVEKSB7Cj4gICAgICAgICAgICAgICAgICAg ICAgICAgIHVuc2lnbmVkIGludCBvZnMgPSBzdGFydF9wZ29mcyAtIG1hcC0+bV9sYmxrOwo+IC0K PiAtICAgICAgICAgICAgICAgICAgICAgICBmMmZzX3VwZGF0ZV9yZWFkX2V4dGVudF9jYWNoZV9y YW5nZSgmZG4sCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydF9wZ29mcywg bWFwLT5tX3BibGsgKyBvZnMsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtYXAt Pm1fbGVuIC0gb2ZzKTsKPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAobWFwLT5tX2xlbiAt IG9mcyA+IDApCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmMmZzX3VwZGF0ZV9y ZWFkX2V4dGVudF9jYWNoZV9yYW5nZSgmZG4sCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHN0YXJ0X3Bnb2ZzLCBtYXAtPm1fcGJsayArIG9mcywKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFwLT5tX2xlbiAtIG9mcyk7Cj4gICAgICAg ICAgICAgICAgICB9Cj4gICAgICAgICAgICAgICAgICBpZiAobWFwLT5tX25leHRfZXh0ZW50KQo+ IC0gICAgICAgICAgICAgICAgICAgICAgICptYXAtPm1fbmV4dF9leHRlbnQgPSBwZ29mcyArIDE7 Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgKm1hcC0+bV9uZXh0X2V4dGVudCA9IGlzX2hvbGUg PyBwZ29mcyArIDEgOiBwZ29mczsKPiAgICAgICAgICB9Cj4gICAgICAgICAgZjJmc19wdXRfZG5v ZGUoJmRuKTsKPiAgIHVubG9ja19vdXQ6Cj4gCj4gCj4gdGVzdCBjYXNlczoKPiAKPiBjYXNlMToK PiBkbm9kZTE6ICAgICAgICAgICAgICAgICAgICAgZG5vZGUyOgo+IFswXSAgICAgIEEgICAgICAg ICAgICAgICAgICBbMF0gICAgTkVXX0FERFIKPiBbMV0gICAgICBBKzEgICAgICAgICAgICAgICAg WzFdICAgIDB4MAo+IC4uLiAgICAgICAgICAgICAgICAgICAgICAgICAuLi4uCj4gWzEwMTZdICAg QSsxMDE2Cj4gWzEwMTddICAgQiAoQiE9QSsxMDE3KSAgICAgIFsxMDE3XSAweDAKPiAKPiBjYXNl MjoKPiBkbm9kZTE6ICAgICAgICAgICAgICAgICAgICAgZG5vZGUyOgo+IFswXSAgICAgIEEgICAg ICAgICAgICAgICAgICBbMF0gICAgQyAoQyE9QisxKQo+IFsxXSAgICAgIEErMSAgICAgICAgICAg ICAgICBbMV0gICAgQysxCj4gLi4uICAgICAgICAgICAgICAgICAgICAgICAgIC4uLi4KPiBbMTAx Nl0gICBBKzEwMTYKPiBbMTAxN10gICBCIChCIT1BKzEwMTcpICAgICAgWzEwMTddIDB4MAo+IAo+ IGNhc2UzOgo+IGRub2RlMTogICAgICAgICAgICAgICAgICAgICBkbm9kZTI6Cj4gWzBdICAgICAg QSAgICAgICAgICAgICAgICAgIFswXSAgICBDIChDIT1CKzIpCj4gWzFdICAgICAgQSsxICAgICAg ICAgICAgICAgIFsxXSAgICBDKzEKPiAuLi4gICAgICAgICAgICAgICAgICAgICAgICAgLi4uLgo+ IFsxMDE1XSAgIEErMTAxNQo+IFsxMDE2XSAgIEIgKEIhPUErMTAxNikKPiBbMTAxN10gICBCKzEg ICAgICAgICAgICAgICAgWzEwMTddIDB4MAo+IAo+IGNhc2U0Ogo+IG9uZSBibGthZGRyIGlzIGFk amNlbnQgdG8gcHJldmlvdXMgZXh0ZW50LCBhbmQgaXQgaXMgdmFsaWQuCiA+ID4gQW5kIGZyb20g dGhlIHJlc3VsdCwgaXQgc2VlbXMgdGhpcyBjaGFuZ2UgY2FuIGNvdmVyIHRoZXNlCj4gc2l0dWF0 aW9ucyBjb3JyZWN0bHkuCj4gRG8gd2UgbmVlZCBhIHBhdGNoIHdpdGggdGhpcyBjaGFuZ2U/Cgpa aWppZSwgdGhhbmtzIGZvciB0aGUgdGVzdC4KCklNTywgd2UnZCBiZXR0ZXIgdXNlIHRoZXNlIGNo YW5nZXM6CgotCi0gICAgICAgICAgICAgICAgICAgICAgIGYyZnNfdXBkYXRlX3JlYWRfZXh0ZW50 X2NhY2hlX3JhbmdlKCZkbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGFydF9w Z29mcywgbWFwLT5tX3BibGsgKyBvZnMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg bWFwLT5tX2xlbiAtIG9mcyk7CisgICAgICAgICAgICAgICAgICAgICAgIGlmIChtYXAtPm1fbGVu IC0gb2ZzID4gMCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmMmZzX3VwZGF0ZV9y ZWFkX2V4dGVudF9jYWNoZV9yYW5nZSgmZG4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzdGFydF9wZ29mcywgbWFwLT5tX3BibGsgKyBvZnMsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBtYXAtPm1fbGVuIC0gb2ZzKTsKCmluc3RlYWQgb2YK CiAgICAJCXN3aXRjaCAoZmxhZykgewogICAgCQljYXNlIEYyRlNfR0VUX0JMT0NLX1BSRUNBQ0hF OgorCQkJaWYgKF9faXNfdmFsaWRfZGF0YV9ibGthZGRyKG1hcC0+bV9wYmxrKSAmJgorCQkJCXN0 YXJ0X3Bnb2ZzIC0gbWFwLT5tX2xibGsgPT0gbWFwLT5tX2xlbikKKwkJCQltYXAtPm1fZmxhZ3Mg Jj0gfkYyRlNfTUFQX01BUFBFRDsKCkNhbiB5b3UgcGxlYXNlIHJlYmFzZSB5b3VyIHBhdGNoc2V0 IG9uIG1pbmUgYW5kIHNlbmQgdjI/CgpodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1mMmZz LWRldmVsLzIwMjUwOTEyMDgxMjUwLjQ0MzgzLTEtY2hhb0BrZXJuZWwub3JnCgpCVFcsIHBsZWFz ZSBhZGQgZml4ZXMgbGluZSBpbiB5b3VyIHBhdGNoLgoKVGhhbmtzLAoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRldmVsIG1haWxp bmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xp c3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 900732EBDDC for ; Fri, 12 Sep 2025 10:38:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757673536; cv=none; b=kngHm1npgwBIgKWlVtjOiKCGQ1Aww9Wu7chD7Ug/4MtqYkeKA5pIDygk5tEurC7qfoJHKBTz0rqFr5GGlRClU3PK2R1pn+Alfw2ZubUbjUWmBDQyQ5puIvt/QGsOMnTjd6CuiUAflK1VbssOXv/cPjKrYWFubP16cpKhAV+U5K8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757673536; c=relaxed/simple; bh=iPCFZZNGeEXP4VXVwEOl0dkNG1owk4NNFMYpbjH9kgI=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=nIG0Jbjf23rxnS4LHGgEh47d2EIaGQCWgB2F4f/C5jylTy0I77JnhrM3IU9+jqiLuiw5bU+KnQH5mlL7rQahKOApGAdyb7IOM/qimHjCpmZGiL3KBDcTrsCfkgojCYbNGd+PWtWeAU9/0hrf69iaCqWqlgOxLFg5DED+SusZOuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PLGckd0Z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PLGckd0Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC7CBC4CEFA; Fri, 12 Sep 2025 10:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757673536; bh=iPCFZZNGeEXP4VXVwEOl0dkNG1owk4NNFMYpbjH9kgI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=PLGckd0ZoLa+xWUPJPCbrNyz6t6ZLFWHFVE8ilK4gAJPx0557r6mT373s+3OsWxVT 7r33UTrmNbBLYCNfbEcWM48Lbx1GrI/K0V4mweZRSdpYZBZulS9mkSdUsMIQ5MjFDb v9JKc2KgBTW+RSPyR+bXpaGcAp10Ml0lUv7jENmPx4IObMVkrUIbq/c0JocNJN4n+W MsMT/nkYH4UE+9G2qI/cqf68M2V7oB01u4rnoPPU0FZBHIn8xQUno3ln+VY5Eb21ga 1JmcOlJoFRNuCD/p70lNwKs5zOurQXVuFhtKhsGdK6cH5ALNEKaKMbQkDWQK+ZaECj O3pEtE/EVA56Q== Message-ID: <6464ded0-b25e-4ce8-a05b-6caa394fbe63@kernel.org> Date: Fri, 12 Sep 2025 18:38:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, feng.han@honor.com, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: fix wrong extent_info data for precache extents To: wangzijie References: <2ecb4f74-cc60-4dd4-8dc3-d4f3ff848e87@kernel.org> <20250912100650.3594565-1-wangzijie1@honor.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20250912100650.3594565-1-wangzijie1@honor.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/12/2025 6:06 PM, wangzijie wrote: >> On 9/12/2025 11:36 AM, wangzijie wrote: >>>> On 9/11/2025 5:07 PM, wangzijie wrote: >>>>>> On 9/10/25 21:58, wangzijie wrote: >>>>>>> When the data layout is like this: >>>>>>> dnode1: dnode2: >>>>>>> [0] A [0] NEW_ADDR >>>>>>> [1] A+1 [1] 0x0 >>>>>>> ... .... >>>>>>> [1016] A+1016 >>>>>>> [1017] B (B!=A+1017) [1017] 0x0 >>>>>>> >>>>>>> We can build this kind of layout by following steps(with i_extra_isize:36): >>>>>>> ./f2fs_io write 1 0 1881 rand dsync testfile >>>>>>> ./f2fs_io write 1 1881 1 rand buffered testfile >>>>>>> ./f2fs_io fallocate 0 7708672 4096 testfile >>>>>>> >>>>>>> And when we map first data block in dnode2, we will get wrong extent_info data: >>>>>>> map->m_len = 1 >>>>>>> ofs = start_pgofs - map->m_lblk = 1882 - 1881 = 1 >>>>>>> >>>>>>> ei.fofs = start_pgofs = 1882 >>>>>>> ei.len = map->m_len - ofs = 1 - 1 = 0 >>>>>>> >>>>>>> Fix it by skipping updating this kind of extent info. >>>>>>> >>>>>>> Signed-off-by: wangzijie >>>>>>> --- >>>>>>> fs/f2fs/data.c | 3 +++ >>>>>>> 1 file changed, 3 insertions(+) >>>>>>> >>>>>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>>>>> index 7961e0ddf..b8bb71852 100644 >>>>>>> --- a/fs/f2fs/data.c >>>>>>> +++ b/fs/f2fs/data.c >>>>>>> @@ -1649,6 +1649,9 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >>>>>>> >>>>>>> switch (flag) { >>>>>>> case F2FS_GET_BLOCK_PRECACHE: >>>>>>> + if (__is_valid_data_blkaddr(map->m_pblk) && >>>>>>> + start_pgofs - map->m_lblk == map->m_len) >>>>>>> + map->m_flags &= ~F2FS_MAP_MAPPED; >>>>>> >>>>>> It looks we missed to reset value for map variable in f2fs_precache_extents(), >>>>>> what do you think of this? >>>>>> >>>>>> --- >>>>>> fs/f2fs/file.c | 4 +++- >>>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >>>>>> index 1aae4361d0a8..2b14151d4130 100644 >>>>>> --- a/fs/f2fs/file.c >>>>>> +++ b/fs/f2fs/file.c >>>>>> @@ -3599,7 +3599,7 @@ static int f2fs_ioc_io_prio(struct file *filp, unsigned long arg) >>>>>> int f2fs_precache_extents(struct inode *inode) >>>>>> { >>>>>> struct f2fs_inode_info *fi = F2FS_I(inode); >>>>>> - struct f2fs_map_blocks map; >>>>>> + struct f2fs_map_blocks map = { 0 }; >>>>>> pgoff_t m_next_extent; >>>>>> loff_t end; >>>>>> int err; >>>>>> @@ -3617,6 +3617,8 @@ int f2fs_precache_extents(struct inode *inode) >>>>>> >>>>>> while (map.m_lblk < end) { >>>>>> map.m_len = end - map.m_lblk; >>>>>> + map.m_pblk = 0; >>>>>> + map.m_flags = 0; >>>>>> >>>>>> f2fs_down_write(&fi->i_gc_rwsem[WRITE]); >>>>>> err = f2fs_map_blocks(inode, &map, F2FS_GET_BLOCK_PRECACHE); >>>>>> -- >>>>>> 2.49.0 >>>>>> >>>>>> Thanks, >>>>>> >>>>>>> goto sync_out; >>>>>>> case F2FS_GET_BLOCK_BMAP: >>>>>>> map->m_pblk = 0; >>>>> >>>>> >>>>> We have already reset m_flags (map->m_flags = 0) in f2fs_map_blocks(). >>>> >>>> Zijie: >>>> >>>> Oops, that's right, thanks for correcting me. >>>> >>>>> >>>>> I think that this bug is caused by we missed to reset m_flags when we >>>>> goto next_dnode in below caseļ¼š >>>>> >>>>> Data layout is something like this: >>>>> dnode1: dnode2: >>>>> [0] A [0] NEW_ADDR >>>>> [1] A+1 [1] 0x0 >>>>> ... >>>>> [1016] A+1016 >>>>> [1017] B (B!=A+1017) [1017] 0x0 >>>>> >>>>> we map the last block(valid blkaddr) in dnode1: >>>>> map->m_flags |= F2FS_MAP_MAPPED; >>>>> map->m_pblk = blkaddr(valid blkaddr); >>>>> map->m_len = 1; >>>>> then we goto next_dnode, meet the first block in dnode2(hole), goto sync_out: >>>>> map->m_flags & F2FS_MAP_MAPPED == true, and we make wrong blkaddr/len for extent_info. >>>> >>>> So, can you please add above explanation into commit message? that >>>> should be helpful for understanding the problem more clearly. >>>> >>>> Please take a look at this case w/ your patch: >>>> >>>> mkfs.f2fs -O extra_attr,compression /dev/vdb -f >>>> mount /dev/vdb /mnt/f2fs -o mode=lfs >>>> cd /mnt/f2fs >>>> f2fs_io write 1 0 1883 rand dsync testfile >>>> f2fs_io fallocate 0 7712768 4096 testfile >>>> f2fs_io write 1 1881 1 rand buffered testfile >>>> xfs_io testfile -c "fsync" >>>> cd / >>>> umount /mnt/f2fs >>>> mount /dev/vdb /mnt/f2fs >>>> f2fs_io precache_extents /mnt/f2fs/testfile >>>> umount /mnt/f2fs >>>> >>>> f2fs_io-733 [010] ..... 78.134136: f2fs_update_read_extent_tree_range: dev = (253,16), ino = 4, pgofs = 1882, len = 0, blkaddr = 17410, c_len = 0 >>>> >>>> I suspect we need this? >>>> >>>> @@ -1784,7 +1781,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >>>> } >>>> >>>> if (flag == F2FS_GET_BLOCK_PRECACHE) { >>>> - if (map->m_flags & F2FS_MAP_MAPPED) { >>>> + if ((map->m_flags & F2FS_MAP_MAPPED) && >>>> + (map->m_len - ofs)) { >>>> unsigned int ofs = start_pgofs - map->m_lblk; >>>> >>>> f2fs_update_read_extent_cache_range(&dn, >>> >>> Thanks for pointing out this. Let me find a way to cover these cases and do more test. >>> >>>> BTW, I find another bug, if one blkaddr is adjcent to previous extent, >>>> but and it is valid, we need to set m_next_extent to pgofs rather than >>>> pgofs + 1. >>>> >>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>>> index cbf8841642c7..ac88ed68059c 100644 >>>> --- a/fs/f2fs/data.c >>>> +++ b/fs/f2fs/data.c >>>> @@ -1789,8 +1789,11 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) >>>> start_pgofs, map->m_pblk + ofs, >>>> map->m_len - ofs); >>>> } >>>> - if (map->m_next_extent) >>>> - *map->m_next_extent = pgofs + 1; >>>> + if (map->m_next_extent) { >>>> + *map->m_next_extent = pgofs; >>>> + if (!__is_valid_data_blkaddr(blkaddr)) >>>> + *map->m_next_extent += 1; >>>> + } >>>> } >>>> f2fs_put_dnode(&dn); >>> >>> Maybe it can be this? >>> if (map->m_next_extent) >>> *map->m_next_extent = is_hole ? pgofs + 1 : pgofs; >> >> It's better, will update, thank you. :) >> >> Thanks, > > Hi Chao, > I test some cases with this change: > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 7961e0ddf..7093fdc95 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1777,13 +1777,13 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) > if (flag == F2FS_GET_BLOCK_PRECACHE) { > if (map->m_flags & F2FS_MAP_MAPPED) { > unsigned int ofs = start_pgofs - map->m_lblk; > - > - f2fs_update_read_extent_cache_range(&dn, > - start_pgofs, map->m_pblk + ofs, > - map->m_len - ofs); > + if (map->m_len - ofs > 0) > + f2fs_update_read_extent_cache_range(&dn, > + start_pgofs, map->m_pblk + ofs, > + map->m_len - ofs); > } > if (map->m_next_extent) > - *map->m_next_extent = pgofs + 1; > + *map->m_next_extent = is_hole ? pgofs + 1 : pgofs; > } > f2fs_put_dnode(&dn); > unlock_out: > > > test cases: > > case1: > dnode1: dnode2: > [0] A [0] NEW_ADDR > [1] A+1 [1] 0x0 > ... .... > [1016] A+1016 > [1017] B (B!=A+1017) [1017] 0x0 > > case2: > dnode1: dnode2: > [0] A [0] C (C!=B+1) > [1] A+1 [1] C+1 > ... .... > [1016] A+1016 > [1017] B (B!=A+1017) [1017] 0x0 > > case3: > dnode1: dnode2: > [0] A [0] C (C!=B+2) > [1] A+1 [1] C+1 > ... .... > [1015] A+1015 > [1016] B (B!=A+1016) > [1017] B+1 [1017] 0x0 > > case4: > one blkaddr is adjcent to previous extent, and it is valid. > > And from the result, it seems this change can cover these > situations correctly. > Do we need a patch with this change? Zijie, thanks for the test. IMO, we'd better use these changes: - - f2fs_update_read_extent_cache_range(&dn, - start_pgofs, map->m_pblk + ofs, - map->m_len - ofs); + if (map->m_len - ofs > 0) + f2fs_update_read_extent_cache_range(&dn, + start_pgofs, map->m_pblk + ofs, + map->m_len - ofs); instead of switch (flag) { case F2FS_GET_BLOCK_PRECACHE: + if (__is_valid_data_blkaddr(map->m_pblk) && + start_pgofs - map->m_lblk == map->m_len) + map->m_flags &= ~F2FS_MAP_MAPPED; Can you please rebase your patchset on mine and send v2? https://lore.kernel.org/linux-f2fs-devel/20250912081250.44383-1-chao@kernel.org BTW, please add fixes line in your patch. Thanks,