All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Tom Rini <trini@konsulko.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Casey Connolly" <casey.connolly@linaro.org>,
	"Christian Marangi" <ansuelsmth@gmail.com>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Jerome Forissier" <jerome.forissier@linaro.org>,
	"Joe Hershberger" <joe.hershberger@ni.com>,
	"Marek Vasut" <marex@denx.de>,
	"Mattijs Korpershoek" <mkorpershoek@kernel.org>,
	"Michael Walle" <mwalle@kernel.org>,
	"Michal Simek" <michal.simek@amd.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Quentin Schulz" <quentin.schulz@cherry.de>,
	"Rasmus Villemoes" <ravi@prevas.dk>,
	"Simon Glass" <sjg@chromium.org>,
	"Varadarajan Narayanan" <quic_varada@quicinc.com>,
	"Vincent Stehlé" <vincent.stehle@arm.com>,
	"Weijie Gao" <weijie.gao@mediatek.com>
Subject: RE: [PATCH V5 0/4] cmd: env: select: Add output for available environment targets
Date: Tue, 19 Aug 2025 09:05:30 +0000	[thread overview]
Message-ID: <64672dd94de34a8386bdebe23a250987@dh-electronics.com> (raw)
In-Reply-To: <20250731160535.GB1807455@bill-the-cat>

From: Tom Rini <trini@konsulko.com>
Sent: Thursday, July 31, 2025 6:06 PM
> On Thu, Jul 31, 2025 at 09:58:27AM +0000, Christoph Niedermaier wrote:
>> From: Tom Rini <trini@konsulko.com>
>> Sent: Monday, July 28, 2025 9:03 PM
>>> On Fri, Jul 18, 2025 at 07:05:58PM +0200, Christoph Niedermaier wrote:
>>>
>>>> Add the "-l" parameter to the "env select" command to print the available
>>>> environment targets, convert all argument parsing in the file nvedit.c to
>>>> getopt() and check that with unit tests.
>>>>
>>>> The first patch converts the parsing of arguments to getopt() for all env
>>>> commands. The second one avoids stopping unit test on console output
>>>> "## Error: ". The third one adds unit tests for checking the env command.
>>>> These were used to check the env commands before and after the conversion.
>>>> The fourth patch adds the actual new parameter "-l" for the "env select"
>>>> command.
>>>>
>>>> Christoph Niedermaier (3):
>>>>   cmd: nvedit: Convert the parsing of arguments to getopt()
>>>>   test/py: Avoid stopping the test on console output "## Error: "
>>>>   test: cmd: nvedit: Add basic unit tests
>>>>   cmd: env: select: Add output for available environment targets
>>>
>>> I'm sorry, but it seems like a lot of the tests fail in CI?
>>> https://source.denx.de/u-boot/u-boot/-/jobs/1209804
>>> https://source.denx.de/u-boot/u-boot/-/jobs/1209794
>>> For example.
>>
>> I think I fixed my test, but broke other tests in the process.
>> I'm very sorry. I will try to fix the problem, but it is difficult
>> to reproduce the entire CI locally. I will try my best, sorry again.
> 
> You can trigger CI runs too via GitHub / Azure, BTW:
> https://docs.u-boot.org/en/latest/develop/ci_testing.html

Thanks for your support. I'll take a look at it, but sorry,
I can't get to it right now.


Thanks and regards
Christoph

      reply	other threads:[~2025-08-19  9:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-18 17:05 [PATCH V5 0/4] cmd: env: select: Add output for available environment targets Christoph Niedermaier
2025-07-18 17:05 ` [PATCH V5 1/4] cmd: nvedit: Convert the parsing of arguments to getopt() Christoph Niedermaier
2025-07-18 17:06 ` [PATCH V5 2/4] test/py: Avoid stopping the test on console output "## Error: " Christoph Niedermaier
2025-07-18 17:06 ` [PATCH V5 3/4] test: cmd: nvedit: Add basic unit tests Christoph Niedermaier
2025-07-18 17:06 ` [PATCH V5 4/4] cmd: env: select: Add output for available environment targets Christoph Niedermaier
2025-07-28 19:03 ` [PATCH V5 0/4] " Tom Rini
2025-07-31  9:58   ` Christoph Niedermaier
2025-07-31 16:05     ` Tom Rini
2025-08-19  9:05       ` Christoph Niedermaier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64672dd94de34a8386bdebe23a250987@dh-electronics.com \
    --to=cniedermaier@dh-electronics.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ansuelsmth@gmail.com \
    --cc=casey.connolly@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jerome.forissier@linaro.org \
    --cc=joe.hershberger@ni.com \
    --cc=marex@denx.de \
    --cc=michal.simek@amd.com \
    --cc=mkorpershoek@kernel.org \
    --cc=mwalle@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=quentin.schulz@cherry.de \
    --cc=quic_varada@quicinc.com \
    --cc=ravi@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vincent.stehle@arm.com \
    --cc=weijie.gao@mediatek.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.