From: John Fastabend <john.fastabend@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>,
jakub@cloudflare.com, daniel@iogearbox.net
Cc: john.fastabend@gmail.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, edumazet@google.com, ast@kernel.org,
andrii@kernel.org, will@isovalent.com
Subject: RE: [PATCH bpf v9 00/14] bpf sockmap fixes
Date: Mon, 22 May 2023 18:19:33 -0700 [thread overview]
Message-ID: <646c14a5bd4f8_260e20865@john.notmuch> (raw)
In-Reply-To: <20230519040659.670644-1-john.fastabend@gmail.com>
John Fastabend wrote:
> v9, rebased which resulted in two additions needed. Patch 14
> to resolve an introduced verifier error. I'll try to dig into
> exactly what happened but the fix was easy to get test_sockmap
> running again. And then in vsock needed similar fix to the
> the protocols so I folded that into the first patch.
[...]
Guess we need yet another build CI seems to be upset building
this.
2023-05-22T17:37:37.7500703Z In file included from /tmp/work/bpf/bpf/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:17:
2023-05-22T17:37:37.7501506Z /tmp/work/bpf/bpf/tools/testing/selftests/bpf/prog_tests/sockmap_helpers.h:240:18: error: use of undeclared identifier 'VMADDR_CID_LOCAL'
2023-05-22T17:37:37.7501950Z addr->svm_cid = VMADDR_CID_LOCAL;
2023-05-22T17:37:37.7503213Z
Interestingly clang version (latest) here is fine with it. Anyways
will fix we should put define near where its used. :/
Thanks,
John
next prev parent reply other threads:[~2023-05-23 1:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 4:06 [PATCH bpf v9 00/14] bpf sockmap fixes John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 01/14] bpf: sockmap, pass skb ownership through read_skb John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 02/14] bpf: sockmap, convert schedule_work into delayed_work John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 03/14] bpf: sockmap, reschedule is now done through backlog John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 04/14] bpf: sockmap, improved check for empty queue John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 05/14] bpf: sockmap, handle fin correctly John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 06/14] bpf: sockmap, TCP data stall on recv before accept John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 07/14] bpf: sockmap, wake up polling after data copy John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 08/14] bpf: sockmap, incorrectly handling copied_seq John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 09/14] bpf: sockmap, pull socket helpers out of listen test for general use John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 10/14] bpf: sockmap, build helper to create connected socket pair John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 11/14] bpf: sockmap, test shutdown() correctly exits epoll and recv()=0 John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 12/14] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 13/14] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer with drops John Fastabend
2023-05-19 4:06 ` [PATCH bpf v9 14/14] bpf: sockmap, test progs verifier error with latest clang John Fastabend
2023-05-23 1:19 ` John Fastabend [this message]
2023-05-23 1:22 ` [PATCH bpf v9 00/14] bpf sockmap fixes John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646c14a5bd4f8_260e20865@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=will@isovalent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.