All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau	 <martin.lau@linux.dev>,
	Kernel Team <kernel-team@fb.com>,
	Yonghong Song	 <yonghong.song@linux.dev>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>
Subject: Re: [PATCH bpf-next v1 2/3] bpf: allow void* cast using bpf_rdonly_cast()
Date: Tue, 24 Jun 2025 17:24:13 -0700	[thread overview]
Message-ID: <64802dbb21f9e5c8834be3725cda68db9c6a1963.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQ+1h49trJcsobzPN=YnnbsaidJi98vMeGeBKpxh-nV2Hw@mail.gmail.com>

On Tue, 2025-06-24 at 17:21 -0700, Alexei Starovoitov wrote:

[...]

> I mean to add " = 123," to actual features, so when they're
> backported the number stays the same.
> Not to __MAX_BPF_FEAT.
> 
> I doubt it matters though,
> since bpf progs suppose to use
> bpf_core_enum_value_exists(enum bpf_features, name)
> that doesn't care about the actual id.
> 
> In bpf helpers we got burned by broken backports and added
> constants to ___BPF_FUNC_MAPPER macro.
> Here I don't see it ever matter.
> Just like I don't think __MAX_BPF_FEAT is needed,
> but if we follow old steps, then let's do both __MAX_BPF_FEAT
> without number and every feature with the number.
> The end result will look like bpf_link_type.

Understood, thank you, will respin.

  reply	other threads:[~2025-06-25  0:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25  0:05 [PATCH bpf-next v1 0/3] bpf: allow void* cast using bpf_rdonly_cast() Eduard Zingerman
2025-06-25  0:05 ` [PATCH bpf-next v1 1/3] bpf: add bpf_features enum Eduard Zingerman
2025-06-25  0:05 ` [PATCH bpf-next v1 2/3] bpf: allow void* cast using bpf_rdonly_cast() Eduard Zingerman
2025-06-25  0:11   ` Alexei Starovoitov
2025-06-25  0:15     ` Eduard Zingerman
2025-06-25  0:21       ` Alexei Starovoitov
2025-06-25  0:24         ` Eduard Zingerman [this message]
2025-06-25  0:05 ` [PATCH bpf-next v1 3/3] selftests/bpf: check operations on untrusted ro pointers to mem Eduard Zingerman
2025-06-25  0:07 ` [PATCH bpf-next v1 0/3] bpf: allow void* cast using bpf_rdonly_cast() Eduard Zingerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64802dbb21f9e5c8834be3725cda68db9c6a1963.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=martin.lau@linux.dev \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.