RE: Code handling for VOCS service

[bluez.test.bot@gmail.com]

[-- Attachment #1: Type: text/plain, Size: 3713 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=754867

---Test result---

Test Summary:
CheckPatch                    FAIL      1.74 seconds
GitLint                       PASS      0.72 seconds
BuildEll                      PASS      27.11 seconds
BluezMake                     PASS      863.57 seconds
MakeCheck                     PASS      12.34 seconds
MakeDistcheck                 PASS      154.02 seconds
CheckValgrind                 PASS      255.60 seconds
CheckSmatch                   PASS      340.33 seconds
bluezmakeextell               PASS      102.67 seconds
IncrementalBuild              PASS      1417.56 seconds
ScanBuild                     WARNING   1055.29 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2,1/2] Added initial code for handling VOCS
WARNING:LONG_LINE: line length of 93 exceeds 80 columns
#596: FILE: src/shared/vcp.c:1268:
+				uint16_t value_handle, const uint8_t *value, uint16_t length,

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#614: FILE: src/shared/vcp.c:1340:
+				uint8_t att_ecode, const uint8_t *value, uint16_t length,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#624: FILE: src/shared/vcp.c:1350:
+		DBG(vcp, "Unable to read Vol Offset State: error 0x%02x", att_ecode);

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#639: FILE: src/shared/vcp.c:1365:
+				uint8_t att_ecode, const uint8_t *value, uint16_t length,

WARNING:LONG_LINE: line length of 88 exceeds 80 columns
#649: FILE: src/shared/vcp.c:1375:
+		DBG(vcp, "Unable to read VOCS Audio Location: error 0x%02x", att_ecode);

WARNING:LONG_LINE: line length of 89 exceeds 80 columns
#664: FILE: src/shared/vcp.c:1390:
+				uint8_t att_ecode, const uint8_t *value, uint16_t length,

WARNING:LONG_LINE: line length of 85 exceeds 80 columns
#724: FILE: src/shared/vcp.c:1599:
+						     vcp_voffset_state_notify, NULL);

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#739: FILE: src/shared/vcp.c:1614:
+		vcp_read_value(vcp, value_handle, read_vocs_audio_location, vcp);

WARNING:LONG_LINE: line length of 81 exceeds 80 columns
#742: FILE: src/shared/vcp.c:1617:
+						     vcp_audio_loc_notify, NULL);

WARNING:LONG_LINE: line length of 83 exceeds 80 columns
#769: FILE: src/shared/vcp.c:1644:
+		vcp_read_value(vcp, value_handle, read_vocs_audio_descriptor, vcp);

WARNING:LONG_LINE: line length of 87 exceeds 80 columns
#771: FILE: src/shared/vcp.c:1646:
+						    vcp_audio_descriptor_notify, NULL);

/github/workspace/src/src/13270609.patch total: 0 errors, 11 warnings, 676 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13270609.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:
src/shared/vcp.c:1272:2: warning: Null pointer passed to 1st parameter expecting 'nonnull'
        memcpy(vocs_audio_loc_n, value, sizeof(uint32_t));
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.



---
Regards,
Linux Bluetooth