All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Vallejo <alejandro.vallejo@cloud.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>
Subject: Re: [PATCH v2 0/5] Prevent attempting updates known to fail
Date: Thu, 15 Jun 2023 16:56:39 +0100	[thread overview]
Message-ID: <648b34ba.050a0220.770ef.1a02@mx.google.com> (raw)
In-Reply-To: <20230615154834.959-1-alejandro.vallejo@cloud.com>

On Thu, Jun 15, 2023 at 04:48:29PM +0100, Alejandro Vallejo wrote:
> v3:
>   * Lots of hunks moved around. Individually mentioned in each patch
>   * Removed a redundant check
>   * Ignore microcode interface if the revision is -1
>   * Perform the DIS_MCU_LOAD checks during init rather than apply time

You might think that looks a whole lot like the enumeration in v2, and
you'd be right :) . I sent this ahead of time and that's incorrect. The
actual summary is:

  * Lots of hunks moved around. Individually mentioned in each patch
  * MSR_ARCH_CAPS read in early_cpu_init()
  * Per-vendor functions used to encapsulate vendor-specific logic in
    early_microcode_init()
  * Inlined previous helper for realoading 7d0

It addresses most concerns raised, but the final look is a bit different
from what was reviewed before. I think it's a lot cleaner and allows future
per-vendor logic to be neatly integrated into their per-vendor files.

Alejandro


      parent reply	other threads:[~2023-06-15 15:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 15:48 [PATCH v2 0/5] Prevent attempting updates known to fail Alejandro Vallejo
2023-06-15 15:48 ` [PATCH v3 1/5] x86/microcode: Allow reading microcode revision even if it can't be updated Alejandro Vallejo
2023-06-19 15:37   ` Jan Beulich
2023-06-19 15:49   ` Andrew Cooper
2023-06-19 15:58     ` Jan Beulich
2023-06-19 16:06       ` Andrew Cooper
2023-06-19 16:10         ` Jan Beulich
2023-06-20  9:53           ` Jan Beulich
2023-06-15 15:48 ` [PATCH v3 2/5] x86/microcode: Create per-vendor microcode_ops builders Alejandro Vallejo
2023-06-19 15:45   ` Jan Beulich
2023-06-22 14:34     ` Alejandro Vallejo
2023-06-15 15:48 ` [PATCH v3 3/5] x86/microcode: Ignore microcode loading interface for revision = -1 Alejandro Vallejo
2023-06-19 15:47   ` Jan Beulich
2023-06-15 15:48 ` [PATCH v3 4/5] x86: Read MSR_ARCH_CAPS immediately after early_microcode_init() Alejandro Vallejo
2023-06-19 15:57   ` Jan Beulich
2023-06-22 14:55     ` Alejandro Vallejo
2023-06-22 15:20       ` Jan Beulich
2023-06-15 15:48 ` [PATCH v3 5/5] x86/microcode: Disable microcode update handler if DIS_MCU_UPDATE is set Alejandro Vallejo
2023-06-20  9:51   ` Jan Beulich
2023-06-22 15:05     ` Alejandro Vallejo
2023-06-15 15:56 ` Alejandro Vallejo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=648b34ba.050a0220.770ef.1a02@mx.google.com \
    --to=alejandro.vallejo@cloud.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.