From: alexander.kanavin@linux.intel.com
To: "Paul Eggleton" <paul.eggleton@linux.intel.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev
Date: Tue, 22 Mar 2016 18:25:25 +0200 (EET) [thread overview]
Message-ID: <64951.10.252.26.251.1458663925.squirrel@linux.intel.com> (raw)
In-Reply-To: <1817823.GWXx3ahntL@peggleto-mobl.ger.corp.intel.com>
>> > So you can remove distro_features_check inherit as well, right?
>>
>> Yeah, I guess. Feel free to amend.
>
> The reviewer is asking you to do that, although perhaps not in so many
> words.
> Can you, please?
I don't believe I should, if the review consists of a single trivial
nitpick from the person who also does the actual commits to master. It's
less friction and noise for both of us this way.
Alex
next prev parent reply other threads:[~2016-03-22 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 13:54 [PATCH 1/2] gnome-bluetooth: inherit gobject-introspection class Alexander Kanavin
2016-03-21 13:54 ` [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev Alexander Kanavin
2016-03-21 14:50 ` Martin Jansa
2016-03-21 14:45 ` Alexander Kanavin
2016-03-21 20:43 ` Paul Eggleton
2016-03-21 20:54 ` Martin Jansa
2016-03-22 16:25 ` alexander.kanavin [this message]
2016-03-22 19:58 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64951.10.252.26.251.1458663925.squirrel@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.