From: Jeffrey A Law <law@upchuck.cygnus.com>
To: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
Cc: egcs-patches@egcs.cygnus.com, rth@cygnus.com,
meissner@cygnus.com, David Edelsohn <dje@watson.ibm.com>,
linuxppc-dev@lists.linuxppc.org
Subject: Re: PATCH: Fix 2 PPC/SYSV varargs problems
Date: Wed, 12 May 1999 00:19:53 -0600 [thread overview]
Message-ID: <6498.926489993@upchuck.cygnus.com> (raw)
In-Reply-To: Your message of Fri, 30 Apr 1999 02:09:09 +0200. <4.2.0.37.19990430013458.0489a950@mail.lauterbach.com>
In message <4.2.0.37.19990430013458.0489a950@mail.lauterbach.com>you write:
> --=====================_53744284==_
> Content-Type: text/plain; charset="us-ascii"; format=flowed
>
> Hi,
>
> this patch is supposed to fix the following problems on PPC/SYSV:
>
> 1. the varargs save area calculation bug, this is a hack and Richard ;-)
> probably won't like it, but maybe it's good enough for egcs-1.2
>
> 2. if you call a function that uses more then 8 float args before all
> integer argument passing registers are consumed, egcs will missetup the
> calling sequence. I introduced a new variable cum->sysv_fwords in the
> CUMULATIVE_ARGS struct, which counts the saved float words and adjusted
> cum->words where needed (I hope). There maybe better/nicer ways to
> implement that, so tell me if you want a different solution. A testcase is
> attached, the original problem happens with gnuplot.
Has this problem been fixed? I see patch from Richard which looks like it
is related:
* va-ppc.h (__va_start_common): Let __builtin_saveregs do the work.
* rs6000.c (expand_builtin_saveregs): For V4, initialize a private
va_list struct, and return a pointer to it.
(setup_incoming_varargs): V4 save area based off virtual_stack_vars
instead of frame_pointer.
[ yes, I'm going through my backlog now trying to weed out issues that I
don't need to deal with :-) ]
jeff
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting. ]]
next prev parent reply other threads:[~1999-05-12 6:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-30 0:09 PATCH: Fix 2 PPC/SYSV varargs problems Franz Sirl
1999-04-30 2:48 ` Richard Henderson
1999-04-30 2:55 ` Zack Weinberg
1999-04-30 3:02 ` Richard Henderson
1999-04-30 3:08 ` David Edelsohn
1999-04-30 4:49 ` Gary Thomas
1999-04-30 13:42 ` Franz Sirl
1999-04-30 22:08 ` Richard Henderson
1999-05-03 12:44 ` Franz Sirl
1999-05-12 6:19 ` Jeffrey A Law [this message]
1999-05-12 6:48 ` Richard Henderson
1999-05-12 10:21 ` Franz Sirl
1999-05-12 15:24 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6498.926489993@upchuck.cygnus.com \
--to=law@upchuck.cygnus.com \
--cc=Franz.Sirl-kernel@lauterbach.com \
--cc=dje@watson.ibm.com \
--cc=egcs-patches@egcs.cygnus.com \
--cc=law@cygnus.com \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=meissner@cygnus.com \
--cc=rth@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.