From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32187C6FD1C for ; Thu, 9 Mar 2023 13:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u5pbST9nnHh59W/BtdCJGnrDYbD+UQz3yi4IqwO8Ey0=; b=CFn/GdYNDbE/B58aQnLxwSlxm1 pQGtKiIy4RwWTME3defv3R9oqwPCRkEhJgmEdSsJpXVHmNzxRuGeSia9/pxFXZ7OPWKRQh1zwFAv6 M8GuM7vzE6bBtS7nB//KcK68ghM3Ht7FxBdSI2Il4knocmjKPzCNeVHA3prrQ5HsBKA1d8cShPES/ YHPuzkUolRCEHtxjcJ3nAyDMNsdGBXF58QcoWAyoWOh8h82I4ZlGgivNaQQethYdMl3wWEK39sBsl THZGeBP6z253EC7IyTQisUEqMWpEYcJ6+COv0NsDKF9w1A8vmRzU34Kowz++MqoVa7Cyhai89l7Y7 NF/Jrxbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paGNN-00A7wX-GA; Thu, 09 Mar 2023 13:32:09 +0000 Received: from 10.mo576.mail-out.ovh.net ([46.105.73.241]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paGMj-00A7a9-If for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 13:31:32 +0000 Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.146.32]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 7995826C37 for ; Thu, 9 Mar 2023 13:31:23 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-74llp (unknown [10.110.208.116]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 8CDCA1FE67; Thu, 9 Mar 2023 13:31:21 +0000 (UTC) Received: from RCM-web10.webmail.mail.ovh.net ([151.80.29.18]) by ghost-submission-6684bf9d7b-74llp with ESMTPSA id 3hbMIKnfCWTjaAUA/ww3gA (envelope-from ); Thu, 09 Mar 2023 13:31:21 +0000 MIME-Version: 1.0 Date: Thu, 09 Mar 2023 14:31:19 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Miquel Raynal Cc: Srinivas Kandagatla , =?UTF-8?Q?Rafa?= =?UTF-8?Q?=C5=82_Mi=C5=82ecki?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer In-Reply-To: <20230309141038.4399af1f@xps-13> References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> <20230309141038.4399af1f@xps-13> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <649e1c9196cf78232816dcf29ece4c52@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl X-Ovh-Tracer-Id: 16116975693792521129 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedghedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeejvdelgfeutdfhfeelheegfedtleduleeuvdfgfeefvefhvedtheetjeetfeehgeenucfkphepuddvjedrtddrtddruddpudelgedrudekjedrjeegrddvfeefpdduhedurdektddrvdelrddukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehjeeipdhmohguvgepshhmthhpohhuth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_053129_963029_E5BEA1E0 X-CRM114-Status: GOOD ( 40.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMy0wMy0wOSAxNDoxMCwgTWlxdWVsIFJheW5hbCB3cm90ZToKPiBIZWxsbywKPiAKPiBy YWZhbEBtaWxlY2tpLnBsIHdyb3RlIG9uIFRodSwgMDkgTWFyIDIwMjMgMTI6NTI6MzcgKzAxMDA6 Cj4gCj4+IE9uIDIwMjMtMDMtMDkgMTI6NDQsIFNyaW5pdmFzIEthbmRhZ2F0bGEgd3JvdGU6Cj4+ ID4gT24gMDkvMDMvMjAyMyAxMToyMywgTWlxdWVsIFJheW5hbCB3cm90ZToKPj4gPj4gSGkgU3Jp bml2YXMsCj4+ID4+ID4+IHNyaW5pdmFzLmthbmRhZ2F0bGFAbGluYXJvLm9yZyB3cm90ZSBvbiBU aHUsIDkgTWFyIDIwMjMgMTA6NTM6MDcgPj4gKzAwMDA6Cj4+ID4+ID4+PiBPbiAwOS8wMy8yMDIz IDEwOjMyLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+PiA+Pj4+IEhpIFNyaW5pdmFzLAo+PiA+Pj4+ ID4+Pj4gc3Jpbml2YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnIHdyb3RlIG9uIFRodSwgOSBNYXIg MjAyMyAxMDoxMjoyNCA+Pj4+ICswMDAwOgo+PiA+Pj4+ID4+Pj4+IE9uIDIyLzAyLzIwMjMgMTc6 MjIsIFJhZmHFgiBNacWCZWNraSB3cm90ZToKPj4gPj4+Pj4+IEBAIC0xNzkxLDExICsxNzkyLDE1 IEBAIHNzaXplX3QgbnZtZW1fZGV2aWNlX2NlbGxfcmVhZChzdHJ1Y3QgPj4+Pj4+IG52bWVtX2Rl dmljZSAqbnZtZW0sCj4+ID4+Pj4+PiAgICAgCWlmICghbnZtZW0pCj4+ID4+Pj4+PiAgICAgCQly ZXR1cm4gLUVJTlZBTDsKPj4gPj4+Pj4+ICAgICA+ICsJLyogQ2VsbHMgd2l0aCByZWFkX3Bvc3Rf cHJvY2VzcyBob29rIG1heSByZWFsbG9jIGJ1ZmZlciB3ZSA+Pj4+Pj4gY2FuJ3QgYWxsb3cgaGVy ZSAqLwo+PiA+Pj4+Pj4gKwlpZiAoaW5mby0+cmVhZF9wb3N0X3Byb2Nlc3MpCj4+ID4+Pj4+PiAr CQlyZXR1cm4gLUVJTlZBTDsKPj4gPj4+Pj4gVGhpcyBzaG91bGQgcHJvYmFibHkgZ28gaW4gMS80 IHBhdGNoLiBPdGhlciB0aGFuIHRoYXQgc2VyaWVzIGxvb2tzID4+Pj4+IGdvb2QgdG8gbWUuCj4+ ID4+Pj4gPj4+PiBGWUkgcGF0Y2ggMS80IGlzIGFsc28gY2FycmllZCBieSB0aGUgbnZtZW0tbGF5 b3V0cyBzZXJpZXMsIHNvIGl0J3MKPj4gPj4+PiBwcm9iYWJseSBiZXN0IHRvIGtlZXAgdGhlc2Ug MiBwYXRjaGVzIHNlcGFyYXRlZCB0byBzaW1wbGlmeSB0aGUgPj4+PiBtZXJnaW5nLgo+PiA+Pj4g dGhhdCBpcyBpbnRlcm1lZGlhdGUgdGhpbmcsIGJ1dCBJZGVhbGx5IHRoaXMgY2hhbmdlIGJlbG9u Z3MgdG8gMS80ID4+PiBwYXRjaCwgc28gb25jZSBJIGFwcGx5IHRoZXNlIHBhdGNoZXMgdGhlbiB3 ZSBjYW4gYWx3YXlzIHJlYmFzZSBsYXlvdXQgPj4+IHNlcmllcyBvbiB0b3Agb2YgbnZtZW0tbmV4 dAo+PiA+PiA+PiBXZWxsLCBJIHN0aWxsIGRvbid0IHNlZSB0aGUgbmVlZCBmb3IgdGhpcyBwYXRj aCBiZWNhdXNlIHdlIGhhdmUgbm8gdXNlCj4+ID4+IGZvciBpdCAqYWZ0ZXIqIHRoZSBpbnRyb2R1 Y3Rpb24gb2YgbGF5b3V0cy4gWWVzIGluIHNvbWUgY2FzZXMgY2hhbmdpbmcKPj4gPj4gdGhlIHNp emUgb2YgYSBjZWxsIG1pZ2h0IG1heWJlIGJlIG5lZWRlZCwgYnV0IHJpZ2h0IG5vdyB0aGUgdXNl IGNhc2UgPj4gaXMKPj4gPj4gdG8gcHJvdmlkZSBhIE1BQyBhZGRyZXNzLCB3ZSBrbm93IGJlZm9y ZWhhbmQgdGhlIHNpemUgb2YgdGhlIGNlbGwsIHNvCj4+ID4+IHRoZXJlIGlzIG5vIG5lZWQsIGN1 cnJlbnRseSwgZm9yIHRoaXMgaGFjay4KPj4gPj4gPiBBbSBjb25mdXNlZCwgc2hvdWxkIEkgaWdu b3JlIHRoaXMgc2VyaWVzID8KPiAKPiBJIHRoaW5rIHRoaXMgc2VyaWVzIG1ha2VzIHNlbnNlIGFu ZCBhZGRyZXNzZXMgYSBuZWVkLiBCdXQgdGhpcyBpc3N1ZQo+IGNhbiBhbHNvIGJlIHNvbHZlZCB3 aXRoIHRoZSBsYXlvdXRzLiBSYWZhxYIgZG9lcyBub3Qgd2FudCAoSSBzdGlsbAo+IGRvbid0IGdl dCB0aGUgcmVhc29uKSB0byB1c2UgdGhhdCBzb2x1dGlvbi4gV2hhdGV2ZXIuIEJ1dCBpZiB5b3Ug YXBwbHkKPiB0aGlzIHNlcmllcywgaXQgcmVxdWlyZXMgdG8gbW9kaWZ5IHRoZSBsYXlvdXRzIHNl cmllcywgdGh1cyBwb3N0cG9uaW5nCj4gaXQgZXZlbiBtb3JlLiBJIHdvdWxkIHByZWZlciB0byBt ZXJnZSB0aGF0IGJpZyBzZXJpZXMgZmlyc3QgYW5kIHRoZW4KPiBtZXJnZSBhbiB1cGRhdGUgb2Yg dGhpcyBwYXRjaCAod2hpY2ggY2hhbmdlcyBpbiB0aGUgdHdvIGxheW91dCBkcml2ZXJzCj4gdGhl IGNlbGwgc2l6ZSBhcmd1bWVudCB0eXBlKS4KCkknbSBnb2luZyB0byBhcmd1ZSB0aG9zZSBhcmUg dHdvIGluZGVwZW5kZW50IHRoaW5ncy4KCkkgY2FuIGFkZCAucmVhZF9wb3N0X3Byb2Nlc3MoKSB3 aXRob3V0IG1ha2luZyB0aGlzIGRyaXZlciBhIGxheW91dC4KSSBjYW4gbWFrZSBpdCBsYXlvdXQg d2l0aG91dCBhZGRpbmcgLnJlYWRfcG9zdF9wcm9jZXNzKCkuCgpJIHNhaWQgbXVsdGlwbGUgdGlt ZSB0aGF0IEkgQU0gR09JTkcgdG8gY29udmVydCB0aGlzIGRyaXZlciBpbnRvIGEgCmxheW91dC4K Cgo+PiBJJ20gY29uZnVzZWQgbm8gbGVzcy4KPj4gCj4+IEkgdGhpbmsgd2UgaGF2ZSAzIGRpZmZl cmVudCBvcGluaW9ucyBhbmQgbm8gYWdyZWVtZW50IG9uIGhvdyB0byAKPj4gcHJvY2VlZC4KPj4g Cj4+IAo+PiBSYWZhxYIgKG1lKToKPj4gTlZNRU0gY2VsbHMgc2hvdWxkIGJlIHJlZ2lzdGVyZWQg YXMgdGhleSBhcmUgaW4gdGhlIHJhdyBmb3JtYXQuIE5vIAo+PiBzaXplCj4+IGFkanVzdG1lbnRz IHNob3VsZCBoYXBwZW4gd2hpbGUgcmVnaXN0ZXJpbmcgdGhlbS4gSWYgTlZNRU0gY2VsbCAKPj4g cmVxdWlyZXMKPj4gc29tZSByZWFkIHBvc3QtcHJvY2Vzc2luZyB0aGVuIGl0cyBzaXplIHNob3Vs ZCBiZSBhZGp1c3RlZCAqd2hpbGUqCj4+IHJlYWRpbmcuCj4gCj4gVGhpcyBpbXBsZW1lbnRhdGlv biBvbmx5IHdvcmtzIGlmIHlvdSByZWR1Y2UgdGhlIHNpemUgb2YgdGhlIGNlbGwuCgpXaGljaCBp cyBlbm91Z2ggZm9yIE1BQy4gQW5kIEkgd2FzIGFza2VkIHRvIHVzZSBzaW1wbGUgc29sdXRpb24u CkkgYWxzbyB3YXMgYXNrZWQgdG8gc3VwcG9ydCByZWFsbG9jYXRpb25nIHdoaWNoIHdhcyB0aGUg cmVhc29uIGZvcgpteSByZXdvcmsuCgoKPiBXaGlsZSB3cml0aW5nIHRoaXMsIEkgYW0gcmVhbGl6 aW5nIHRoYXQgd2Ugd291bGQgYWN0dWFsbHkgZXhwZWN0Cj4gYSBjaGVjayBvbiB0aGUgbnZtZW0g c2lkZSBpZiB0aGUgc2l6ZSB3YXMgZW5sYXJnZWQgYmVjYXVzZSB0aGlzIHdvdWxkCj4gYmUgYSBi dWcuCj4gCj4+IE1pY2hhZWw6Cj4+IC5yZWFkX3Bvc3RfcHJvY2VzcygpIHNob3VsZCBiZSByZWFs bG9jIHRoZSBidWZmZXIKPiAKPiBUaGlzIHdvdWxkIGJlIG1vcmUgcm9idXN0LiBCdXQgaWYgd2Ug c3RhcnQgd2l0aCAxLCB3ZSBjYW4gaW1wcm92ZSBpdAo+IGxhdGVyLCBJIGRvbid0IG1pbmQgYXMg bG9uZyBhcyBhbiBlcnJvciBpcyByZXR1cm5lZCBpbiBjYXNlIG9mIG1pc3VzZS4KPiAKPj4gTWlx dWVsOgo+PiBXaGlsZSByZWdpc3RlcmluZyBOVk1FTSBjZWxsIGl0cyBzaXplIHNob3VsZCBiZSBh bHJlYWR5IGFkanVzdGVkIHRvCj4+IG1hdGNoIHdoYXQgLnJlYWRfcG9zdF9wcm9jZXNzKCkgaXMg YWJvdXQgdG8gcmV0dXJuLgo+IAo+IFNvdW5kcyBsaWtlIHRoZSBzaW1wbGVzdCBzb2x1dGlvbiB0 byBtZSBhbmQgY292ZXJzIGFsbCB0aGUgdXNlcyB3ZQo+IGhhdmUgdG8gZGF5LCBidXQgaG9uZXN0 bHksIEkgd29uJ3QgZmlnaHQgZm9yIGl0Lgo+IAo+PiBJJ20gcmVhbGx5IHNvcnJ5IGlmIEkgZ290 IGFueW9uZSdzIHZpZXcgd3JvbmcuCj4gCj4gTEdUTS4KPiAKPj4gPiBXaGF0ZXZlci4gSWYgeW91 IHdhbnQgaXQsIGp1c3QgbWVyZ2UgaXQuIEJ1dCAqcGxlYXNlKiwgSSB3b3VsZCBsaWtlCj4+IAo+ PiA6LSkKPj4gCj4+ID4gdG8gc2VlIHRoZXNlIGxheW91dHMgaW4sIHNvIHdoYXQncyB0aGUgcGxh bj8KPj4gCj4+IEFtIG9uIGl0LCB5b3Ugc2VudCB2MyBqdXN0IDI0aHJzIGFnbyA6LSkKPiAKPiBZ ZXMsIHNvcnJ5IGZvciBiZWluZyBwdXNoeS4gSSBqdXN0IHdhbnRlZCB0byBoaWdobGlnaHQgdGhh dCB0aGUgdHdvCj4gc2VyaWVzIGNvbmZsaWN0IHRvZ2V0aGVyLCBidXQgbXkgYW5zd2VyIHdhcyBj bHVtc3kuIFRha2UgdGhlIHRpbWUgeW91Cj4gbmVlZCwgdGhhdCdzIGhvdyBpdCdzIHN1cHBvc2Vk IHRvIHdvcmsgYW55d2F5LgoKQUZBSVIgdGhlcmUgaXMgYSBtaW5vciBjb25mbGljdCBjYXVzZWQg YnkgdGhlIEFQSSBjaGFuZ2UgdGhhdCBhbGxvd3MKcmVhbGxvY2F0aW9ucy4gSSBkZWNpZGVkIHRv IHJlYmFzZSBteSBwYXRjaHdvcmsgYmVjYXVzZSBNaWNoYWVsIGNsYWltZWQKaXQncyBnb2luZyB0 byB0YWtlIGF0IGxlYXN0IGZldyBtb3JlIHdlZWtzIHRvIHJld29yayBsYXlvdXRzIHBhdGNoc2V0 LgoKTm93IHdlIGhhdmUgbGF5b3V0cyBwYXRjaHNldCByZWFkeSBhbnl3YXkgYW5kIEknbGwgaGF2 ZSB0byByZWJhc2UKYWdhaW4uIFdlbGwsIGZldyBtb3JlIHdhc3RlZCBob3Vycywgc2hvdWxkbid0 IG1ha2UgbXVjaCBkaWZmZXJlbmNlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E27C61DA4 for ; Thu, 9 Mar 2023 14:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbjCIO0s (ORCPT ); Thu, 9 Mar 2023 09:26:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbjCIO0p (ORCPT ); Thu, 9 Mar 2023 09:26:45 -0500 X-Greylist: delayed 1784 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 09 Mar 2023 06:26:44 PST Received: from 20.mo561.mail-out.ovh.net (20.mo561.mail-out.ovh.net [178.33.47.94]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 131D6D533 for ; Thu, 9 Mar 2023 06:26:43 -0800 (PST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.108.1.219]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 8C9D121DCE for ; Thu, 9 Mar 2023 13:31:23 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-74llp (unknown [10.110.208.116]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 8CDCA1FE67; Thu, 9 Mar 2023 13:31:21 +0000 (UTC) Received: from RCM-web10.webmail.mail.ovh.net ([151.80.29.18]) by ghost-submission-6684bf9d7b-74llp with ESMTPSA id 3hbMIKnfCWTjaAUA/ww3gA (envelope-from ); Thu, 09 Mar 2023 13:31:21 +0000 MIME-Version: 1.0 Date: Thu, 09 Mar 2023 14:31:19 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Miquel Raynal Cc: Srinivas Kandagatla , =?UTF-8?Q?Rafa?= =?UTF-8?Q?=C5=82_Mi=C5=82ecki?= , Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Michael Walle , gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer In-Reply-To: <20230309141038.4399af1f@xps-13> References: <20230222172245.6313-1-zajec5@gmail.com> <20230222172245.6313-3-zajec5@gmail.com> <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org> <20230309113211.6321ce3d@xps-13> <2dc096f5-f5ce-f99b-42ac-0fb24682239a@linaro.org> <20230309122324.4b012a58@xps-13> <20230309141038.4399af1f@xps-13> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <649e1c9196cf78232816dcf29ece4c52@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 16116975693792521129 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedgheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtkehjtddtreejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeejvdelgfeutdfhfeelheegfedtleduleeuvdfgfeefvefhvedtheetjeetfeehgeenucfkphepuddvjedrtddrtddruddpudelgedrudekjedrjeegrddvfeefpdduhedurdektddrvdelrddukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehrrghfrghlsehmihhlvggtkhhirdhplheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehiedupdhmohguvgepshhmthhpohhuth Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023-03-09 14:10, Miquel Raynal wrote: > Hello, > > rafal@milecki.pl wrote on Thu, 09 Mar 2023 12:52:37 +0100: > >> On 2023-03-09 12:44, Srinivas Kandagatla wrote: >> > On 09/03/2023 11:23, Miquel Raynal wrote: >> >> Hi Srinivas, >> >> >> srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:53:07 >> +0000: >> >> >>> On 09/03/2023 10:32, Miquel Raynal wrote: >> >>>> Hi Srinivas, >> >>>> >>>> srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 >>>> +0000: >> >>>> >>>>> On 22/02/2023 17:22, Rafał Miłecki wrote: >> >>>>>> @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct >>>>>> nvmem_device *nvmem, >> >>>>>> if (!nvmem) >> >>>>>> return -EINVAL; >> >>>>>> > + /* Cells with read_post_process hook may realloc buffer we >>>>>> can't allow here */ >> >>>>>> + if (info->read_post_process) >> >>>>>> + return -EINVAL; >> >>>>> This should probably go in 1/4 patch. Other than that series looks >>>>> good to me. >> >>>> >>>> FYI patch 1/4 is also carried by the nvmem-layouts series, so it's >> >>>> probably best to keep these 2 patches separated to simplify the >>>> merging. >> >>> that is intermediate thing, but Ideally this change belongs to 1/4 >>> patch, so once I apply these patches then we can always rebase layout >>> series on top of nvmem-next >> >> >> Well, I still don't see the need for this patch because we have no use >> >> for it *after* the introduction of layouts. Yes in some cases changing >> >> the size of a cell might maybe be needed, but right now the use case >> is >> >> to provide a MAC address, we know beforehand the size of the cell, so >> >> there is no need, currently, for this hack. >> >> > Am confused, should I ignore this series ? > > I think this series makes sense and addresses a need. But this issue > can also be solved with the layouts. Rafał does not want (I still > don't get the reason) to use that solution. Whatever. But if you apply > this series, it requires to modify the layouts series, thus postponing > it even more. I would prefer to merge that big series first and then > merge an update of this patch (which changes in the two layout drivers > the cell size argument type). I'm going to argue those are two independent things. I can add .read_post_process() without making this driver a layout. I can make it layout without adding .read_post_process(). I said multiple time that I AM GOING to convert this driver into a layout. >> I'm confused no less. >> >> I think we have 3 different opinions and no agreement on how to >> proceed. >> >> >> Rafał (me): >> NVMEM cells should be registered as they are in the raw format. No >> size >> adjustments should happen while registering them. If NVMEM cell >> requires >> some read post-processing then its size should be adjusted *while* >> reading. > > This implementation only works if you reduce the size of the cell. Which is enough for MAC. And I was asked to use simple solution. I also was asked to support reallocationg which was the reason for my rework. > While writing this, I am realizing that we would actually expect > a check on the nvmem side if the size was enlarged because this would > be a bug. > >> Michael: >> .read_post_process() should be realloc the buffer > > This would be more robust. But if we start with 1, we can improve it > later, I don't mind as long as an error is returned in case of misuse. > >> Miquel: >> While registering NVMEM cell its size should be already adjusted to >> match what .read_post_process() is about to return. > > Sounds like the simplest solution to me and covers all the uses we > have to day, but honestly, I won't fight for it. > >> I'm really sorry if I got anyone's view wrong. > > LGTM. > >> > Whatever. If you want it, just merge it. But *please*, I would like >> >> :-) >> >> > to see these layouts in, so what's the plan? >> >> Am on it, you sent v3 just 24hrs ago :-) > > Yes, sorry for being pushy. I just wanted to highlight that the two > series conflict together, but my answer was clumsy. Take the time you > need, that's how it's supposed to work anyway. AFAIR there is a minor conflict caused by the API change that allows reallocations. I decided to rebase my patchwork because Michael claimed it's going to take at least few more weeks to rework layouts patchset. Now we have layouts patchset ready anyway and I'll have to rebase again. Well, few more wasted hours, shouldn't make much difference.