From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kumar Gala <galak@kernel.crashing.org>
Date: Wed, 12 Dec 2007 22:20:10 -0600
Subject: [U-Boot-Users] [PATCH 1/2] mpc85xx: Add support for SBC8548
In-Reply-To: <1197510565.24565.11.camel@server>
References: <1197510565.24565.11.camel@server>
Message-ID: <64EE8341-7125-4BC3-8F69-F1FC5ABC054F@kernel.crashing.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


Missing updates to MAKEALL

[snip]

> +
> +typedef struct epld_reg {
> +	u_char bd_rev;		/* Board revision */
> +} epld_reg_t;

seems over kill for the one usage below.

>
> +
> +unsigned int get_board_rev(void)
> +{
> +	volatile epld_reg_t *epld = (epld_reg_t *)CFG_BD_REV;
> +
> +	return ((epld->bd_rev) >> 4);
> +}
> +
> +#if defined(CONFIG_OF_BOARD_SETUP)
> +void
> +ft_board_setup(void *blob, bd_t *bd)
> +{
> +	ft_cpu_setup(blob, bd);

PCI of setup code?

>
> +}
> +#endif
> +

- k