From: Segher Boessenkool <segher@kernel.crashing.org>
To: Wade Farnsworth <wfarnsworth@mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH v3] Create add_rtc() function to enable the RTC CMOS driver
Date: Wed, 20 Jun 2007 19:46:54 +0200 [thread overview]
Message-ID: <64a22620446fccee1d52b7fc0e845b84@kernel.crashing.org> (raw)
In-Reply-To: <1182358772.5674.383.camel@rhino>
> + /*
> + * RTC_PORT(x) is hardcoded in asm/mc146818rtc.h. Verify that the
> + * address provided by the device node matches.
> + */
> + if (res.start != RTC_PORT(0)) {
> + of_node_put(np);
> + return -ENODEV;
> + }
You can place the of_node_put() here and remove the
previous one, and the following one.
> + pd = platform_device_register_simple("rtc_cmos", -1,
> + &res, 1);
> + of_node_put(np);
Code looks fine, with or without that change.
Segher
next prev parent reply other threads:[~2007-06-20 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 0:15 [PATCH v2] Create add_rtc() function to enable the RTC CMOS driver Wade Farnsworth
2007-06-20 10:06 ` Segher Boessenkool
2007-06-20 16:21 ` Wade Farnsworth
2007-06-20 16:59 ` [PATCH v3] " Wade Farnsworth
2007-06-20 17:46 ` Segher Boessenkool [this message]
2007-06-22 3:31 ` David Gibson
2007-06-22 7:56 ` Segher Boessenkool
2007-06-25 3:33 ` David Gibson
2007-07-10 11:54 ` Paul Mackerras
2007-07-10 16:55 ` [PATCH v4] " Wade Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64a22620446fccee1d52b7fc0e845b84@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=wfarnsworth@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.