From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: "Asahi Lina" <lina@asahilina.net>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Sven Van Asbroeck" <thesven73@gmail.com>
Cc: Fox Chen <foxhlchen@gmail.com>,
Andreas Hindborg <a.hindborg@samsung.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev
Subject: Re: [PATCH v2 2/6] rust: error: Add Error::to_ptr()
Date: Wed, 29 Mar 2023 11:49:44 -0300 [thread overview]
Message-ID: <64a4a0fe-d364-4cd0-e2e5-8e7cfd782ee6@gmail.com> (raw)
In-Reply-To: <20230224-rust-error-v2-2-3900319812da@asahilina.net>
On 3/29/23 09:04, Asahi Lina wrote:
> [...]
>
> +
> + /// Returns the error encoded as a pointer.
> + #[allow(dead_code)]
> + pub(crate) fn to_ptr<T>(self) -> *mut T {
> + // SAFETY: Valid as long as self.0 is a valid error
> + unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
> + }
> }
>
> impl From<AllocError> for Error {
>
Reviewed-by: Martin Rodriguez Reboredo
next prev parent reply other threads:[~2023-03-29 14:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 12:04 [PATCH v2 0/6] rust: error: Add missing wrappers to convert to/from kernel error codes Asahi Lina
2023-03-29 12:04 ` [PATCH v2 1/6] rust: error: Rename to_kernel_errno() -> to_errno() Asahi Lina
2023-03-29 14:47 ` Martin Rodriguez Reboredo
2023-03-29 15:04 ` Miguel Ojeda
2023-03-29 18:16 ` Martin Rodriguez Reboredo
2023-03-29 22:33 ` Miguel Ojeda
2023-03-29 20:32 ` Gary Guo
2023-03-29 22:33 ` Miguel Ojeda
2023-03-29 12:04 ` [PATCH v2 2/6] rust: error: Add Error::to_ptr() Asahi Lina
2023-03-29 14:49 ` Martin Rodriguez Reboredo [this message]
2023-03-29 20:34 ` Gary Guo
2023-03-29 12:04 ` [PATCH v2 3/6] rust: error: Add Error::from_errno() Asahi Lina
2023-03-29 14:51 ` Martin Rodriguez Reboredo
2023-03-29 20:35 ` Gary Guo
2023-03-29 12:04 ` [PATCH v2 4/6] rust: error: Add to_result() helper Asahi Lina
2023-03-29 14:52 ` Martin Rodriguez Reboredo
2023-03-29 20:36 ` Gary Guo
2023-03-29 12:04 ` [PATCH v2 5/6] rust: error: Add a helper to convert a C ERR_PTR to a `Result` Asahi Lina
2023-03-29 14:53 ` Martin Rodriguez Reboredo
2023-03-29 20:42 ` Gary Guo
2023-03-29 12:04 ` [PATCH v2 6/6] rust: error: Add from_result() helper Asahi Lina
2023-03-29 14:55 ` Martin Rodriguez Reboredo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64a4a0fe-d364-4cd0-e2e5-8e7cfd782ee6@gmail.com \
--to=yakoyoku@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=foxhlchen@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.