All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andrey Grodzovsky
	<Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>,
	christian.koenig-5C7GfCeVMHo@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Leo Liu <leo.liu-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 2/2] drm/amdgpu: cleanup VCN IB generation
Date: Tue, 13 Feb 2018 14:57:40 +0100	[thread overview]
Message-ID: <64b53d0a-62d6-cfe5-341d-2aa5548c4f8d@gmail.com> (raw)
In-Reply-To: <2992ee3b-c077-9222-b1e1-79ea9cb3c143-5C7GfCeVMHo@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1160 bytes --]

It's always the obvious. Leo any more comments on this?

If not can we get your rb on this patch as well?

Andrey if Leo gives his ok can you commit both? I'm on vacation and 
don't want to mess with this at the moment.

Thanks,
Christian.

Am 13.02.2018 um 14:50 schrieb Andrey Grodzovsky:
>
> Found the issue, amdgpu_vcn_dec_get_destroy_msg was missing struct 
> amdgpu_bo *bo *= NULL*; and so amdgpu_bo_create_reserved would not 
> call amdgpu_bo_create.
>
> Attached updated patch.
>
> Thanks,
>
> Andrey
>
>
> On 02/12/2018 02:46 PM, Andrey Grodzovsky wrote:
>> Tested with latest amd-staging-drm-next + VCN patch on top. VCN dec 
>> tests pass but when modprobing amdgpu I get a few warnings and 
>> BUG_ONs - log attached. UVD is not enabled so can't test the UVD patch.
>>
>>
>> Thanks,
>>
>> Andrey
>>
>>
>> On 02/09/2018 07:31 AM, Christian König wrote:
>>> Question is rather can somebody please test this on Raven?
>>>
>>> Thanks,
>>> Christian. 
>>
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[-- Attachment #1.2: Type: text/html, Size: 2454 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-02-13 13:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 19:48 [PATCH 1/2] drm/amdgpu: fix and cleanup UVD IB generation Christian König
     [not found] ` <20180207194822.7878-1-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-02-07 19:48   ` [PATCH 2/2] drm/amdgpu: cleanup VCN " Christian König
     [not found]     ` <20180207194822.7878-2-christian.koenig-5C7GfCeVMHo@public.gmane.org>
2018-02-09 12:20       ` Andrey Grodzovsky
     [not found]         ` <839e2b57-edf4-d389-56ab-1a97dd84c832-5C7GfCeVMHo@public.gmane.org>
2018-02-09 12:31           ` Christian König
     [not found]             ` <6262040a-ef05-bda4-904e-d8a5954239bc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-09 12:38               ` Andrey Grodzovsky
2018-02-12 19:46               ` Andrey Grodzovsky
     [not found]                 ` <eca08a4f-cc5c-ab86-acf0-f04444f733f4-5C7GfCeVMHo@public.gmane.org>
2018-02-13 13:50                   ` Andrey Grodzovsky
     [not found]                     ` <2992ee3b-c077-9222-b1e1-79ea9cb3c143-5C7GfCeVMHo@public.gmane.org>
2018-02-13 13:57                       ` Christian König [this message]
     [not found]                         ` <64b53d0a-62d6-cfe5-341d-2aa5548c4f8d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-13 14:02                           ` Andrey Grodzovsky
2018-02-13 14:14                           ` Leo Liu
2018-02-09 12:32       ` Christian König
     [not found]         ` <680530de-0b4b-8c22-1210-2b2b4d70cbe1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-09 15:39           ` Leo Liu
2018-02-13 14:19   ` [PATCH 1/2] drm/amdgpu: fix and cleanup UVD " Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64b53d0a-62d6-cfe5-341d-2aa5548c4f8d@gmail.com \
    --to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=leo.liu-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.