From: osalvador@suse.de
To: Wei Yang <richard.weiyang@gmail.com>
Cc: mhocko@suse.com, akpm@linux-foundation.org, jweiner@fb.com,
linux-mm@kvack.org, owner-linux-mm@kvack.org
Subject: Re: [PATCH v2] mm, show_mem: drop pgdat_resize_lock in show_mem()
Date: Fri, 30 Nov 2018 09:54:20 +0100 [thread overview]
Message-ID: <64daff638c221984017fe58b09893386@suse.de> (raw)
In-Reply-To: <20181129235532.9328-1-richard.weiyang@gmail.com>
On 2018-11-30 00:55, Wei Yang wrote:
> Function show_mem() is used to print system memory status when user
> requires or fail to allocate memory. Generally, this is a best effort
> information so any races with memory hotplug (or very theoretically an
> early initialization) should be tolerable and the worst that could
> happen is to print an imprecise node state.
>
> Drop the resize lock because this is the only place which might hold
> the
> lock from the interrupt context and so all other callers might use a
> simple spinlock. Even though this doesn't solve any real issue it makes
> the code easier to follow and tiny more effective.
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
prev parent reply other threads:[~2018-11-30 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 21:08 [PATCH] mm, show_mem: drop pgdat_resize_lock in show_mem() Wei Yang
2018-11-28 22:07 ` Andrew Morton
2018-11-29 1:52 ` Wei Yang
2018-11-29 8:17 ` Michal Hocko
2018-11-29 9:32 ` Wei Yang
2018-11-29 15:04 ` Wei Yang
2018-11-29 15:49 ` Michal Hocko
2018-11-29 16:05 ` Wei Yang
2018-11-29 16:18 ` Michal Hocko
2018-11-29 23:49 ` Wei Yang
2018-11-29 23:55 ` [PATCH v2] " Wei Yang
2018-11-30 8:17 ` Michal Hocko
2018-11-30 8:54 ` osalvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64daff638c221984017fe58b09893386@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jweiner@fb.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=owner-linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.