Re: [PATCH v2 3/3] null_blk: clean up setting zones read-only or offline

[Damien Le Moal <dlemoal@kernel.org>]

On 2026/10/22 11:22, Niklas Cassel wrote:
> null_set_zone_cond() takes a zone condition, even though read-only and
> offline are the only zone conditions that it can set. Because of this,
> it needs a WARN_ON_ONCE() to reject any other zone condition, and its
> name suggests a generic helper that can set any zone condition.
> 
> Rename null_set_zone_cond() to null_set_zone_readonly_or_offline(), and
> replace its zone condition argument with a bool, set_offline, which
> selects between the read-only and offline conditions. Also remove the
> comment above the function, as it only repeats the new function name.
> 
> zone_cond_store() keeps taking a zone condition, as it, unlike
> null_set_zone_readonly_or_offline(), contains generic code, and might
> be extended to support additional zone conditions in the future.
> 
> No functional change, as zone_cond_store() is only called with the
> read-only or offline condition.
> 
> Suggested-by: Damien Le Moal <dlemoal@kernel.org>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research