From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84151C43334 for ; Thu, 14 Jul 2022 12:26:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 37359840A9; Thu, 14 Jul 2022 14:26:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="40/6oFT2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2DCCB840B8; Thu, 14 Jul 2022 14:26:50 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B5DA84094 for ; Thu, 14 Jul 2022 14:26:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nw5iLHzSGxxgKjwWxg3gNlKQWfFznhPxduEpjhdIgzwHI7hbHFHi17g4gSkc+TZN2d9/Zu7Ppn5POcdzU+HpE5KQDWmS23OogAb4tnrCN7Nqn2YqYYWwVeFkP4uieIEbscaYn7qs5eH5mFqflp/TVgKBWRAZdw08nsjitLWkp9LLmomucivbUl/e2TIvQ1zJlRr/KfD7t8deMSV8dL/dJkrvxCKYhEeJdTDcbUDAqAE7l0JNcq0WLqVo+ON+c3HUxcaeAw89f0KrDisYiNLPyzXwvvC0eUWBPDzqO3EShS6+fVF6rGA3JjtcbuBkDTlMFV6aAHJWcjiVHhM6T0NFJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+0AmGjwdXKBROMo0r0HkorZh1SMXT2lixRJcMYQ9AAs=; b=EmRxV3wf/tdY9gBA6C8oiu0ba2AdVEGYoonO9cqtKdbcFNZ8tVYD1ONdymhisNraKMLVPQG4ssGkOlS6JKb0ENaFmajxYdL3f/ymaFjeWqvdHkY0EaMuye1+ro+sH4e+yVTjABpsYIY2ZUcUUUjnUZwR60f+iMuhXixbFOR514MVw6w4nPQjgC1WvJINx3KFQzROi7XfVNiv1JKi5IPYtBTOEfFfriddumqdtkt0gpUG0Msnb02OeNMM1gh0vBIiD6I6BuP6eLqZh07Tdi2L6SOrEVJ05U9G+VM80wAOYK6cNW7qpYgm67iwHKQB//j5M/kXiPk6wQ1YVsOzDUUOsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=weidmueller.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0AmGjwdXKBROMo0r0HkorZh1SMXT2lixRJcMYQ9AAs=; b=40/6oFT2SFex2ZIdh+6rXO3m9HxBGYk/PyIvtNYL7v0h2hLwupXskDOZfQsGXrIC9776Upgwrq7MbyGzX1K2qCDQGBQqHNoTSw10yLsMzoIa3lq5Xdx5wUmXLfzqPtOjhNx8eicrj3VRg/qYdAyBMbTrS5W543VLZoJSWZrG5+A= Received: from DM5PR07CA0120.namprd07.prod.outlook.com (2603:10b6:4:ae::49) by SJ1PR12MB6316.namprd12.prod.outlook.com (2603:10b6:a03:455::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 12:26:41 +0000 Received: from DM6NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::30) by DM5PR07CA0120.outlook.office365.com (2603:10b6:4:ae::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21 via Frontend Transport; Thu, 14 Jul 2022 12:26:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT013.mail.protection.outlook.com (10.13.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 12:26:40 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 14 Jul 2022 07:26:38 -0500 Message-ID: <64e77df3-5cc9-bc05-a8eb-6da9210e5583@amd.com> Date: Thu, 14 Jul 2022 14:26:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] xilinx: zynqmp: Do not use 0 as spl bss start address Content-Language: en-US To: Stefan Herbrechtsmeier , Michal Simek CC: U-Boot , Stefan Herbrechtsmeier References: <20220607074314.27125-1-stefan.herbrechtsmeier-oss@weidmueller.com> <0414d420-6fbf-a721-a33a-e0af0e0f2a21@weidmueller.com> From: Michal Simek In-Reply-To: <0414d420-6fbf-a721-a33a-e0af0e0f2a21@weidmueller.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d279fff-2840-4b7f-7302-08da65941b0c X-MS-TrafficTypeDiagnostic: SJ1PR12MB6316:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLakpOrVMwXQFkR0SqTGInxHfXZgZVRpySq/dov+/mBn154AiUCSnYKaPRl/2aO8NXw/3Zwhd+IyWe2527g9ULhbGFGKv1JEx9NOpJRe2mBf/kP0A2ihAOOmkfTQH5oMAy59wnKFj+IpZ+BvHu8l7c6rIIRvwAzvNJxobdodQkkEfhi4FYd2v/6urnUGMRjSFosF0mGNnDcwErOZ6/BAAt0VIgPNvdbi+faEnBrpnG9bSfVpP3Md/ISfE/cAMLgXhdVJeckckKPXEpnOUlGQkhN4zZ/Jvq7jFpUJZmz0uXsig6FmUQGfcITu49AeghALibLUA5F7qFxvFQc3x30go5hAiQgc1nLeTm9Got3h2jHMy8vVzObIvcrhb2tpzjvx5CPEdMTa2j/moUGXKhpCPcZWR8sh7hiQX8FDEQLkEwG3PSUSbpQZA5JdjK07lUWKLaRAtCbS5x+gZSQVrfegaIMFKslVRzj0yOikTwNty4pWnSBQS/gD3FbaJPFgB89/meb/tX2eZskfGZT2Hc8cJQ2BsnLPIaHmEXV1J9/8dnH1TKDO9wRxJqUGEHuHOKz/8p6SfYyuF5Qwk1JIUVtTxBfeYeaQRiEZt2Bpv8HzYK8/FdKaZ1U94k4Rv2sdzNWQ2MZZytZHQYK2rAxNXs7ewJaGH5zw5jm8hQkjOkQRYqV3YPz60G8qW6gObh8k0NbllSfFW9yO3utfQ4VEkzO6iT1cJPzSDfn8KXNVen1Doukn9eYzWs2mVRYXhseN/Ky7V/fLwtfyAIc0GjCHBsS7lDbArYK//lHi1RbxL2btmjqjgdVTvsONqpZyUoZKzfE8jal2oZL8VuJcg6QazI6NSf8mTJbOXGGypT6V0UTtELdMiAwI5Y4+ys9Pz2gVDJds X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(346002)(39860400002)(376002)(136003)(396003)(36840700001)(40470700004)(46966006)(44832011)(31686004)(40460700003)(40480700001)(86362001)(4326008)(5660300002)(2906002)(41300700001)(110136005)(82310400005)(8936002)(36756003)(83380400001)(53546011)(8676002)(316002)(356005)(81166007)(186003)(426003)(54906003)(70586007)(2616005)(66574015)(336012)(16526019)(31696002)(26005)(70206006)(82740400003)(47076005)(16576012)(6666004)(478600001)(36860700001)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 12:26:40.8774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d279fff-2840-4b7f-7302-08da65941b0c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6316 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On 7/14/22 14:22, Stefan Herbrechtsmeier wrote: > Hi Michal, > > Am 07.06.2022 um 10:13 schrieb Michal Simek: >> út 7. 6. 2022 v 9:44 odesílatel Stefan Herbrechtsmeier >> napsal: >>> >>> From: Stefan Herbrechtsmeier >>> >>> Do not use 0 as address for memory because of the special meaning for >>> pointers (null pointer). Change the spl bss start address to the second >>> page. >>> >>> Signed-off-by: Stefan Herbrechtsmeier >>> >>> --- >>> The problem was discovered with a static array initialized with zero. >>> The compiler placed the array at address 0 and thereby a pointer to the >>> array was interpreted as null pointer. >>> >>> Changes in v2: >>> - Rework commit message and replace address null by 0 >>> >>>   include/configs/xilinx_zynqmp.h | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h >>> index f25d796a1e..21a5cf1617 100644 >>> --- a/include/configs/xilinx_zynqmp.h >>> +++ b/include/configs/xilinx_zynqmp.h >>> @@ -209,7 +209,7 @@ >>>   #define CONFIG_SPL_MAX_SIZE            0x40000 >>> >>>   /* Just random location in OCM */ >>> -#define CONFIG_SPL_BSS_START_ADDR      0x0 >>> +#define CONFIG_SPL_BSS_START_ADDR      0x1000 >>>   #define CONFIG_SPL_BSS_MAX_SIZE                0x80000 >>> >>>   #if defined(CONFIG_SPL_SPI_FLASH_SUPPORT) >>> -- >>> 2.30.2 >>> >> >> Applied. >> M >> > > I think this patch get lost because of the "Convert CONFIG_SPL_BSS_START_ADDR to > Kconfig" change. yes you are right. Can you please send one more to fix it in defconfig? Thanks, Michal