All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mateusz Kusiak <mateusz.kusiak@linux.intel.com>
To: Xiao Ni <xni@redhat.com>, linux-raid@vger.kernel.org
Cc: jes@trained-monkey.org, song@kernel.org, yukuai1@huaweicloud.com,
	ncroxon@redhat.com, colyli@suse.de,
	mariusz.tkaczyk@linux.intel.com
Subject: Re: [PATCH 1/5] tests/test enhance
Date: Fri, 19 Apr 2024 09:30:16 +0200	[thread overview]
Message-ID: <64f751b0-542b-474e-aedf-7d2b80f41d2d@linux.intel.com> (raw)
In-Reply-To: <bf7edcf8-9cb8-4349-ae34-a9ca5fa9cf17@linux.intel.com>

On 19.04.2024 09:16, Mateusz Kusiak wrote:
> Hi Xiao,
> one small note from me.
> 
> On 18.04.2024 12:23, Xiao Ni wrote:
>> @@ -309,6 +322,7 @@ print_warning() {
>>   main() {
>>       print_warning
>>       do_setup
>> +    record_system_speed_limit
>>       echo "Testing on linux-$(uname -r) kernel"
>>       [ "$savelogs" == "1" ] &&
> 
> 
> I feel like record_system_speed_limit() should be called in do_setup() rather than main().
> Saving current system settings is job of setup.
> 
> Thanks,
> Mateusz
> 

One more thing. Feel free to add tag "fixes".
I broke this behavior (lowering sync speed) in 4c12714d1ca0 ("test: run tests on system level mdadm").

Thanks,
Mateusz

  reply	other threads:[~2024-04-19  7:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 10:23 [PATCH RFC 0/5] mdadm tests fix and enhance Xiao Ni
2024-04-18 10:23 ` [PATCH 1/5] tests/test enhance Xiao Ni
2024-04-19  7:16   ` Mateusz Kusiak
2024-04-19  7:30     ` Mateusz Kusiak [this message]
2024-04-21  2:46       ` Xiao Ni
2024-04-18 10:23 ` [PATCH 2/5] tests/00createnames enhance Xiao Ni
2024-04-19  7:20   ` Mariusz Tkaczyk
2024-04-22  6:56     ` Xiao Ni
2024-04-22  7:23       ` Mariusz Tkaczyk
2024-04-19  9:47   ` Mariusz Tkaczyk
2024-04-22  6:57     ` Xiao Ni
2024-04-22 10:15       ` Mariusz Tkaczyk
2024-04-22 13:31         ` Xiao Ni
2024-04-18 10:23 ` [PATCH 3/5] tests/01r5fail enhance Xiao Ni
2024-04-19  9:57   ` Mariusz Tkaczyk
2024-05-08  8:35   ` Mariusz Tkaczyk
2024-04-18 10:23 ` [PATCH 4/5] tests/01r5integ.broken Xiao Ni
2024-05-08  8:36   ` Mariusz Tkaczyk
2024-04-18 10:23 ` [PATCH 5/5] tests/01raid6integ.broken can be removed Xiao Ni
2024-04-19 10:05   ` Mariusz Tkaczyk
2024-04-19 15:57     ` Song Liu
2024-04-22 13:54       ` Xiao Ni
2024-05-08  8:37         ` Mariusz Tkaczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64f751b0-542b-474e-aedf-7d2b80f41d2d@linux.intel.com \
    --to=mateusz.kusiak@linux.intel.com \
    --cc=colyli@suse.de \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.tkaczyk@linux.intel.com \
    --cc=ncroxon@redhat.com \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yukuai1@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.