[PATCH v2 0/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

[PATCH v2 0/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

[Vlad Pruteanu]

Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Vlad Pruteanu (1):
  Bluetooth: ISO: Set CIS bit only for devices with CIS support

 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.1

[PATCH v2 1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

[Vlad Pruteanu]

Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Signed-off-by: Vlad Pruteanu <vlad.pruteanu@nxp.com>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..f09c5812c247 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,7 +4264,7 @@ static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));
-- 
2.34.1

RE: Bluetooth: ISO: Set CIS bit only for devices with CIS support

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782458

---Test result---

Test Summary:
CheckPatch                    PASS      0.62 seconds
GitLint                       PASS      0.26 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      38.24 seconds
CheckAllWarning               PASS      42.30 seconds
CheckSparse                   PASS      47.58 seconds
CheckSmatch                   PASS      130.78 seconds
BuildKernel32                 PASS      37.53 seconds
TestRunnerSetup               PASS      572.71 seconds
TestRunner_l2cap-tester       PASS      32.25 seconds
TestRunner_iso-tester         PASS      68.79 seconds
TestRunner_bnep-tester        PASS      12.89 seconds
TestRunner_mgmt-tester        PASS      242.18 seconds
TestRunner_rfcomm-tester      PASS      19.26 seconds
TestRunner_sco-tester         PASS      22.68 seconds
TestRunner_ioctl-tester       PASS      21.84 seconds
TestRunner_mesh-tester        PASS      16.31 seconds
TestRunner_smp-tester         PASS      17.33 seconds
TestRunner_userchan-tester    PASS      13.54 seconds
IncrementalBuild              PASS      35.35 seconds



---
Regards,
Linux Bluetooth

[PATCH 0/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

[Vlad Pruteanu]

Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.

Vlad Pruteanu (1):
  Bluetooth: ISO: Set CIS bit only for devices with CIS support

 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.1

[PATCH 1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

[Vlad Pruteanu]

Currently the CIS bit that can be set by the host is set for any device
that has CIS or BIS support. In reality, devices that support BIS may not
allow that bit to be set and so, the HCI bring up fails for them.

This commit fixes this by only setting the bit for CIS capable devices.
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index ec4dfc4c5749..f09c5812c247 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4264,7 +4264,7 @@ static int hci_le_set_host_feature_sync(struct hci_dev *hdev)
 {
 	struct hci_cp_le_set_host_feature cp;
 
-	if (!iso_capable(hdev))
+	if (!cis_capable(hdev))
 		return 0;
 
 	memset(&cp, 0, sizeof(cp));
-- 
2.34.1

RE: [1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 2087 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=782459

---Test result---

Test Summary:
CheckPatch                    FAIL      0.93 seconds
GitLint                       PASS      0.30 seconds
SubjectPrefix                 PASS      0.11 seconds
BuildKernel                   PASS      32.44 seconds
CheckAllWarning               PASS      35.99 seconds
CheckSparse                   PASS      40.02 seconds
CheckSmatch                   PASS      112.82 seconds
BuildKernel32                 PASS      31.05 seconds
TestRunnerSetup               PASS      477.41 seconds
TestRunner_l2cap-tester       PASS      27.08 seconds
TestRunner_iso-tester         PASS      48.17 seconds
TestRunner_bnep-tester        PASS      10.35 seconds
TestRunner_mgmt-tester        PASS      215.71 seconds
TestRunner_rfcomm-tester      PASS      15.58 seconds
TestRunner_sco-tester         PASS      18.97 seconds
TestRunner_ioctl-tester       PASS      17.45 seconds
TestRunner_mesh-tester        PASS      12.96 seconds
TestRunner_smp-tester         PASS      13.89 seconds
TestRunner_userchan-tester    PASS      10.91 seconds
IncrementalBuild              PASS      30.31 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[1/1] Bluetooth: ISO: Set CIS bit only for devices with CIS support
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13377269.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth