From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47F76C433EF for ; Fri, 19 Nov 2021 09:06:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F88B61AA2 for ; Fri, 19 Nov 2021 09:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbhKSJJx (ORCPT ); Fri, 19 Nov 2021 04:09:53 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]:14956 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbhKSJJx (ORCPT ); Fri, 19 Nov 2021 04:09:53 -0500 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HwW2004LlzZdB3; Fri, 19 Nov 2021 17:04:24 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 19 Nov 2021 17:06:34 +0800 Received: from [10.67.102.185] (10.67.102.185) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Fri, 19 Nov 2021 17:06:34 +0800 Subject: Re: [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= CC: Will Deacon , Mark Rutland , "Bjorn Helgaas" , PCI , linux-arm-kernel , "Linux Kernel Mailing List" , , References: <20211029093632.4350-1-liuqi115@huawei.com> <20211029093632.4350-3-liuqi115@huawei.com> From: "liuqi (BA)" Message-ID: <65023305-f05b-cfc3-16bf-a27e2b6da87f@huawei.com> Date: Fri, 19 Nov 2021 17:06:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.102.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2021/11/19 15:55, Krzysztof Wilczyński wrote: > Hi Qi, > > Thank you for looking into things I've mentioned! > > [...] >>> Would the above "bdf" be the PCI addressing schema? If so, then we could >>> capitalise the acronym to keep it consistent with how it's often referred >>> to in the PCI world. >>> > [...] >> got it, will change it to Bdf to keep the consistent, thanks. > > Just to make sure - the "Bus, Device, Function" in the world of PCI usually > uses the acronym of "BDF", all uppercase letters. > got it, thanks. >>> [...] >>>> +static int __init hisi_pcie_module_init(void) >>>> +{ >>>> + int ret; >>>> + >>>> + ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_HISI_PCIE_PMU_ONLINE, >>>> + "AP_PERF_ARM_HISI_PCIE_PMU_ONLINE", >>>> + hisi_pcie_pmu_online_cpu, >>>> + hisi_pcie_pmu_offline_cpu); >>>> + if (ret) { >>>> + pr_err("Failed to setup PCIe PMU hotplug, ret = %d.\n", ret); >>>> + return ret; >>>> + } >>> >>> The above error message could be made to be a little more aligned in terms >>> of format with the other messages, thus it would be as follows: >>> >>> pr_err("Failed to setup PCIe PMU hotplug: %d.\n", ret); >>> >>> Interestingly, there would be then no need to add the final dot (period) at >>> the end here, and that would be true everywhere else. >>> >> >> thanks for your reminder , I'll fix that printout message to keep align. > > Thank you! > > Don't forget to drop the trailing dot after the error code (it makes it > easier to read or even parse in a script, etc.). > will drop all the final dot in next version, thanks : ) Thanks, Qi > Again, thank you so much for working on this driver! An amazing work! > > Krzysztof > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590F8C433EF for ; Fri, 19 Nov 2021 09:08:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ECFB61A86 for ; Fri, 19 Nov 2021 09:08:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1ECFB61A86 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u2ZM0xLV0vzVIC1ywT+aEEo46CKbKKtmyh3hHpd75cs=; b=VDPdqmZCb8pjqgg1Q2AQNFFE+o bqGhWzQux4GKbrbmmO0qMElJZS66qt3L6dcKy5sDRGSHwLIoQF1cCZf2ea4pxrs5+fNubXA4O0H5q 6YTJr3G4BCcd8d3jjoXsG4Wroe7pfErEWIqoJqdN8OC2vOLdH3LyIVr2KckrXwfvnqfnc9sawop7G tv4XjYMo/Z6RePoyv56XcdjKscWVWangrNJ/o66d82iVNxJjqXhSVo8tqXGNbOS1IZjaISbbqrqe2 tFg3Us7KrnsI59Na/PtdD+vxrQnbk4NEKlDCgQNywiOZZWgLACuVTek/TrrR9pKQHJgGGFyMg6yku sXjfMusQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnzrI-009uHM-Bv; Fri, 19 Nov 2021 09:07:00 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnzrE-009uFR-1f for linux-arm-kernel@lists.infradead.org; Fri, 19 Nov 2021 09:06:57 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HwW2004LlzZdB3; Fri, 19 Nov 2021 17:04:24 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 19 Nov 2021 17:06:34 +0800 Received: from [10.67.102.185] (10.67.102.185) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Fri, 19 Nov 2021 17:06:34 +0800 Subject: Re: [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= CC: Will Deacon , Mark Rutland , "Bjorn Helgaas" , PCI , linux-arm-kernel , "Linux Kernel Mailing List" , , References: <20211029093632.4350-1-liuqi115@huawei.com> <20211029093632.4350-3-liuqi115@huawei.com> From: "liuqi (BA)" Message-ID: <65023305-f05b-cfc3-16bf-a27e2b6da87f@huawei.com> Date: Fri, 19 Nov 2021 17:06:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [10.67.102.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211119_010656_297715_7EBE5F5F X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMDIxLzExLzE5IDE1OjU1LCBLcnp5c3p0b2YgV2lsY3p5xYRza2kgd3JvdGU6Cj4gSGkg UWksCj4gCj4gVGhhbmsgeW91IGZvciBsb29raW5nIGludG8gdGhpbmdzIEkndmUgbWVudGlvbmVk IQo+IAo+IFsuLi5dCj4+PiBXb3VsZCB0aGUgYWJvdmUgImJkZiIgYmUgdGhlIFBDSSBhZGRyZXNz aW5nIHNjaGVtYT8gIElmIHNvLCB0aGVuIHdlIGNvdWxkCj4+PiBjYXBpdGFsaXNlIHRoZSBhY3Jv bnltIHRvIGtlZXAgaXQgY29uc2lzdGVudCB3aXRoIGhvdyBpdCdzIG9mdGVuIHJlZmVycmVkCj4+ PiB0byBpbiB0aGUgUENJIHdvcmxkLgo+Pj4KPiBbLi4uXQo+PiBnb3QgaXQsIHdpbGwgY2hhbmdl IGl0IHRvIEJkZiB0byBrZWVwIHRoZSBjb25zaXN0ZW50LCB0aGFua3MuCj4gCj4gSnVzdCB0byBt YWtlIHN1cmUgLSB0aGUgIkJ1cywgRGV2aWNlLCBGdW5jdGlvbiIgaW4gdGhlIHdvcmxkIG9mIFBD SSB1c3VhbGx5Cj4gdXNlcyB0aGUgYWNyb255bSBvZiAiQkRGIiwgYWxsIHVwcGVyY2FzZSBsZXR0 ZXJzLgo+IAoKZ290IGl0LCB0aGFua3MuCj4+PiBbLi4uXQo+Pj4+ICtzdGF0aWMgaW50IF9faW5p dCBoaXNpX3BjaWVfbW9kdWxlX2luaXQodm9pZCkKPj4+PiArewo+Pj4+ICsgICAgIGludCByZXQ7 Cj4+Pj4gKwo+Pj4+ICsgICAgIHJldCA9IGNwdWhwX3NldHVwX3N0YXRlX211bHRpKENQVUhQX0FQ X1BFUkZfQVJNX0hJU0lfUENJRV9QTVVfT05MSU5FLAo+Pj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJBUF9QRVJGX0FSTV9ISVNJX1BDSUVfUE1VX09OTElORSIsCj4+Pj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGlzaV9wY2llX3BtdV9vbmxpbmVf Y3B1LAo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhpc2lfcGNpZV9w bXVfb2ZmbGluZV9jcHUpOwo+Pj4+ICsgICAgIGlmIChyZXQpIHsKPj4+PiArICAgICAgICAgICAg IHByX2VycigiRmFpbGVkIHRvIHNldHVwIFBDSWUgUE1VIGhvdHBsdWcsIHJldCA9ICVkLlxuIiwg cmV0KTsKPj4+PiArICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4+Pj4gKyAgICAgfQo+Pj4KPj4+ IFRoZSBhYm92ZSBlcnJvciBtZXNzYWdlIGNvdWxkIGJlIG1hZGUgdG8gYmUgYSBsaXR0bGUgbW9y ZSBhbGlnbmVkIGluIHRlcm1zCj4+PiBvZiBmb3JtYXQgd2l0aCB0aGUgb3RoZXIgbWVzc2FnZXMs IHRodXMgaXQgd291bGQgYmUgYXMgZm9sbG93czoKPj4+Cj4+PiAgICAgcHJfZXJyKCJGYWlsZWQg dG8gc2V0dXAgUENJZSBQTVUgaG90cGx1ZzogJWQuXG4iLCByZXQpOwo+Pj4KPj4+IEludGVyZXN0 aW5nbHksIHRoZXJlIHdvdWxkIGJlIHRoZW4gbm8gbmVlZCB0byBhZGQgdGhlIGZpbmFsIGRvdCAo cGVyaW9kKSBhdAo+Pj4gdGhlIGVuZCBoZXJlLCBhbmQgdGhhdCB3b3VsZCBiZSB0cnVlIGV2ZXJ5 d2hlcmUgZWxzZS4KPj4+Cj4+Cj4+IHRoYW5rcyBmb3IgeW91ciByZW1pbmRlciAsIEknbGwgZml4 IHRoYXQgcHJpbnRvdXQgbWVzc2FnZSB0byBrZWVwIGFsaWduLgo+IAo+IFRoYW5rIHlvdSEKPiAK PiBEb24ndCBmb3JnZXQgdG8gZHJvcCB0aGUgdHJhaWxpbmcgZG90IGFmdGVyIHRoZSBlcnJvciBj b2RlIChpdCBtYWtlcyBpdAo+IGVhc2llciB0byByZWFkIG9yIGV2ZW4gcGFyc2UgaW4gYSBzY3Jp cHQsIGV0Yy4pLgo+IAoKd2lsbCBkcm9wIGFsbCB0aGUgZmluYWwgZG90IGluIG5leHQgdmVyc2lv biwgdGhhbmtzIDogKQoKVGhhbmtzLApRaQoKPiBBZ2FpbiwgdGhhbmsgeW91IHNvIG11Y2ggZm9y IHdvcmtpbmcgb24gdGhpcyBkcml2ZXIhICBBbiBhbWF6aW5nIHdvcmshCj4gCj4gCUtyenlzenRv Zgo+IC4KPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK