From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/madvise02.c: Fix ENOMEM errno tests
Date: Thu, 26 Jul 2018 03:46:12 -0400 (EDT) [thread overview]
Message-ID: <65184495.35943072.1532591172754.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1532671538-22356-1-git-send-email-yangx.jy@cn.fujitsu.com>
----- Original Message -----
> With commit 212a4b9 on some distros(e.g. RHEL6.9/7.5), running
> madvise02 got the following error:
> ------------------------------------------------------
> ...
> madvise02.c:181: CONF: MADV_UNMERGEABLE is not supported
> madvise02.c:196: FAIL: madvise succeeded unexpectedly
> madvise02.c:196: FAIL: madvise succeeded unexpectedly
> madvise02.c:181: CONF: MADV_WILLNEED is not supported
> ...
> -------------------------------------------------------
>
> If MAP_SIZE was equal to a pagesize, shared_anon may get the same
> address which was a part of file2 and already unmapped, so that the
> whole address of file2 became valid again. Subsequently, ENOMEM
> errno tests succeeded, so changing the order of mmaps to make
> shared_anon get different address.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Hi,
I changed patch to move MUNMAP() instead and added comment
explaining why.
You can review it here:
https://github.com/linux-test-project/ltp/commit/030e321ce1dfdc3a8daf7ef5a5b7bb7734cf2d9f
Thanks,
Jan
next prev parent reply other threads:[~2018-07-26 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 6:05 [LTP] [PATCH] syscalls/madvise02.c: Fix ENOMEM errno tests Xiao Yang
2018-07-26 7:46 ` Jan Stancek [this message]
2018-07-26 7:51 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65184495.35943072.1532591172754.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.