From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCC3CE7544A for ; Tue, 3 Oct 2023 11:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2fscYb36dJnCIDm/UPrsCkWl6QGsF3ygSpOB+A0PdpI=; b=TLjB2xK5HmFUH8 KkLry/gmmSSjckqAAQ3jQ0GuEcUuX/0MwnFxvfJ5OP3Z/xfKxj63CLNmVaAFGZCDp9P3zar5Fqn4N 3dNSBNUCj7sz/Pn8GXSXjUE84J4lLVbApCw/KKJ+2vPGGPlimS8vKtt481ILDW2N/85SHfY0e82dH EuPJoJTX1ZdkzFjzHu5kPhCAN1vonoZ/SnboU9+SN3oKmCCyltPzEN6PzyQL9XJiRwRIpEm4dKw6n rdDxp5QurP0YTybfG1JvdR9fpIdq3fSvZlL/ubuFjYu2vFLGerXlyoyH/2S++t+j49YMXjV22ZzDg JKmy6PMR6ig7Bz43nR5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qndQL-00EWQO-2E; Tue, 03 Oct 2023 11:18:45 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qndQI-00EWPU-09; Tue, 03 Oct 2023 11:18:43 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-405497850dbso7755445e9.0; Tue, 03 Oct 2023 04:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696331917; x=1696936717; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dRmt6j5dxjz0MCUrCJcyD2cXKQxyJFJdm8ATGNw+KGc=; b=fN6XMd0mKPKMu1Ca2PvzWPVNTLdBM++ng701nbxaoXbVL4Oh1frgOBQMFfy1VOIH4R zmxx6xcUafF0497xTdF+AKZa2W5Zcx0AGxoUzgmFExT/K7PQLIqmt1JcTXptZizbNAC8 sN7uCJ2E4xOX2ErIvZToKHIVJ/kjikiZ8Z1nN9AFjhzoCVcwIB+JKElsmcABIGR2urJG UyrbEnck7XQF6HjLUTxPz2Z2PSEkZoExez+pQv2cHnWtp377EnHCuMT7OEBJHxshk5Qb PyOMZTvhe1SKJ1NKeJKW5/ouAbifM9zIR/VHkn0ITzfWjIGczJREd5CraXZ1A48P7RMX x1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696331917; x=1696936717; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dRmt6j5dxjz0MCUrCJcyD2cXKQxyJFJdm8ATGNw+KGc=; b=haxexq+smOhbP2v/fzJeXLIqXXIUz120DLKDfcwqtg5Fp9FChsUmG09hPNQUuOUfSc ILouUWhLvcOARF3Mpg+EDnbXVXXGlZ1d40iaAfHCSLzRz5FBKeAmQJlW6eDMEc1yuNe4 mSn3/FJtxhSEBmCsI7vF1Ben195cwmHQzqYx3kyxKJ75Ur6Ns+7q4xUMSDyIp2NAaGbU 1Erg+0lta7eTSwC0N15Uq3Wl1ZjPt7RCfdrPZGbWTvndJG5cL8WY+VMJjsKkYI6WXS/a xm7Jv3kl+wcYhQgJP51CqSJpQXevgvlOHsj6yoP0eiS8Plbb57uph4nI1tRg14Z/4Yi5 vLfg== X-Gm-Message-State: AOJu0Yw6IhUPK/a3Fa+3iKsgcFtKmbPyyXhjBRsBd8TU5qeC0l61fYUa 63Br04lKi6ercswy9f7NuJ0= X-Google-Smtp-Source: AGHT+IFLbiLzMIjYq17N9d6C9xhiAG+ijgYatVYbYzZACplv9aboPtXUhqao5fQwPpvl9QyVVVJ1HA== X-Received: by 2002:a7b:ce89:0:b0:402:f07c:4b48 with SMTP id q9-20020a7bce89000000b00402f07c4b48mr11269565wmj.28.1696331917146; Tue, 03 Oct 2023 04:18:37 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id y24-20020a05600c365800b0040652e8ca13sm9195716wmq.43.2023.10.03.04.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 04:18:36 -0700 (PDT) Message-ID: <651bf88c.050a0220.3a982.31fc@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 3 Oct 2023 13:18:33 +0200 From: Christian Marangi To: Marc Kleine-Budde Cc: Jason Gunthorpe , Leon Romanovsky , Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chris Snook , Raju Rangoju , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Douglas Miller , Nick Child , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Haren Myneni , Rick Lindsley , Dany Madden , Thomas Falcon , Tariq Toukan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Krzysztof Halasa , Kalle Valo , Jeff Johnson , Gregory Greenman , Chandrashekar Devegowda , Intel Corporation , Chiranjeevi Rapolu , Liu Haijun , M Chetan Kumar , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg , Yuanjun Gong , Wei Fang , Alex Elder , Simon Horman , Rob Herring , Bailey Forrest , "Gustavo A. R. Silva" , Junfeng Guo , Ziwei Xiao , Thomas Gleixner , Rushil Gupta , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Yuri Karpov , Zhengchao Shao , Andrew Lunn , Zheng Zengkai , "Rafael J. Wysocki" , Lee Jones , Dawei Li , Hans de Goede , Benjamin Berg , Anjaneyulu , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule References: <20231002151023.4054-1-ansuelsmth@gmail.com> <20231002151023.4054-3-ansuelsmth@gmail.com> <20231003-living-seltzer-172ea6aec629-mkl@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231003-living-seltzer-172ea6aec629-mkl@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_041842_090294_91620349 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On Tue, Oct 03, 2023 at 09:16:33AM +0200, Marc Kleine-Budde wrote: > On 02.10.2023 17:10:22, Christian Marangi wrote: > > Now that napi_schedule return a bool, we can drop napi_reschedule that > > does the same exact function. The function comes from a very old commit > > bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct > > net_device") and the purpose is actually deprecated in favour of > > different logic. > > > > Convert every user of napi_reschedule to napi_schedule. > > > > Signed-off-by: Christian Marangi > > --- > > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 ++-- > > drivers/net/can/dev/rx-offload.c | 2 +- > > Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c Just to make sure can I use the correct tag: (you didn't include the mail) Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c ? -- Ansuel _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744BFE7544B for ; Tue, 3 Oct 2023 11:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbjJCLSv (ORCPT ); Tue, 3 Oct 2023 07:18:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239986AbjJCLSu (ORCPT ); Tue, 3 Oct 2023 07:18:50 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33CB9BB; Tue, 3 Oct 2023 04:18:39 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40566f8a093so7475905e9.3; Tue, 03 Oct 2023 04:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696331917; x=1696936717; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dRmt6j5dxjz0MCUrCJcyD2cXKQxyJFJdm8ATGNw+KGc=; b=XzeQcODl+S0VoX5SHWpA+1Vy+J0EfHQgYFF4wHCFJseWYhVH6qEK29CY9KFGrEzPjN MGKiSrLdgE7kLC97WI3EGNbeHUw6kVmIZ9X38gZuiN6j4MaJzA2Emm2Fzeo33ngodS1N WNr8jbRY2cXpqsZa/pUyFN7dBClcN1c7Y9SeAMMTz8ozcbryByWVH1LwcuCxN97ri5uQ B5zY48CmpkJ5S4Vf9zLqc8vO76Ock9kcn0jqfU4lx17h/eCaOMjRozu70uXcMMhNrwWP /ZeqtOvmBFrwt2Ulg8lBsMQa1tOQcgkWP9jmpgKtRcztp9xnpE8zCsrmfug31HAhU6BL J8MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696331917; x=1696936717; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dRmt6j5dxjz0MCUrCJcyD2cXKQxyJFJdm8ATGNw+KGc=; b=a9Ls4+Rmk6QWdPBo1Zbm3RxZ1Dvny43CmZSJvHpi8zmVfd7iA2Oa93EpmjS5eQaeNV VJyg5Ps3O1lASUce82bfJM0EluQa/DQG7axyEUvEt19CehAYdK8PomsiNSNlEdI6zu7W 15iNR0R29gFcJkc7k8NeP7x6COaEWxaFpHl+jXwf0uOt3PoM5YT+WSS2JN4cmOWhVFQF 8W4rccLOedregl31F1bvqH9DV/MneqxSRA7J6ByR0sebzkmf4W8OS7rNtJpxk+tPznCH vwTYZp+KNdD9Ws4sHm6TJgPYY/moJ8bCyDr4wZDYVmJSjTREkrT4HMwJuodccOsrxg1I ppWw== X-Gm-Message-State: AOJu0Yz6GZwRoawJH/fa8LBS3FLZCnulP0bCZlb7o2yv3Y1wJw93f2tk CAdIADeZUryISqxojprQMB0= X-Google-Smtp-Source: AGHT+IFLbiLzMIjYq17N9d6C9xhiAG+ijgYatVYbYzZACplv9aboPtXUhqao5fQwPpvl9QyVVVJ1HA== X-Received: by 2002:a7b:ce89:0:b0:402:f07c:4b48 with SMTP id q9-20020a7bce89000000b00402f07c4b48mr11269565wmj.28.1696331917146; Tue, 03 Oct 2023 04:18:37 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id y24-20020a05600c365800b0040652e8ca13sm9195716wmq.43.2023.10.03.04.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 04:18:36 -0700 (PDT) Message-ID: <651bf88c.050a0220.3a982.31fc@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 3 Oct 2023 13:18:33 +0200 From: Christian Marangi To: Marc Kleine-Budde Cc: Jason Gunthorpe , Leon Romanovsky , Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chris Snook , Raju Rangoju , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Douglas Miller , Nick Child , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Haren Myneni , Rick Lindsley , Dany Madden , Thomas Falcon , Tariq Toukan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Krzysztof Halasa , Kalle Valo , Jeff Johnson , Gregory Greenman , Chandrashekar Devegowda , Intel Corporation , Chiranjeevi Rapolu , Liu Haijun , M Chetan Kumar , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg , Yuanjun Gong , Wei Fang , Alex Elder , Simon Horman , Rob Herring , Bailey Forrest , "Gustavo A. R. Silva" , Junfeng Guo , Ziwei Xiao , Thomas Gleixner , Rushil Gupta , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Yuri Karpov , Zhengchao Shao , Andrew Lunn , Zheng Zengkai , "Rafael J. Wysocki" , Lee Jones , Dawei Li , Hans de Goede , Benjamin Berg , Anjaneyulu , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule References: <20231002151023.4054-1-ansuelsmth@gmail.com> <20231002151023.4054-3-ansuelsmth@gmail.com> <20231003-living-seltzer-172ea6aec629-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231003-living-seltzer-172ea6aec629-mkl@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Tue, Oct 03, 2023 at 09:16:33AM +0200, Marc Kleine-Budde wrote: > On 02.10.2023 17:10:22, Christian Marangi wrote: > > Now that napi_schedule return a bool, we can drop napi_reschedule that > > does the same exact function. The function comes from a very old commit > > bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct > > net_device") and the purpose is actually deprecated in favour of > > different logic. > > > > Convert every user of napi_reschedule to napi_schedule. > > > > Signed-off-by: Christian Marangi > > --- > > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 ++-- > > drivers/net/can/dev/rx-offload.c | 2 +- > > Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c Just to make sure can I use the correct tag: (you didn't include the mail) Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c ? -- Ansuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 157B1E75459 for ; Tue, 3 Oct 2023 18:34:33 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=G4p7ZSrQ; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S0RLb5bJfz3cVd for ; Wed, 4 Oct 2023 05:34:31 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=G4p7ZSrQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::331; helo=mail-wm1-x331.google.com; envelope-from=ansuelsmth@gmail.com; receiver=lists.ozlabs.org) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S0Fgl2Bv4z2ysB for ; Tue, 3 Oct 2023 22:18:41 +1100 (AEDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40566f8a093so7475875e9.3 for ; Tue, 03 Oct 2023 04:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696331917; x=1696936717; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=dRmt6j5dxjz0MCUrCJcyD2cXKQxyJFJdm8ATGNw+KGc=; b=G4p7ZSrQYLxb5Ps2VBvu83M6m441EVxQiebrcM9+b5SnfNskie6afsIqiFQ4a/QpbJ 8KTmcs7TwvXXDPw8ojnCCU/TOsnEoPycUc6EhjzWl5QuaK5nNILshFCTJD5Pfj4B0dQ+ RIYzU50vHohym9rd1iG7JAQLQlWW3FbvJ9OdbRyDmZsrKmWi0siT8/2BGypLCDclq0l1 Ak72TrNj3O5FVOCnVffuBAi1eGFpwbn9ZxJFSKeqVisOk/DX+tppcY6GRzEMOdFGEEAy sJgCUDE4Vm3QKZArIbdKUjRC31pR4L5h1iQ3UuJwhHOYQ8nnLfYVTsiKCaerxMp0ZoqO noLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696331917; x=1696936717; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dRmt6j5dxjz0MCUrCJcyD2cXKQxyJFJdm8ATGNw+KGc=; b=SKdQobWiLkN2mqYjYMUART+AKbj+FuLw7mmOAe0nkD8a5QQpETlcRTWIDBzsMnLyPy 1m8sAXJaRN11JI7sxUcbe0a8S0hiI/lq04fVHps9P/iJpHSMva/oZavIS2SZ3sN7L/uF xovDIHGXEFgwt1/16Ks2gHV+9Wux24ysiV8po+1Qh0K4Pm6rwByH9r73MvvXT8AmLpMo jCe54/9UWVoEfQt0I12jYzFpzSxYw94F2KRksJSP2pliRmKteCNl3zwUEXhqlmw+fw5d Endamzy76BuJmsYuI5GNonzBcIQwuJTnO1L5YRwu7K2z1X/NDaHwJGKSU5dr73Y0YOJo sEgw== X-Gm-Message-State: AOJu0YypO3u0BxGFf9KcAZsjqW9rCgV0Bc8y83EIzd6q46Y8SGJKfGOe VnLtTxZ0e4PYrBP74wEWSDA= X-Google-Smtp-Source: AGHT+IFLbiLzMIjYq17N9d6C9xhiAG+ijgYatVYbYzZACplv9aboPtXUhqao5fQwPpvl9QyVVVJ1HA== X-Received: by 2002:a7b:ce89:0:b0:402:f07c:4b48 with SMTP id q9-20020a7bce89000000b00402f07c4b48mr11269565wmj.28.1696331917146; Tue, 03 Oct 2023 04:18:37 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id y24-20020a05600c365800b0040652e8ca13sm9195716wmq.43.2023.10.03.04.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 04:18:36 -0700 (PDT) Message-ID: <651bf88c.050a0220.3a982.31fc@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 3 Oct 2023 13:18:33 +0200 From: Christian Marangi To: Marc Kleine-Budde Subject: Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule References: <20231002151023.4054-1-ansuelsmth@gmail.com> <20231002151023.4054-3-ansuelsmth@gmail.com> <20231003-living-seltzer-172ea6aec629-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231003-living-seltzer-172ea6aec629-mkl@pengutronix.de> X-Mailman-Approved-At: Wed, 04 Oct 2023 05:32:24 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sergey Ryazanov , Ziwei Xiao , Chris Snook , Rick Lindsley , Alexandre Torgue , linux-kernel@vger.kernel.org, Eric Dumazet , Lee Jones , Dany Madden , Gregory Greenman , Zhengchao Shao , Chiranjeevi Rapolu , Dawei Li , Intel Corporation , Rob Herring , Jeroen de Borst , Leon Romanovsky , linux-rdma@vger.kernel.org, "Rafael J. Wysocki" , Haren Myneni , linux-stm32@st-md-mailman.stormreply.com, Rushil Gupta , Jason Gunthorpe , Thomas Falcon , Jose Abreu , Alex Elder , linux-wireless@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Wei Fang , Wolfgang Grandegger , Nick Child , Simon Horman , Liu Haijun , Kalle Valo , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Bailey Forrest , Nicholas Piggin , linux-can@vger.kernel.org, Hans de Goede , Yuanjun Gong , Shailend Chand , Krzysztof Halasa , Benjamin Berg , M Chetan Kumar , Thomas Gleixner , Yuri Karpov , linux-arm-kernel@lists.infradead.org, Chandrashekar Devegowda , Ricardo Martinez , Loic Poulain , Zheng Zengkai , netdev@vger.kernel.org, Anjaneyulu , linuxppc-dev@lists.ozlabs.org, Douglas Miller , "Gustavo A. R. Silva" , Tariq Toukan , Junfeng Guo , Maxime Coquelin , Raju Rangoju , Praveen Kaligineedi , Johannes Berg , ath10k@lists.infradead.org, Jeff Johnson , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Oct 03, 2023 at 09:16:33AM +0200, Marc Kleine-Budde wrote: > On 02.10.2023 17:10:22, Christian Marangi wrote: > > Now that napi_schedule return a bool, we can drop napi_reschedule that > > does the same exact function. The function comes from a very old commit > > bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct > > net_device") and the purpose is actually deprecated in favour of > > different logic. > > > > Convert every user of napi_reschedule to napi_schedule. > > > > Signed-off-by: Christian Marangi > > --- > > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 ++-- > > drivers/net/can/dev/rx-offload.c | 2 +- > > Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c Just to make sure can I use the correct tag: (you didn't include the mail) Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c ? -- Ansuel