From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAAADE95A67 for ; Sun, 8 Oct 2023 18:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ms+MSTd5TEoE794wQkbvfcM9afdvJsGCvnyAd3m81LE=; b=d0p1tige6dG8J4 TMZoRDoztyLq06Fc3AMzKSGf3ZgV6aMtDJpZ77cf5pjL/JC+JbpXn0pogh3n6//JZFzAHB07J7o60 Zt7AtqIluqXLi8TYYDAth8FkELdxK32Jc0/I7GB12pAcOrVsTFsVUjkAiD6D8h6x1cFcMc2kFo4qQ lFJ1DXSD+i1z6Jd9+m7jsePehivBw8x9aAXDEWK2nH2R6/IadoNZt33tNwUUdP16ia8aerrHj1ino pDz3lFVSiXdku+s1FxH+K3SOTj69gO1CzmKLgo5WDkLPsGG8Dy/76F2AXl08Gr193+H5TGu0KAtu9 2yO89xTDMMcb3NSEyn6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qpYVC-00973u-2N; Sun, 08 Oct 2023 18:27:42 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qpYV7-00973R-2c; Sun, 08 Oct 2023 18:27:39 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-32615eaa312so3499022f8f.2; Sun, 08 Oct 2023 11:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696789654; x=1697394454; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=UYhUlM0v/kiBnSA7qqkERNTe3ha0hd9wd9BeXsJuFRo=; b=d0tpI4p66kOFPpuzsqtCm3JNd71xtYI5aOjOSAQ5ODrgNhW1uVy7FjWvexnE/Dn9Br xgm4yqNUQxJwrI2EEBLSPW/0W9ru2P6NNQYGpibLbDilYC/DYeDGdXzFdpgRwPEgd1PS utATvCRbazCoqqeZxH27G+iaJGNGrVuj5IvE4qPsXdZuMEKXXkfVNaGRxhl4J0RpdQ6m Q3oai4hxdsZctQtKmauOTyZ0+8uM61C1WSLBXYW4znfNu5Jn6+9tzWSRnnyhnN7li0mF H3mSVLMFB2vXEPATzxfKsxax2tj036oBTgcpILNRm+lJMnhl1pz8yF+kuWrwnlFqTPUa 2CaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696789654; x=1697394454; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UYhUlM0v/kiBnSA7qqkERNTe3ha0hd9wd9BeXsJuFRo=; b=OyL3p6b0fErJx+T3RA2xA2x/tveIJtLMDpECC30T3GR1DWVW6LFI+27Es1lQ5bDfo7 HY01Z6U0zQKPLVykMDYb54oJ8k9i7ek8RJ/WU4bXYFxCzWYCAmisfSMRJMpjKJy4FyCO ejcHEC+9F8T8Ncl816qiwAF5gJ4qDOcnpUloZMhDP7ZAWe2dELSBo9guF096CSe9e2zG P5bJBUoWfZ9T6M7g1HHHpR3fTR/aO8+FC9APN8c2I+Ra5bKOk0szGoCuD4S3w/+2MhLU /QxsxWc16C7fFFZZhJ+QceBQq+LAx2+Csp1a9/TeX1XGMXBmmQzJjiWcH3v1lugC3EUE 4zGQ== X-Gm-Message-State: AOJu0Yw1x6lE7bJD5rpy3ryl6ONzou/EZ2sFdFIc2LXkQeDztRZNtX08 iV3WAcrN9q6HLadmzJM6Xlc= X-Google-Smtp-Source: AGHT+IG1Z2UQG/8uimtzwOsX0SSnSzQeAnFClPvayUdx2bESkKFHKQw9/TSlsvhrREuwaEcXQ8SiYA== X-Received: by 2002:a5d:50c8:0:b0:316:f24b:597a with SMTP id f8-20020a5d50c8000000b00316f24b597amr11755917wrt.46.1696789653876; Sun, 08 Oct 2023 11:27:33 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id j14-20020adff54e000000b003233a31a467sm7413627wrp.34.2023.10.08.11.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 11:27:33 -0700 (PDT) Message-ID: <6522f495.df0a0220.326ed.de6c@mx.google.com> X-Google-Original-Message-ID: Date: Sun, 8 Oct 2023 20:27:28 +0200 From: Christian Marangi To: Eric Dumazet Cc: Jason Gunthorpe , Leon Romanovsky , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Chris Snook , Raju Rangoju , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Douglas Miller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nick Child , Haren Myneni , Rick Lindsley , Dany Madden , Thomas Falcon , Tariq Toukan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Krzysztof Halasa , Kalle Valo , Jeff Johnson , Gregory Greenman , Chandrashekar Devegowda , Intel Corporation , Chiranjeevi Rapolu , Liu Haijun , M Chetan Kumar , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg , Yuanjun Gong , Simon Horman , Rob Herring , Ziwei Xiao , Rushil Gupta , Coco Li , Thomas Gleixner , Junfeng Guo , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wei Fang , Krzysztof Kozlowski , Yuri Karpov , Zhengchao Shao , Andrew Lunn , Zheng Zengkai , Lee Jones , Maximilian Luz , "Rafael J. Wysocki" , Dawei Li , Anjaneyulu , Benjamin Berg , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [net-next PATCH v2 4/4] netdev: use napi_schedule bool instead of napi_schedule_prep/__napi_schedule References: <20231003145150.2498-1-ansuelsmth@gmail.com> <20231003145150.2498-4-ansuelsmth@gmail.com> <652056c5.5d0a0220.2b60d.c5dc@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231008_112737_876133_1177BD68 X-CRM114-Status: GOOD ( 36.63 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org T24gU3VuLCBPY3QgMDgsIDIwMjMgYXQgMDk6MDg6NDFBTSArMDIwMCwgRXJpYyBEdW1hemV0IHdy b3RlOgo+IE9uIEZyaSwgT2N0IDYsIDIwMjMgYXQgODo0OeKAr1BNIENocmlzdGlhbiBNYXJhbmdp IDxhbnN1ZWxzbXRoQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4gT24gVGh1LCBPY3QgMDUsIDIw MjMgYXQgMDY6MTY6MjZQTSArMDIwMCwgRXJpYyBEdW1hemV0IHdyb3RlOgo+ID4gPiBPbiBUdWUs IE9jdCAzLCAyMDIzIGF0IDg6MzbigK9QTSBDaHJpc3RpYW4gTWFyYW5naSA8YW5zdWVsc210aEBn bWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+Cj4gPiA+ID4gUmVwbGFjZSBpZiBjb25kaXRpb24gb2Yg bmFwaV9zY2hlZHVsZV9wcmVwL19fbmFwaV9zY2hlZHVsZSBhbmQgdXNlIGJvb2wKPiA+ID4gPiBm cm9tIG5hcGlfc2NoZWR1bGUgZGlyZWN0bHkgd2hlcmUgcG9zc2libGUuCj4gPiA+ID4KPiA+ID4g PiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gTWFyYW5naSA8YW5zdWVsc210aEBnbWFpbC5jb20+ Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvbmV0L2V0aGVybmV0L2F0aGVyb3MvYXRseC9h dGwxLmMgICAgIHwgNCArLS0tCj4gPiA+ID4gIGRyaXZlcnMvbmV0L2V0aGVybmV0L3Rvc2hpYmEv dGMzNTgxNS5jICAgICAgIHwgNCArLS0tCj4gPiA+ID4gIGRyaXZlcnMvbmV0L3dpcmVsZXNzL2lu dGVsL2l3bHdpZmkvcGNpZS9yeC5jIHwgNCArLS0tCj4gPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwg MyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+ID4gPiA+Cj4gPiA+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2F0aGVyb3MvYXRseC9hdGwxLmMgYi9kcml2ZXJzL25l dC9ldGhlcm5ldC9hdGhlcm9zL2F0bHgvYXRsMS5jCj4gPiA+ID4gaW5kZXggMDJhYTZmZDhlYmMy Li5hOTAxNGQ3OTMyZGIgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQv YXRoZXJvcy9hdGx4L2F0bDEuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2F0 aGVyb3MvYXRseC9hdGwxLmMKPiA+ID4gPiBAQCAtMjQ0Niw3ICsyNDQ2LDcgQEAgc3RhdGljIGlu dCBhdGwxX3JpbmdzX2NsZWFuKHN0cnVjdCBuYXBpX3N0cnVjdCAqbmFwaSwgaW50IGJ1ZGdldCkK PiA+ID4gPgo+ID4gPiA+ICBzdGF0aWMgaW5saW5lIGludCBhdGwxX3NjaGVkX3JpbmdzX2NsZWFu KHN0cnVjdCBhdGwxX2FkYXB0ZXIqIGFkYXB0ZXIpCj4gPiA+ID4gIHsKPiA+ID4gPiAtICAgICAg IGlmICghbmFwaV9zY2hlZHVsZV9wcmVwKCZhZGFwdGVyLT5uYXBpKSkKPiA+ID4gPiArICAgICAg IGlmICghbmFwaV9zY2hlZHVsZSgmYWRhcHRlci0+bmFwaSkpCj4gPiA+ID4gICAgICAgICAgICAg ICAgIC8qIEl0IGlzIHBvc3NpYmxlIGluIGNhc2UgZXZlbiB0aGUgUlgvVFggaW50cyBhcmUgZGlz YWJsZWQgdmlhIElNUgo+ID4gPiA+ICAgICAgICAgICAgICAgICAgKiByZWdpc3RlciB0aGUgSVNS IGJpdHMgYXJlIHNldCBhbnl3YXkgKGJ1dCBkbyBub3QgcHJvZHVjZSBJUlEpLgo+ID4gPiA+ICAg ICAgICAgICAgICAgICAgKiBUbyBoYW5kbGUgc3VjaCBzaXR1YXRpb24gdGhlIG5hcGkgZnVuY3Rp b25zIHVzZWQgdG8gY2hlY2sgaXMKPiA+ID4gPiBAQCAtMjQ1NCw4ICsyNDU0LDYgQEAgc3RhdGlj IGlubGluZSBpbnQgYXRsMV9zY2hlZF9yaW5nc19jbGVhbihzdHJ1Y3QgYXRsMV9hZGFwdGVyKiBh ZGFwdGVyKQo+ID4gPiA+ICAgICAgICAgICAgICAgICAgKi8KPiA+ID4gPiAgICAgICAgICAgICAg ICAgcmV0dXJuIDA7Cj4gPiA+ID4KPiA+ID4gPiAtICAgICAgIF9fbmFwaV9zY2hlZHVsZSgmYWRh cHRlci0+bmFwaSk7Cj4gPiA+ID4gLQo+ID4gPiA+ICAgICAgICAgLyoKPiA+ID4gPiAgICAgICAg ICAqIERpc2FibGUgUlgvVFggaW50cyB2aWEgSU1SIHJlZ2lzdGVyIGlmIGl0IGlzCj4gPiA+ID4g ICAgICAgICAgKiBhbGxvd2VkLiBOQVBJIGhhbmRsZXIgbXVzdCByZWVuYWJsZSB0aGVtIGluIHNh bWUKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvdG9zaGliYS90YzM1 ODE1LmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC90b3NoaWJhL3RjMzU4MTUuYwo+ID4gPiA+IGlu ZGV4IDE0Y2Y2ZWNmNmQwZC4uYThiOGEwZTEzZjlhIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZl cnMvbmV0L2V0aGVybmV0L3Rvc2hpYmEvdGMzNTgxNS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9u ZXQvZXRoZXJuZXQvdG9zaGliYS90YzM1ODE1LmMKPiA+ID4gPiBAQCAtMTQzNiw5ICsxNDM2LDcg QEAgc3RhdGljIGlycXJldHVybl90IHRjMzU4MTVfaW50ZXJydXB0KGludCBpcnEsIHZvaWQgKmRl dl9pZCkKPiA+ID4gPiAgICAgICAgIGlmICghKGRtYWN0bCAmIERNQV9JbnRNYXNrKSkgewo+ID4g PiA+ICAgICAgICAgICAgICAgICAvKiBkaXNhYmxlIGludGVycnVwdHMgKi8KPiA+ID4gPiAgICAg ICAgICAgICAgICAgdGNfd3JpdGVsKGRtYWN0bCB8IERNQV9JbnRNYXNrLCAmdHItPkRNQV9DdGwp Owo+ID4gPiA+IC0gICAgICAgICAgICAgICBpZiAobmFwaV9zY2hlZHVsZV9wcmVwKCZscC0+bmFw aSkpCj4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgX19uYXBpX3NjaGVkdWxlKCZscC0+ bmFwaSk7Cj4gPiA+ID4gLSAgICAgICAgICAgICAgIGVsc2Ugewo+ID4gPiA+ICsgICAgICAgICAg ICAgICBpZiAoIW5hcGlfc2NoZWR1bGUoJmxwLT5uYXBpKSkgewo+ID4gPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgIHByaW50ayhLRVJOX0VSUiAiJXM6IGludGVycnVwdCB0YWtlbiBpbiBwb2xs XG4iLAo+ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXYtPm5hbWUpOwo+ ID4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgIEJVRygpOwo+ID4gPgo+ID4gPiBIbW1tLi4u IGNvdWxkIHlvdSBhbHNvIHJlbW92ZSB0aGlzIEJVRygpID8gSSB0aGluayB0aGlzIGNvZGUgcGF0 aCBjYW4gYmUgdGFrZW4KPiA+ID4gaWYgc29tZSBhcHBsaWNhdGlvbnMgYXJlIHVzaW5nIGJ1c3kg cG9sbGluZy4KPiA+ID4KPiA+ID4gT3Igc2ltcGx5IHJld3JpdGUgdGhpcyB3aXRoIHRoZSB0cmFk aXRpb25hbAo+ID4gPgo+ID4gPiBpZiAobmFwaV9zY2hlZHVsZV9wcmVwKCZscC0+bmFwaSkpIHsK PiA+ID4gICAgLyogZGlzYWJsZSBpbnRlcnJ1cHRzICovCj4gPiA+ICAgIHRjX3dyaXRlbChkbWFj dGwgfCBETUFfSW50TWFzaywgJnRyLT5ETUFfQ3RsKTsKPiA+ID4gICAgIF9fbmFwaV9zY2hlZHVs ZSgmbHAtPm5hcGkpOwo+ID4gPiB9Cj4gPiA+Cj4gPiA+Cj4gPgo+ID4gTWhoaCBpcyBpdCBzYWZl IHRvIGRvIHNvPyBJIG1lYW4gaXQgc2VlbXMgdmVyeSB3cm9uZyB0byBwcmludCBhIHdhcm5pbmcK PiA+IGFuZCBCVUcoKSBpbnN0ZWFkIG9mIGRpc2FibGluZyB0aGUgaW50ZXJydXB0IG9ubHkgaWYg bmFwaSBjYW4gYmUKPiA+IHNjaGVkdWxlZC4uLiBNYXliZSBpcyB2ZXJ5IG9sZCBjb2RlPyBUaGUg bW9yZSBJIHNlZSB0aGlzIHRoZSBtb3JlIEkgc2VlCj4gPiBwcm9ibGVtLi4uIChyYW5kb21seSBk aXNhYmxpbmcgdGhlIGludGVycnVwdCBhbmQgdGhlbiBtYWtlIHRoZSBrZXJuZWwKPiA+IGRpZSkK PiAKPiBJIGFtIHByZXR0eSBzdXJlIHRoaXMgQlVHKCkgY2FuIGJlIGhpdCB0aGVzZSBkYXlzIHdp dGggYnVzeSBwb2xsaW5nIG9yCj4gc2V0dGluZyBncm9fZmx1c2hfdGltZW91dC4KPiAKPiBJIHdp c2ggd2UgY291bGQgcmVtb3ZlIHRoZXNlIGJ1Z3MgYmVmb3JlIHNvbWVvbmUgY29weS1wYXN0ZSB0 aGVtLgo+IAo+IEFnYWluLCB0aGlzIGlzIG9ydGhvZ29uYWwsIEkgbWlnaHQgc2ltcGx5IHN0b3Ag ZG9pbmcgcmV2aWV3cyBpZiB0aGlzCj4gaXMgbm90IHVzZWZ1bC4KClRoZXkgYXJlIHZlcnkgdXNl ZnVsIGFuZCB0aGFua3MgYSBsb3QgZm9yIHRoZW0hIEknbSBhc2tpbmcgdGhlc2UgYXMgdG8KdW5k ZXJzdGFuZCBob3cgdG8gcHJvY2VlZC4gSSBoYXZlIGluIHF1ZXVlIDIgb3RoZXIgc2VyaWVzIHRo YXQgZGVwZW5kcwpvbiB0aGlzIGFuZCBJJ20ganVzdCBhc2tpbmcgaW5mbyBvbiBob3cgdG8gc3Bl ZWR1cCB0aGUgcHJvZ3Jlc3Mgb24gdGhpcyEKClNvbyB0aGluayBJIGhhdmUgdG8gc2VuZCB2MyB3 aXRoIHRoZSBzdWdnZXN0ZWQgY2hhbmdlIGFuZCBCVUcoKSBkcm9wcGVkPwpIYXBweSB0byBkbyBl dmVyeXRoaW5nIHRvIGZpeCBhbmQgaW1wcm92ZSB0aGlzIHNlcmllcyEKCi0tIAoJQW5zdWVsCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFp bGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9577BE95A8E for ; Sun, 8 Oct 2023 18:27:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344400AbjJHS1j (ORCPT ); Sun, 8 Oct 2023 14:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbjJHS1i (ORCPT ); Sun, 8 Oct 2023 14:27:38 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F27A3; Sun, 8 Oct 2023 11:27:37 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3247cefa13aso3504021f8f.1; Sun, 08 Oct 2023 11:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696789654; x=1697394454; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=UYhUlM0v/kiBnSA7qqkERNTe3ha0hd9wd9BeXsJuFRo=; b=JSwbmiZCaHGFO9Si6aH78Qhj9fM1wPHsOC6QWVJSzNk857ic9djFm1+pqpk7pKGGxp WK3OroWhyW83kshoTJkBSqAM1tR+Ha3SNMtzTkzxy1+isDHg9DCb4sfzdO7iJyuJ4vM6 GR2qEFcddyvF98b18yVubStOuYHQp2n0ihk/bQA6RkeUJIo/sveVPblAg0ZN09hsaqyM dG01SXARf3kz3CV69rmGyz7YMWvRliAwYR/MGwfFklyf+gu5FEFUxCYFM2/q+RPlmJX4 C/c22d/ojpo4+0PIJCZW8bq3aphc45v1g8lUjODL6QBp1vFVIxeZE+lgJLSKmsTX/Dxg 6ODw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696789654; x=1697394454; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UYhUlM0v/kiBnSA7qqkERNTe3ha0hd9wd9BeXsJuFRo=; b=WASWiYr5sredpi3vQS1/AmmtvabMd5lZPwX3X+pCdWlas685T/aeukaJTe1NBGjjqz yuK6Iw2W7tN+r/cVUcjwQw31/MyXl3wenZx4YAPUCy+MAKfhLRDgyuxFq6HyWX6LIEwb jbUsN0YI1cMDojNxa5lcHfk0KOYMsXapjwuyyLGGr+7d/vHsOxPuLsSNtvJzadipK0oF JmRSDYPsRYPG6yY9cdsx2i8Wags3/yNj5YNy8ouRDYcYfkoDjcGNLr/kkh162swm0Wgx V7bu4qs8hVWpaCKKoa+XPhamUDwni8IBhWk974uao9Y0P06vjHmuRPgZsWwYXaSz2fe0 onUA== X-Gm-Message-State: AOJu0Yy9/hL3kn78PiCc3H19pEopZxmLbFnorDbRsO6fcEN9Unjx4ePY xE3KXStg9Tfq9CbOTiQz4k4= X-Google-Smtp-Source: AGHT+IG1Z2UQG/8uimtzwOsX0SSnSzQeAnFClPvayUdx2bESkKFHKQw9/TSlsvhrREuwaEcXQ8SiYA== X-Received: by 2002:a5d:50c8:0:b0:316:f24b:597a with SMTP id f8-20020a5d50c8000000b00316f24b597amr11755917wrt.46.1696789653876; Sun, 08 Oct 2023 11:27:33 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id j14-20020adff54e000000b003233a31a467sm7413627wrp.34.2023.10.08.11.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 11:27:33 -0700 (PDT) Message-ID: <6522f495.df0a0220.326ed.de6c@mx.google.com> X-Google-Original-Message-ID: Date: Sun, 8 Oct 2023 20:27:28 +0200 From: Christian Marangi To: Eric Dumazet Cc: Jason Gunthorpe , Leon Romanovsky , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Chris Snook , Raju Rangoju , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Douglas Miller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nick Child , Haren Myneni , Rick Lindsley , Dany Madden , Thomas Falcon , Tariq Toukan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Krzysztof Halasa , Kalle Valo , Jeff Johnson , Gregory Greenman , Chandrashekar Devegowda , Intel Corporation , Chiranjeevi Rapolu , Liu Haijun , M Chetan Kumar , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg , Yuanjun Gong , Simon Horman , Rob Herring , Ziwei Xiao , Rushil Gupta , Coco Li , Thomas Gleixner , Junfeng Guo , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wei Fang , Krzysztof Kozlowski , Yuri Karpov , Zhengchao Shao , Andrew Lunn , Zheng Zengkai , Lee Jones , Maximilian Luz , "Rafael J. Wysocki" , Dawei Li , Anjaneyulu , Benjamin Berg , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [net-next PATCH v2 4/4] netdev: use napi_schedule bool instead of napi_schedule_prep/__napi_schedule References: <20231003145150.2498-1-ansuelsmth@gmail.com> <20231003145150.2498-4-ansuelsmth@gmail.com> <652056c5.5d0a0220.2b60d.c5dc@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Sun, Oct 08, 2023 at 09:08:41AM +0200, Eric Dumazet wrote: > On Fri, Oct 6, 2023 at 8:49 PM Christian Marangi wrote: > > > > On Thu, Oct 05, 2023 at 06:16:26PM +0200, Eric Dumazet wrote: > > > On Tue, Oct 3, 2023 at 8:36 PM Christian Marangi wrote: > > > > > > > > Replace if condition of napi_schedule_prep/__napi_schedule and use bool > > > > from napi_schedule directly where possible. > > > > > > > > Signed-off-by: Christian Marangi > > > > --- > > > > drivers/net/ethernet/atheros/atlx/atl1.c | 4 +--- > > > > drivers/net/ethernet/toshiba/tc35815.c | 4 +--- > > > > drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 4 +--- > > > > 3 files changed, 3 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c > > > > index 02aa6fd8ebc2..a9014d7932db 100644 > > > > --- a/drivers/net/ethernet/atheros/atlx/atl1.c > > > > +++ b/drivers/net/ethernet/atheros/atlx/atl1.c > > > > @@ -2446,7 +2446,7 @@ static int atl1_rings_clean(struct napi_struct *napi, int budget) > > > > > > > > static inline int atl1_sched_rings_clean(struct atl1_adapter* adapter) > > > > { > > > > - if (!napi_schedule_prep(&adapter->napi)) > > > > + if (!napi_schedule(&adapter->napi)) > > > > /* It is possible in case even the RX/TX ints are disabled via IMR > > > > * register the ISR bits are set anyway (but do not produce IRQ). > > > > * To handle such situation the napi functions used to check is > > > > @@ -2454,8 +2454,6 @@ static inline int atl1_sched_rings_clean(struct atl1_adapter* adapter) > > > > */ > > > > return 0; > > > > > > > > - __napi_schedule(&adapter->napi); > > > > - > > > > /* > > > > * Disable RX/TX ints via IMR register if it is > > > > * allowed. NAPI handler must reenable them in same > > > > diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c > > > > index 14cf6ecf6d0d..a8b8a0e13f9a 100644 > > > > --- a/drivers/net/ethernet/toshiba/tc35815.c > > > > +++ b/drivers/net/ethernet/toshiba/tc35815.c > > > > @@ -1436,9 +1436,7 @@ static irqreturn_t tc35815_interrupt(int irq, void *dev_id) > > > > if (!(dmactl & DMA_IntMask)) { > > > > /* disable interrupts */ > > > > tc_writel(dmactl | DMA_IntMask, &tr->DMA_Ctl); > > > > - if (napi_schedule_prep(&lp->napi)) > > > > - __napi_schedule(&lp->napi); > > > > - else { > > > > + if (!napi_schedule(&lp->napi)) { > > > > printk(KERN_ERR "%s: interrupt taken in poll\n", > > > > dev->name); > > > > BUG(); > > > > > > Hmmm... could you also remove this BUG() ? I think this code path can be taken > > > if some applications are using busy polling. > > > > > > Or simply rewrite this with the traditional > > > > > > if (napi_schedule_prep(&lp->napi)) { > > > /* disable interrupts */ > > > tc_writel(dmactl | DMA_IntMask, &tr->DMA_Ctl); > > > __napi_schedule(&lp->napi); > > > } > > > > > > > > > > Mhhh is it safe to do so? I mean it seems very wrong to print a warning > > and BUG() instead of disabling the interrupt only if napi can be > > scheduled... Maybe is very old code? The more I see this the more I see > > problem... (randomly disabling the interrupt and then make the kernel > > die) > > I am pretty sure this BUG() can be hit these days with busy polling or > setting gro_flush_timeout. > > I wish we could remove these bugs before someone copy-paste them. > > Again, this is orthogonal, I might simply stop doing reviews if this > is not useful. They are very useful and thanks a lot for them! I'm asking these as to understand how to proceed. I have in queue 2 other series that depends on this and I'm just asking info on how to speedup the progress on this! Soo think I have to send v3 with the suggested change and BUG() dropped? Happy to do everything to fix and improve this series! -- Ansuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A92D4E95A67 for ; Sun, 8 Oct 2023 22:05:11 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RLiSrSV6; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S3bnK6gNmz3cJl for ; Mon, 9 Oct 2023 09:05:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RLiSrSV6; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::42c; helo=mail-wr1-x42c.google.com; envelope-from=ansuelsmth@gmail.com; receiver=lists.ozlabs.org) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S3VyR36Whz2yq2 for ; Mon, 9 Oct 2023 05:27:41 +1100 (AEDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-327be5fe4beso3493655f8f.3 for ; Sun, 08 Oct 2023 11:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696789654; x=1697394454; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=UYhUlM0v/kiBnSA7qqkERNTe3ha0hd9wd9BeXsJuFRo=; b=RLiSrSV6uJxuQ8T1y43SwW9mvR44TQbUqw79IJjusYUXAfbnpXYG3Epk4Oo7Ocol4l VSvE1DHusx+KA3RbNSQBR0CofDlknCmNjKrmarEUlFBD4SVZTuOMjkedmruh2zWFpjgx +9Izpj3hvZOtN1lah7m+9LiCIz1ctHiXMkv4YHm1qb/0nOTopOgUhsS1111ooAo2w9Eh 0/0fOm2lrIStLSbF/IhqcQnjuQ51yyWOphBpB0U3emJFGrUF6zNyalB4AKEKkkFG1KOA +QucTQLnQwwCobXcSgWFVMqOWDa5zsqRvaaMqzd+zr2e8FmNQGhUZIGrLUVS3mkh0K0Z 9PEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696789654; x=1697394454; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UYhUlM0v/kiBnSA7qqkERNTe3ha0hd9wd9BeXsJuFRo=; b=sFlKklDh9c8BORLjQWdKdBx/UG2viUh/yhp872xv+DFlyKth+rQMZnd82vf1yis9fo Yhn3+XRgXRk/2lTAQlm7QTITjfHhzhLrOA8RobbScp/CwNHBuH2szUygs00+NCa5Mt2W iyb83wKBeA87HqGWbFQSqV7RMy4Sb8YY0pjNLrjOW98GTp7c6QbaPXAeSZBXOFE//E66 AAUWVoVYIKONWfQr3nLq/pGviI1tTX9IuZ/vi22MTXZqtpKoCaFp0DQ6ww5+dnmM51r2 vjr9s20E6r63Tn/TeK1sCfOL7osf3JY+R17ucyeYjubPpFgZe/Lwv8uT4R49KWqzxTuk FBhQ== X-Gm-Message-State: AOJu0YwUnJj4+FXy4Y/ED6jOOtNiNnjBhDZ4dPri5tksHlsAXeFy7RLV hY2xl+iMc9NpIMLc14ZV/yQ= X-Google-Smtp-Source: AGHT+IG1Z2UQG/8uimtzwOsX0SSnSzQeAnFClPvayUdx2bESkKFHKQw9/TSlsvhrREuwaEcXQ8SiYA== X-Received: by 2002:a5d:50c8:0:b0:316:f24b:597a with SMTP id f8-20020a5d50c8000000b00316f24b597amr11755917wrt.46.1696789653876; Sun, 08 Oct 2023 11:27:33 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id j14-20020adff54e000000b003233a31a467sm7413627wrp.34.2023.10.08.11.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 11:27:33 -0700 (PDT) Message-ID: <6522f495.df0a0220.326ed.de6c@mx.google.com> X-Google-Original-Message-ID: Date: Sun, 8 Oct 2023 20:27:28 +0200 From: Christian Marangi To: Eric Dumazet Subject: Re: [net-next PATCH v2 4/4] netdev: use napi_schedule bool instead of napi_schedule_prep/__napi_schedule References: <20231003145150.2498-1-ansuelsmth@gmail.com> <20231003145150.2498-4-ansuelsmth@gmail.com> <652056c5.5d0a0220.2b60d.c5dc@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Approved-At: Mon, 09 Oct 2023 09:04:22 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Sergey Ryazanov , Ziwei Xiao , Chris Snook , Rick Lindsley , Alexandre Torgue , Krzysztof Halasa , Yuri Karpov , netdev@vger.kernel.org, ath10k@lists.infradead.org, Dany Madden , Gregory Greenman , Zhengchao Shao , Chiranjeevi Rapolu , Dawei Li , Intel Corporation , Rob Herring , Jeroen de Borst , Leon Romanovsky , linux-rdma@vger.kernel.org, Lee Jones , Haren Myneni , linux-stm32@st-md-mailman.stormreply.com, Rushil Gupta , Jason Gunthorpe , Thomas Falcon , Jose Abreu , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-wireless@vger.kernel.org, Jakub Kicinski , Paolo Abeni , Wei Fang , Wolfgang Grandegger , Nick Child , Simon Horman , Liu Haijun , Kalle Valo , linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , linux-can@vger.kernel.org, Yuanjun Gong , Shailend Chand , Marc Kleine-Budde , Benjamin Berg , M Chetan Kumar , Thomas Gleixner , Coco Li , linux-arm-kernel@lists.infradead.org, Chandrashekar Devegowda , Ricardo Martinez , Loic Poulain , Zheng Zengkai , Maximilian Lu z , Anjaneyulu , "Rafael J. Wysocki" , Douglas Miller , linux-kernel@vger.kernel.org, Tariq Toukan , Krzysztof Kozlowski , Junfeng Guo , Maxime Coquelin , Raju Rangoju , Praveen Kaligineedi , Johannes Berg , Jeff Johnson , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Oct 08, 2023 at 09:08:41AM +0200, Eric Dumazet wrote: > On Fri, Oct 6, 2023 at 8:49 PM Christian Marangi wrote: > > > > On Thu, Oct 05, 2023 at 06:16:26PM +0200, Eric Dumazet wrote: > > > On Tue, Oct 3, 2023 at 8:36 PM Christian Marangi wrote: > > > > > > > > Replace if condition of napi_schedule_prep/__napi_schedule and use bool > > > > from napi_schedule directly where possible. > > > > > > > > Signed-off-by: Christian Marangi > > > > --- > > > > drivers/net/ethernet/atheros/atlx/atl1.c | 4 +--- > > > > drivers/net/ethernet/toshiba/tc35815.c | 4 +--- > > > > drivers/net/wireless/intel/iwlwifi/pcie/rx.c | 4 +--- > > > > 3 files changed, 3 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c > > > > index 02aa6fd8ebc2..a9014d7932db 100644 > > > > --- a/drivers/net/ethernet/atheros/atlx/atl1.c > > > > +++ b/drivers/net/ethernet/atheros/atlx/atl1.c > > > > @@ -2446,7 +2446,7 @@ static int atl1_rings_clean(struct napi_struct *napi, int budget) > > > > > > > > static inline int atl1_sched_rings_clean(struct atl1_adapter* adapter) > > > > { > > > > - if (!napi_schedule_prep(&adapter->napi)) > > > > + if (!napi_schedule(&adapter->napi)) > > > > /* It is possible in case even the RX/TX ints are disabled via IMR > > > > * register the ISR bits are set anyway (but do not produce IRQ). > > > > * To handle such situation the napi functions used to check is > > > > @@ -2454,8 +2454,6 @@ static inline int atl1_sched_rings_clean(struct atl1_adapter* adapter) > > > > */ > > > > return 0; > > > > > > > > - __napi_schedule(&adapter->napi); > > > > - > > > > /* > > > > * Disable RX/TX ints via IMR register if it is > > > > * allowed. NAPI handler must reenable them in same > > > > diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c > > > > index 14cf6ecf6d0d..a8b8a0e13f9a 100644 > > > > --- a/drivers/net/ethernet/toshiba/tc35815.c > > > > +++ b/drivers/net/ethernet/toshiba/tc35815.c > > > > @@ -1436,9 +1436,7 @@ static irqreturn_t tc35815_interrupt(int irq, void *dev_id) > > > > if (!(dmactl & DMA_IntMask)) { > > > > /* disable interrupts */ > > > > tc_writel(dmactl | DMA_IntMask, &tr->DMA_Ctl); > > > > - if (napi_schedule_prep(&lp->napi)) > > > > - __napi_schedule(&lp->napi); > > > > - else { > > > > + if (!napi_schedule(&lp->napi)) { > > > > printk(KERN_ERR "%s: interrupt taken in poll\n", > > > > dev->name); > > > > BUG(); > > > > > > Hmmm... could you also remove this BUG() ? I think this code path can be taken > > > if some applications are using busy polling. > > > > > > Or simply rewrite this with the traditional > > > > > > if (napi_schedule_prep(&lp->napi)) { > > > /* disable interrupts */ > > > tc_writel(dmactl | DMA_IntMask, &tr->DMA_Ctl); > > > __napi_schedule(&lp->napi); > > > } > > > > > > > > > > Mhhh is it safe to do so? I mean it seems very wrong to print a warning > > and BUG() instead of disabling the interrupt only if napi can be > > scheduled... Maybe is very old code? The more I see this the more I see > > problem... (randomly disabling the interrupt and then make the kernel > > die) > > I am pretty sure this BUG() can be hit these days with busy polling or > setting gro_flush_timeout. > > I wish we could remove these bugs before someone copy-paste them. > > Again, this is orthogonal, I might simply stop doing reviews if this > is not useful. They are very useful and thanks a lot for them! I'm asking these as to understand how to proceed. I have in queue 2 other series that depends on this and I'm just asking info on how to speedup the progress on this! Soo think I have to send v3 with the suggested change and BUG() dropped? Happy to do everything to fix and improve this series! -- Ansuel