From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33 Date: Tue, 23 Aug 2016 14:50:32 +0800 Message-ID: <652921471935032@web14j.yandex.ru> References: <20160823055826.20591-1-icenowy@aosc.xyz> <20160823064755.GA2598@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160823064755.GA2598@lukather> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Ripard Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Linus Walleij , Russell King , "linux-kernel@vger.kernel.org" , Hans de Goede , Chen-Yu Tsai , Rob Herring , "linux-arm-kernel@lists.infradead.org" List-Id: linux-gpio@vger.kernel.org CgoyMy4wOC4yMDE2LCAxNDo0NywgIk1heGltZSBSaXBhcmQiIDxtYXhpbWUucmlwYXJkQGZyZWUt ZWxlY3Ryb25zLmNvbT46Cj4gSGksCj4KPiBPbiBUdWUsIEF1ZyAyMywgMjAxNiBhdCAwMTo1ODoy NVBNICswODAwLCBJY2Vub3d5IFpoZW5nIHdyb3RlOgo+PiDCoFBHOCwgUEc5IGlzIHNhaWQgdG8g YmUgdGhlIENUUy9SVFMgcGlucyBmb3IgVUFSVDEgYWNjb3JkaW5nIHRvIHRoZSBBMjMvMzMKPj4g wqBkYXRhc2hlZXRzLiBIb3dldmVyLCB0aGUgZnVuY3Rpb24gaXMgd3JvbmdseSBuYW1lZCAidWFy dDIiIGluIHRoZSBwaW5jdHJsCj4+IMKgZHJpdmVyLiBUaGlzIHBhdGNoIGZpeGVzIHRoaXMgYnkg bW9kaWZ5aW5nIHRoZW0gdG8gYmUgbmFtZWQgInVhcnQxIi4KPj4KPj4gwqBTaWduZWQtb2ZmLWJ5 OiBJY2Vub3d5IFpoZW5nIDxpY2Vub3d5QGFvc2MueHl6Pgo+Cj4gVGhpcyBsb29rcyBnb29kLCBi dXQgY291bGQgeW91IHNlbmQgaXQgdG8gc3RhYmxlPwoKWWVzLi4uIEJ1dCBjdXJyZW50bHkgaW4g bWFpbmxpbmUga2VybmVsLCBubyBkdCBmaWxlIGZvciBBMjMvMzMgdXNlcyBVQVJUMS4KKExvdHMg b2YgdGhlIHRhYmxldHMgaXMgc28gbG93LWVuZCB0aGF0IHRoZXkgZG8gbm90IHNoaXAgd2l0aCBC VCBzdXBwb3J0LCBhbmQKdGhlbiBubyBzdXBwb3J0IGZvciBleHRyYSBVQVJUIGlzIG5lZWRlZCkK CkkgZm91bmQgdGhlIHByb2JsZW0gd2hlbiBydW5uaW5nIG1haW5saW5lIGtlcm5lbCBvbiBteSBp TmV0IEQ5NzggUmV2MiBib2FyZAp0YWJsZXQuIEl0IGNvbWUgd2l0aCBhIFJUTDg3MjNCUy4KCj4K PiBUaGFua3MsCj4gTWF4aW1lCj4KPiAtLQo+IE1heGltZSBSaXBhcmQsIEZyZWUgRWxlY3Ryb25z Cj4gRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwo+IGh0dHA6Ly9mcmVlLWVs ZWN0cm9ucy5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Tue, 23 Aug 2016 14:50:32 +0800 Subject: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33 In-Reply-To: <20160823064755.GA2598@lukather> References: <20160823055826.20591-1-icenowy@aosc.xyz> <20160823064755.GA2598@lukather> Message-ID: <652921471935032@web14j.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 23.08.2016, 14:47, "Maxime Ripard" : > Hi, > > On Tue, Aug 23, 2016 at 01:58:25PM +0800, Icenowy Zheng wrote: >> ?PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33 >> ?datasheets. However, the function is wrongly named "uart2" in the pinctrl >> ?driver. This patch fixes this by modifying them to be named "uart1". >> >> ?Signed-off-by: Icenowy Zheng > > This looks good, but could you send it to stable? Yes... But currently in mainline kernel, no dt file for A23/33 uses UART1. (Lots of the tablets is so low-end that they do not ship with BT support, and then no support for extra UART is needed) I found the problem when running mainline kernel on my iNet D978 Rev2 board tablet. It come with a RTL8723BS. > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com