All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	rajvi.jingar@linux.intel.com,
	 platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/8] Intel PMC Core GBE LTR regression fix
Date: Wed, 27 Dec 2023 20:14:27 +0200 (EET)	[thread overview]
Message-ID: <652cf483-6098-5e0-94ef-fdca344fa2ac@linux.intel.com> (raw)
In-Reply-To: <20231223032548.1680738-1-david.e.box@linux.intel.com>

On Fri, 22 Dec 2023, David E. Box wrote:

> This patch series addresses the network performance regression caused by
> commit 804951203aa5 ("platform/x86:intel/pmc: Combine core_init() and
> core_configure()").
> 
> Unfortunately, the regression is included in the recent Lunar Lake and
> Arrow Lake support patches in the review branch. Patches 1 and 2 remove the
> LTR ignore without a fix. They may be folded into the respective enabling
> patches indicated in the changelog. This is done so that the next patches
> fixing the regression can be backported to stable kernels with fewer, if
> any, conflicts.
> 
> Patches 3 and 4 provide the support needed for Patch 5 to move the GBE LTR
> ignore from probe-time to suspend/resume time. All three carry the same
> Fixes tag so that the stable kernels can pick them up without causing a
> separate suspend-time PC10 regression.
>
> Patches 6 and 7 then add the LTR suspend/resume fix for Arrow Lake and
> Lunar Lake. Of course, they cannot be folded into the enabling patches
> unless the LTR fixes (3-5) are applied before. Sorry about this :(.

Wow, this is messy...

So the best order would be placing 3-5 before these Arrow Lake and Lunar 
Lake commits in for-next:
  119652b855e6 ("platform/x86/intel/pmc: Add Lunar Lake M support to intel_pmc_core driver")
  f34dcf397286 ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver")
? And then folding 1-2 and 6-7 into those respective commits?

It makes me wonder though why those two commits couldn't have been delayed 
slightly to get these fixes included first... :-/


-- 
 i.


  parent reply	other threads:[~2023-12-27 18:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-23  3:25 [PATCH 0/8] Intel PMC Core GBE LTR regression fix David E. Box
2023-12-23  3:25 ` [PATCH 1/8] platform/x86/intel/pmc/arl.c: Remove probe time LTR ignore David E. Box
2023-12-23  3:25 ` [PATCH 2/8] platform/x86/intel/pmc/lnl.c: " David E. Box
2023-12-23  3:25 ` [PATCH 3/8] platform/x86/intel/pmc: Add suspend callback David E. Box
2023-12-23  3:25 ` [PATCH 4/8] platform/x86/intel/pmc: Allow reenabling LTRs David E. Box
2023-12-27 17:54   ` Ilpo Järvinen
2023-12-28 15:43     ` Ilpo Järvinen
2023-12-23  3:25 ` [PATCH 5/8] platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback David E. Box
2023-12-23  3:25 ` [PATCH 6/8] platform/x86/intel/pmc/arl: Add GBE LTR ignore during suspend David E. Box
2024-01-02 12:24   ` Hans de Goede
2023-12-23  3:25 ` [PATCH 7/8] platform/x86/intel/pmc/lnl: " David E. Box
2024-01-02 12:24   ` Hans de Goede
2023-12-23  3:25 ` [PATCH 8/8] platform/x86/intel/pmc: Add missing extern David E. Box
2024-01-02 12:24   ` Hans de Goede
2023-12-27 18:14 ` Ilpo Järvinen [this message]
2023-12-28  9:35   ` [PATCH 0/8] Intel PMC Core GBE LTR regression fix Hans de Goede
2023-12-28 15:38     ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=652cf483-6098-5e0-94ef-fdca344fa2ac@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=david.e.box@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rajvi.jingar@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.