From: Ira Weiny <ira.weiny@intel.com>
To: Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/pmu: Ensure put_device on pmu devices
Date: Tue, 17 Oct 2023 08:35:11 -0700 [thread overview]
Message-ID: <652ea9afdf5b_2b0d2929417@iweiny-mobl.notmuch> (raw)
In-Reply-To: <b62ded44-4432-4aee-a086-1171b89fd2ae@intel.com>
Dave Jiang wrote:
>
>
[snip]
> >
> > Properly call device_unregister() to free up the memory associated with
> > the device.
> >
> > Fixes: 1ad3f701c399 ("cxl/pci: Find and register CXL PMU devices")
> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>
> Although I wonder if we can just give device_unregister() to devm_add_action_or_reset() directly.
>
No because the action callback takes void * and device_unregister() takes
a struct device *.
Ira
[snip]
next prev parent reply other threads:[~2023-10-17 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 23:25 [PATCH] cxl/pmu: Ensure put_device on pmu devices Ira Weiny
2023-10-16 23:43 ` Dave Jiang
2023-10-17 15:35 ` Ira Weiny [this message]
2023-10-17 16:21 ` Dave Jiang
2023-10-18 10:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652ea9afdf5b_2b0d2929417@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.