From: John Fastabend <john.fastabend@gmail.com>
To: Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org,
John Fastabend <john.fastabend@gmail.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
bpf@vger.kernel.org
Subject: Re: [PATCH net] tcp_bpf: properly release resources on error paths
Date: Wed, 18 Oct 2023 12:18:21 -0700 [thread overview]
Message-ID: <65302f7d693a8_b74c20846@john.notmuch> (raw)
In-Reply-To: <CANn89iL0f+RWFm1FuNmKjoeMTMZQZHW8=83ZQnUxiY8B6hHxrg@mail.gmail.com>
Eric Dumazet wrote:
> On Tue, Oct 17, 2023 at 5:50 PM Paolo Abeni <pabeni@redhat.com> wrote:
> >
> > In the blamed commit below, I completely forgot to release the acquired
> > resources before erroring out in the TCP BPF code, as reported by Dan.
> >
> > Address the issues by replacing the bogus return with a jump to the
> > relevant cleanup code.
> >
> > Fixes: 419ce133ab92 ("tcp: allow again tcp_disconnect() when threads are waiting")
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>
> Right :)
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks.
Reviewed-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2023-10-18 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 15:49 [PATCH net] tcp_bpf: properly release resources on error paths Paolo Abeni
2023-10-18 13:11 ` Jakub Sitnicki
2023-10-18 13:52 ` Eric Dumazet
2023-10-18 19:18 ` John Fastabend [this message]
2023-10-19 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65302f7d693a8_b74c20846@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.