From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: twoerner@gmail.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/3] oeqa/sdk: run the SDK's own copy of a host tool
Date: Mon, 31 Aug 2026 20:44:50 +0100 [thread overview]
Message-ID: <65375fb1c8ad8758f22fdbac330577bf8cda81fb.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260830183616.4026354-1-twoerner@gmail.com>
On Sun, 2026-08-30 at 14:36 -0400, Trevor Woerner via lists.openembedded.org wrote:
> ensure_host_package() decides whether a test can run by looking for a
> package name in the SDK's host manifest, which establishes neither that
> the package is present nor that the command the test runs is the SDK's
> own. On an extensible SDK the manifest lists what the shipped sstate
> could provide, so a case can pass the check and then run a command that
> is not there, or one belonging to the build host.
>
> Ask the SDK for the command instead. An eSDK ships sstate for more than
> it installs, so when the command is missing devtool installs the recipe
> and the lookup runs again. A command that resolves outside the SDK now
> fails rather than reporting a result about the build host.
>
> AI-Generated: codex/claude-opus 5 (xhigh)
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> meta/lib/oeqa/sdk/case.py | 96 ++++++++++++++++++++++++++++-----------
> 1 file changed, 69 insertions(+), 27 deletions(-)
I'll be honest, this feels/looks wrong. In order to say why, I need to
spend a lot of time looking into the problem more, trying to work out
the right way to solve it and so on.
If I keep doing this, people will just keep feeding me patches like
this and expecting me to give that level of feedback which I simply
can't do, it isn't easy.
So no, this isn't right and no, I don't feel it appropriate to merge
it, sorry.
Cheers,
Richard
next prev parent reply other threads:[~2026-08-31 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 18:36 [PATCH 1/3] oeqa/sdk: run the SDK's own copy of a host tool Trevor Woerner
2026-08-30 18:36 ` [PATCH 2/3] oeqa/sdk: name the commands the host tool cases need Trevor Woerner
2026-08-30 18:36 ` [PATCH 3/3] oeqa/sdk: run the Go driver the SDK installs Trevor Woerner
2026-08-31 18:43 ` [OE-core] [PATCH 1/3] oeqa/sdk: run the SDK's own copy of a host tool Mathieu Dubois-Briand
2026-08-31 19:44 ` Richard Purdie [this message]
2026-08-31 21:24 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65375fb1c8ad8758f22fdbac330577bf8cda81fb.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.