All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux SCSI <linux-scsi@vger.kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Rob Landley <rob@landley.net>
Subject: Re: [PATCH] scsi: Format scsi_track_queue_full() return values as bullet list
Date: Tue, 1 Jul 2025 09:50:17 +0700	[thread overview]
Message-ID: <6538b497-6e65-4e02-a102-7f9649dbf231@gmail.com> (raw)
In-Reply-To: <159d1b84-665f-4bc7-865c-59b15232a477@acm.org>

On 6/26/25 23:16, Bart Van Assche wrote:
> On 6/25/25 9:18 PM, Bagas Sanjaya wrote:
>> - * Returns:    0 - No change needed, >0 - Adjust queue depth to this 
>> new depth,
>> - *         -1 - Drop back to untagged operation using host->cmd_per_lun
>> - *             as the untagged command depth
>> + * Returns:    * 0 - No change needed
>> + *        * >0 - Adjust queue depth to this new depth,
>> + *         * -1 - Drop back to untagged operation using host- 
>> >cmd_per_lun
>> + *           as the untagged command depth
>>    *
>>    * Lock Status:    None held on entry
>>    *
> 
> Here is an example from Documentation/doc-guide/kernel-doc.rst:
> 
>        * Return:
>        * * %0        - OK to runtime suspend the device
>        * * %-EBUSY    - Device should not be runtime suspended
> 
> Wouldn't it be better to follow that example and to move the list under
> 'Returns:' and to move it more to the left?
> 

Ack. I will do that in v2.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

      parent reply	other threads:[~2025-07-01  2:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26  4:18 [PATCH] scsi: Format scsi_track_queue_full() return values as bullet list Bagas Sanjaya
2025-06-26 16:16 ` Bart Van Assche
2025-06-26 23:08   ` Bagas Sanjaya
2025-07-01  2:50   ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6538b497-6e65-4e02-a102-7f9649dbf231@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.