From: David Hildenbrand <david@redhat.com>
To: Liam Howlett <liam.howlett@oracle.com>,
"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] maple_tree: Fix sparse reported issues
Date: Wed, 13 Jul 2022 10:34:01 +0200 [thread overview]
Message-ID: <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com> (raw)
In-Reply-To: <20220712142441.4184969-1-Liam.Howlett@oracle.com>
On 12.07.22 16:24, Liam Howlett wrote:
> When building with C=1, the maple tree had some rcu type mismatch &
> locking mismatches in the destroy functions. There were cosmetic only
> since this happens after the nodes are removed from the tree.
>
> Fixes: f8acc5e9581e (Maple Tree: add new data structure)
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Sorry to say, but the fixes become hard to follow (what/where/why). :)
I guess it's time for a new series soon. Eventually it makes sense to
send the fixes as reply to the individual problematic patches. (instead
of fixes to commit ids that are not upstream)
[yes, I'll do more review soon :) ]
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-07-13 8:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 14:24 [PATCH] maple_tree: Fix sparse reported issues Liam Howlett
2022-07-12 14:54 ` Matthew Wilcox
2022-07-12 15:44 ` Liam Howlett
2022-07-13 8:34 ` David Hildenbrand [this message]
2022-07-13 13:29 ` Liam Howlett
2022-07-13 15:55 ` Hugh Dickins
2022-07-13 17:50 ` Liam Howlett
2022-07-15 19:53 ` Liam Howlett
2022-07-17 20:57 ` Hugh Dickins
2022-07-18 2:27 ` Liam Howlett
2022-07-18 4:28 ` Hugh Dickins
2022-07-18 6:47 ` Hugh Dickins
2022-07-18 12:56 ` Liam Howlett
2022-07-18 13:45 ` Liam Howlett
2022-07-18 17:30 ` Hugh Dickins
2022-07-18 17:47 ` Liam Howlett
2022-07-18 21:34 ` Hugh Dickins
2022-07-19 1:39 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.