All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Minor NFSD global DRC clean-ups
Date: Fri, 17 Jul 2026 07:38:25 -0400	[thread overview]
Message-ID: <6542630e20d90e5cc32bfe3af1a3beb06575ef67.camel@kernel.org> (raw)
In-Reply-To: <20260717001232.438792-1-cel@kernel.org>

On Thu, 2026-07-16 at 20:12 -0400, Chuck Lever wrote:
> I'm working on a series of global DRC improvements. A few minor
> clean-ups are ready for merge now.
> 
> Chuck Lever (5):
>   NFSD: Fix off-by-one in DRC bucket pruning limit
>   NFSD: Eliminate percpu counter contention in DRC memory accounting
>   NFSD: Eliminate percpu counter contention in reply cache statistics
>   NFSD: Eliminate percpu counter contention in IO byte accounting
>   NFSD: Document reply_cache_stats ABI
> 
>  .../ABI/testing/procfs-nfsd-reply_cache_stats | 38 +++++++++
>  fs/nfsd/nfscache.c                            |  2 +-
>  fs/nfsd/stats.h                               | 78 ++++++++++++++++---
>  3 files changed, 108 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/ABI/testing/procfs-nfsd-reply_cache_stats

I had no idea that percpu counters could devolve into spinlocking in
certain conditions. Ick. I wonder if we need to do a pass over all of
our percpu counter usage for the same sort of thing. ISTM that we
pretty much always want to use the *_local versions for our use-cases.

In any case, for this series:

Reviewed-by: Jeff Layton <jlayton@kernel.org>

      parent reply	other threads:[~2026-07-17 11:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  0:12 [PATCH 0/5] Minor NFSD global DRC clean-ups Chuck Lever
2026-07-17  0:12 ` [PATCH 1/5] NFSD: Fix off-by-one in DRC bucket pruning limit Chuck Lever
2026-07-17  0:12 ` [PATCH 2/5] NFSD: Eliminate percpu counter contention in DRC memory accounting Chuck Lever
2026-07-17 11:35   ` Jeff Layton
2026-07-17  0:12 ` [PATCH 3/5] NFSD: Eliminate percpu counter contention in reply cache statistics Chuck Lever
2026-07-17  0:12 ` [PATCH 4/5] NFSD: Eliminate percpu counter contention in IO byte accounting Chuck Lever
2026-07-17  0:12 ` [PATCH 5/5] NFSD: Document reply_cache_stats ABI Chuck Lever
2026-07-17  4:44 ` [PATCH 0/5] Minor NFSD global DRC clean-ups NeilBrown
2026-07-17 11:38 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6542630e20d90e5cc32bfe3af1a3beb06575ef67.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=cel@kernel.org \
    --cc=dai.ngo@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.