From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Robert Marko <robimarko@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next RFC PATCH v3 1/4] net: phy: aquantia: move to separate directory
Date: Thu, 2 Nov 2023 16:07:41 +0100 [thread overview]
Message-ID: <6543bb3e.df0a0220.385df.cdb1@mx.google.com> (raw)
In-Reply-To: <5f60b2dc-4e97-49dc-8427-306400fb1b71@lunn.ch>
On Thu, Nov 02, 2023 at 04:03:33PM +0100, Andrew Lunn wrote:
> > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> > index 421d2b62918f..4b2451dd6c45 100644
> > --- a/drivers/net/phy/Kconfig
> > +++ b/drivers/net/phy/Kconfig
> > @@ -68,6 +68,8 @@ config SFP
> >
> > comment "MII PHY device drivers"
> >
> > +source "drivers/net/phy/aquantia/Kconfig"
> > +
> > config AMD_PHY
> > tristate "AMD and Altima PHYs"
> > help
> > @@ -96,11 +98,6 @@ config ADIN1100_PHY
> > Currently supports the:
> > - ADIN1100 - Robust,Industrial, Low Power 10BASE-T1L Ethernet PHY
> >
> > -config AQUANTIA_PHY
> > - tristate "Aquantia PHYs"
> > - help
> > - Currently supports the Aquantia AQ1202, AQ2104, AQR105, AQR405
> > -
>
> Does this move the PHY in the make menuconfig menu? We try to keep it
> sorted based on the tristate string.
>
Oh wasn't aware... Yes it does move it to the top of the list... I can
just move the source entry where AQUANTIA_PHY was... Or if we really
want, not create a dedicated Kconfig for it and keep everything in PHY.
--
Ansuel
next prev parent reply other threads:[~2023-11-02 15:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 15:00 [net-next RFC PATCH v3 1/4] net: phy: aquantia: move to separate directory Christian Marangi
2023-11-02 15:00 ` [net-next RFC PATCH v3 2/4] net: phy: aquantia: move MMD_VEND define to header Christian Marangi
2023-11-02 17:19 ` Andrew Lunn
2023-11-02 15:00 ` [net-next RFC PATCH v3 3/4] net: phy: aquantia: add firmware load support Christian Marangi
2023-11-02 17:37 ` Andrew Lunn
2023-11-02 17:41 ` Christian Marangi
2023-11-02 15:00 ` [net-next RFC PATCH v3 4/4] dt-bindings: Document bindings for Marvell Aquantia PHY Christian Marangi
2023-11-03 13:08 ` Conor Dooley
2023-11-06 16:47 ` Christian Marangi
2023-11-02 15:03 ` [net-next RFC PATCH v3 1/4] net: phy: aquantia: move to separate directory Andrew Lunn
2023-11-02 15:07 ` Christian Marangi [this message]
2023-11-02 15:49 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6543bb3e.df0a0220.385df.cdb1@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.