From: "Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com>
To: Ashutosh Dixit <ashutosh.dixit@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: Re: [PATCH i-g-t 2/3] tests/intel/xe_oa: Don't limit sync tests to render engine
Date: Fri, 14 Mar 2025 12:41:28 +0530 [thread overview]
Message-ID: <65457de6-5e39-416b-8cea-a7d95c8daf64@intel.com> (raw)
In-Reply-To: <20250314002058.220854-3-ashutosh.dixit@intel.com>
On 14-03-2025 05:50, Ashutosh Dixit wrote:
> OA sync tests need not be limited to render engine only. Extend them to use
> any engine using __for_one_hwe_in_oag macro instead.
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
LGTM,
Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
> ---
> tests/intel/xe_oa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 245481f8a3..2c48623a3b 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4905,7 +4905,7 @@ igt_main
>
> for (const struct sync_section *s = sync_sections; s->name; s++) {
> igt_subtest_with_dynamic_f("syncs-%s", s->name) {
> - __for_one_render_engine(hwe)
> + __for_one_hwe_in_oag(hwe)
> test_syncs(hwe, s->sync_type, s->flags);
> }
> }
next prev parent reply other threads:[~2025-03-14 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 0:20 [PATCH i-g-t 0/3] tests/intel/xe_oa: Fix __for_one_render_engine Ashutosh Dixit
2025-03-14 0:20 ` [PATCH i-g-t 1/3] " Ashutosh Dixit
2025-03-14 7:07 ` Pottumuttu, Sai Teja
2025-03-14 0:20 ` [PATCH i-g-t 2/3] tests/intel/xe_oa: Don't limit sync tests to render engine Ashutosh Dixit
2025-03-14 7:11 ` Pottumuttu, Sai Teja [this message]
2025-03-14 0:20 ` [PATCH i-g-t 3/3] tests/amdgpu/amd_hotplug: Fix compile on Ubuntu 24 Ashutosh Dixit
2025-03-14 15:18 ` Pottumuttu, Sai Teja
2025-03-14 17:22 ` ✓ Xe.CI.Full: success for tests/intel/xe_oa: Fix __for_one_render_engine Patchwork
2025-03-14 23:39 ` ✗ Fi.CI.BUILD: failure for tests/intel/xe_oa: Fix __for_one_render_engine (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65457de6-5e39-416b-8cea-a7d95c8daf64@intel.com \
--to=sai.teja.pottumuttu@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.