Re: [PATCH 3/5] scsi: pm80xx: Add helper function to get the local phy id

[Damien Le Moal <dlemoal@kernel.org>]

On 8/13/25 8:41 PM, Niklas Cassel wrote:
> Avoid duplicated code by adding a helper to get the local phy id.
> 
> No functional changes intended.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

[...]

> +u32 pm80xx_get_local_phy_id(struct domain_device *dev)
> +{
> +	struct pm8001_device *pm8001_dev = dev->lldd_dev;
> +	struct domain_device *parent_dev = dev->parent;
> +
> +	if (parent_dev && dev_is_expander(parent_dev->dev_type))
> +		return parent_dev->ex_dev.ex_phy->phy_id;
> +	else
> +		return pm8001_dev->attached_phy;

Nit: no need for else after a return.
Also, maybe reverse the condition to have this a tad faster for direct attach
devices ?

	if (!parent_dev || !dev_is_expander(parent_dev->dev_type))
		return pm8001_dev->attached_phy;

	return parent_dev->ex_dev.ex_phy->phy_id;

Other than this, this looks good !

-- 
Damien Le Moal
Western Digital Research