From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34672C43381 for ; Tue, 26 Feb 2019 16:08:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02A232184D for ; Tue, 26 Feb 2019 16:08:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jDtOTrDU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727997AbfBZQIV (ORCPT ); Tue, 26 Feb 2019 11:08:21 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:36288 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbfBZQIV (ORCPT ); Tue, 26 Feb 2019 11:08:21 -0500 Received: by mail-pl1-f193.google.com with SMTP id k2so6457019plt.3 for ; Tue, 26 Feb 2019 08:08:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uEMhv/grOHZtUbdmMJRiqdjzZRnZBdlrBjnT4+NahRg=; b=jDtOTrDUepin4HI+VhNxPpIkR2kFsX2daFAWB4Ogy27gs+SliBBvHHjnty/0KrB16R aolyc3K/kBG/CUOWM2TCBoNmoGtXXEj2aSqmUy1LtcJtuKfAQCXI5CEtZjVNaIqHsL0Y d61hZLwiDmg7JcP3K/yJJn9G04k4Q/8JEvYvGHgXpXvjF5XUek/FJC9MODCwg9JopIIv 5hilqx4u4k92yflAzyUqdDY51KJJXaB1ZUARvtSDTgnAWvRcoIllPld30Sm6883tbXdM Zz0Scvqevu8u89xsCSBbD1l0jcTaFIa8zrDbV/Z3UZI6wdi1FVxV70IovuWXSQ+E70k+ Asag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uEMhv/grOHZtUbdmMJRiqdjzZRnZBdlrBjnT4+NahRg=; b=qvbSXFmqHVApvelXPKqYnkQa7hogeOBcSyjJHCAnMUm354la7JBTduiROBubXExqts GiE4X8ZgRWpdeWdAquVabhuyq0gTyOzRCfAtl5Q07TZUpwZ7AdSj7XWk6BR/bDp8gxRF OMuVyEWwK477qMPKLlIrwG2RO4JCm7v/Pyb/DdD2boVaP+xw/k0UyG6z7iriu4g9K5a2 YtEZvzCuR6r6KsKl8XyQO4Unt0JP0sibVnr8cJz811cYohI5qWrs9LV4WIlLZC4Pik11 4xSFcKit1LpQnWA5sIZnVH0Oew/htZY79mMwGCsJJwTq+OD0VFU6vjCNRVnAQaA5WhBS b0ZA== X-Gm-Message-State: AHQUAuZ97/gS4s32wrXahAkwp72l1bBV3yciKql4gVDyc+OQSW8VwXjT 6KyPeRnUpyJi6VUV63eXBss= X-Google-Smtp-Source: AHgI3IazDQP3O8Vz1D5OKkzvne4etxT6FCi3cbeQhm/7kR4cCNFg6x+N65iz8dADoLHNo2b6p2bUxg== X-Received: by 2002:a17:902:b58c:: with SMTP id a12mr26840795pls.102.1551197300871; Tue, 26 Feb 2019 08:08:20 -0800 (PST) Received: from [192.168.88.86] (216.sub-166-144-35.myvzw.com. [166.144.35.216]) by smtp.gmail.com with ESMTPSA id p6sm24206223pgd.69.2019.02.26.08.08.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 08:08:19 -0800 (PST) Subject: Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec To: Stephen Hemminger , Sheng Lan Cc: davem@davemloft.net, netdev@vger.kernel.org, netem@lists.linux-foundation.org, xuhanbing@huawei.com, zhengshaoyu@huawei.com, jiqin.ji@huawei.com, liuzhiqiang26@huawei.com, yuehaibing@huawei.com References: <20190225080147.30128f73@shemminger-XPS-13-9360> <05fa74b9-6e3b-7bd3-fa1c-c02e37a521f8@huawei.com> <20190226075906.103fa072@shemminger-XPS-13-9360> From: Eric Dumazet Message-ID: <655edad3-d09a-ea0e-e230-557bdedb712d@gmail.com> Date: Tue, 26 Feb 2019 08:08:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190226075906.103fa072@shemminger-XPS-13-9360> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/26/2019 07:59 AM, Stephen Hemminger wrote: > > > Maybe the fix is to stop TSO fragment from overwriting by doing something like: > > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > index 730bc44dbad9..5fe91d0224f6 100644 > --- a/net/ipv4/tcp_output.c > +++ b/net/ipv4/tcp_output.c > @@ -1856,7 +1856,7 @@ static int tso_fragment(struct sock *sk, enum tcp_queue tcp_queue, > u8 flags; > > /* All of a TSO frame must be composed of paged data. */ > - if (skb->len != skb->data_len) > + if (skb->len != skb->data_len || skb_cloned(skb)) > return tcp_fragment(sk, tcp_queue, skb, len, mss_now, gfp); > > buff = sk_stream_alloc_skb(sk, 0, gfp, true); > tso_fragment() is only called with packets that were not yet transmit.