Re: [PATCH v3 0/9] ARM: dts: exynos: add support for hdmi subsystem

[Tomasz Figa <t.figa@samsung.com>]

On Wednesday 14 of August 2013 19:11:39 Kukjin Kim wrote:
> Rahul Sharma wrote:
> > Common properties for I2C and Hdmi Subsystem is moved to exynos5
> > dtsi file. It also adds Device tree nodes and clocks information
> > for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi
> > hpd gpio and update binding documents.
> > 
> > This set is based on kukjin's for-next branch at
> > http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git.
> > 
> > v3:
> > 1) Rebase to kgene for-next based on 3.11-rc1.
> > 2) Changes clock numbers as per updated clocks file for
> > exyno5250 and exynos5420.
> > 3) Dropped Sachin patch as already got merged.
> > 
> > v2:
> > 1) Added patch for moving common i2c properties to exynos5.dtsi
> > 2) Added patch for moving common hdmi, mixer properties to exynos5.dtsi
> > 3) moved hpd pinctrl node to board file.
> > 4) Added Sachin's patch to update binding document for hdmi with hpd
> > information.
> > 
> > Andrew Bresticker (1):
> >   ARM: dts: exynos5420: add i2c device nodes
> > 
> > Rahul Sharma (7):
> >   ARM: dts: exynos5250: add clocks to hdmi dt node
> >   ARM: dts: exynos5250: move common i2c properties to exynos5 dtsi
> >   ARM: dts: exynos5250: move common hdmi properties to exynos5 dtsi
> >   ARM: dts: exynos5420: add dt nodes for hdmi subsystem
> >   ARM: dts: exynos5420: add clocks for hdmi subsystem
> >   ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node
> >   of/documentation: update with clock information for exynos hdmi
> >   
> >     subsystem
> > 
> > Sean Paul (1):
> >   ARM: dts: exynos5250: add mixer clocks to mixer node
> >  
> >  .../devicetree/bindings/video/exynos_hdmi.txt      |   14 +++++-
> >  .../devicetree/bindings/video/exynos_mixer.txt     |    4 ++
> >  arch/arm/boot/dts/cros5250-common.dtsi             |    2 +-
> >  arch/arm/boot/dts/exynos5.dtsi                     |   48
> 
> ++++++++++++++++++++
> 
> >  arch/arm/boot/dts/exynos5250-arndale.dts           |    8 +++-
> >  arch/arm/boot/dts/exynos5250-smdk5250.dts          |   10 +++-
> >  arch/arm/boot/dts/exynos5250-snow.dts              |    8 ++++
> >  arch/arm/boot/dts/exynos5250.dtsi                  |   36
> >  +++------------ arch/arm/boot/dts/exynos5420-smdk5420.dts          | 
> >   31 +++++++++++++ arch/arm/boot/dts/exynos5420.dtsi                 
> >  |   46
> 
> +++++++++++++++++++
> 
> >  10 files changed, 174 insertions(+), 33 deletions(-)
> > 
> > --
> > 1.7.10.4
> 
> See my comments about making common stuff for exynos5 SoCs.

I agree.

> And please don't use title like following,
> 
> 'ARM: dts: exynos0000: ....'.
> 
> Because the relatively long prefix of title can cover _real_ title, So
> just 'ARM: dts: .... in exynos000' is better.

Well, I tend to disagree on this. The ARM: dts: <platform name>: prefix is 
commonly used in arch/arm/boot/dts (see git log --oneline 
arch/arm/boot/dts).

As long as we don't cross the ~75 characters boundary in patch subject, I 
don't think this is any problem.

> 
> One more, devicetree(at)vger.kernel.org is right for dt ml.
+1

Also it is nice to Cc the device tree maintainers.

Best regards,
Tomasz