From: Jay Vosburgh <jv@jvosburgh.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Simon Horman <horms@kernel.org>, Cosmin Ratiu <cratiu@nvidia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 net] bonding: assign random address if device address is same as bond
Date: Fri, 25 Apr 2025 20:51:27 -0700 [thread overview]
Message-ID: <657157.1745639487@famine> (raw)
In-Reply-To: <20250425190419.273eb34b@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
>On Thu, 24 Apr 2025 16:44:52 -0700 Jay Vosburgh wrote:
>> The code flow is a little clunky in the "if (situation one) else
>> if (situation two) else goto skip_mac_set" bit, but I don't really have
>> a better suggestion that isn't clunky in some other way.
>>
>> This implementation does keep the already complicated failover
>> logic from becoming more complicated for this corner case.
>
>Any thoughts on whether we should route this as a fix or as a -next
>improvement? The commit under Fixes is almost old enough to drink.
I'm fine with -next, the hardware this option was originally
intended for was uncommon even then (IBM POWER ehea). I'm not aware of
any recent-ish devices with the issue this was solving (that multiple
ports of the NIC programmed with the same MAC made the hardware cranky),
so it's more of a correctness exercise in my mind.
-J
---
-Jay Vosburgh, jv@jvosburgh.net
next prev parent reply other threads:[~2025-04-26 3:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 4:22 [PATCHv3 net] bonding: assign random address if device address is same as bond Hangbin Liu
2025-04-24 23:44 ` Jay Vosburgh
2025-04-26 2:04 ` Jakub Kicinski
2025-04-26 3:51 ` Jay Vosburgh [this message]
2025-04-28 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657157.1745639487@famine \
--to=jv@jvosburgh.net \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.